Received-SPF: pass (google.com: domain of linux-kernel+bounces-48330-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Paolo Abeni <pabeni@redhat.com>
cc: Aahil Awatramani <aahila@google.com>,
    David Dillow <dave@thedillows.org>,
    Mahesh Bandewar <maheshb@google.com>,
    Hangbin Liu <liuhangbin@gmail.com>,
    Andy Gospodarek <andy@greyhouse.net>,
    "David S . Miller" <davem@davemloft.net>,
    Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
    Martin KaFai Lau <martin.lau@kernel.org>,
    Herbert Xu <herbert@gondor.apana.org.au>,
    Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org,
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] bonding: Add independent control state machine
In-reply-to: <15d7f2941394e04d45f98aa6d095b1e07262655c.camel@redhat.com>
References: <20240129202741.3424902-1-aahila@google.com> <15d7f2941394e04d45f98aa6d095b1e07262655c.camel@redhat.com>
Comments: In-reply-to Paolo Abeni <pabeni@redhat.com>
   message dated "Thu, 01 Feb 2024 11:15:40 +0100."
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32423.1706798605.1@famine>
Date: Thu, 01 Feb 2024 06:43:25 -0800
Message-ID: <32424.1706798605@famine>

Paolo Abeni <pabeni@redhat.com> wrote:

>On Mon, 2024-01-29 at 20:27 +0000, Aahil Awatramani wrote:
>> Add support for the independent control state machine per IEEE
>> 802.1AX-2008 5.4.15 in addition to the existing implementation of the
>> coupled control state machine.
>> 
>> Introduces two new states, AD_MUX_COLLECTING and AD_MUX_DISTRIBUTING in
>> the LACP MUX state machine for separated handling of an initial
>> Collecting state before the Collecting and Distributing state. This
>> enables a port to be in a state where it can receive incoming packets
>> while not still distributing. This is useful for reducing packet loss when
>> a port begins distributing before its partner is able to collect.
>
>If I read the code correctly, the transition
>AD_MUX_COLLECTING_DISTRIBUTING -> AD_MUX_DISTRIBUTING is not possible,
>am I correct?

	That's correct.  There are two completely separate state
machines in the 2008 standard, one for coupled control and one for
independent control.  The state machines utilize the same states other
than COLLECTING_DISTRIBUTING in the coupled control mode, and COLLECTING
and DISTRIBUTING in the independent control mode.

	Essentially, the two machines differ in the transition out from
ATTACHED state; coupled control moves to COLLECTING_DISTRIBUTING,
whereas independent control moves to COLLECTING then DISTRIBUTING.  

	The 2020 edition of the standard combines the two state machines
into one, and changes the set of states.  Bonding does not implement
this version of the standard.

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com