Received-SPF: pass (google.com: domain of linux-kernel+bounces-48335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d9ee41dc-c2f5-4c5f-9b07-126c14bfc798@intel.com>
Date: Thu, 1 Feb 2024 22:47:41 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] x86/kexec(): Reset TDX private memory on platforms
 with TDX erratum
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CC: Dave Hansen <dave.hansen@intel.com>, <linux-kernel@vger.kernel.org>,
	<x86@kernel.org>, <tglx@linutronix.de>, <bp@alien8.de>, <mingo@redhat.com>,
	<hpa@zytor.com>, <luto@kernel.org>, <peterz@infradead.org>,
	<thomas.lendacky@amd.com>, <chao.gao@intel.com>, <bhe@redhat.com>,
	<nik.borisov@suse.com>, <pbonzini@redhat.com>
References: <cover.1706698706.git.kai.huang@intel.com>
 <b52ed259e0d487b3a968b98da91cb4f55a28ae82.1706698706.git.kai.huang@intel.com>
 <12a927df-e437-40ff-ba4d-ceca5446c5b1@intel.com>
 <l3uo3n3li27czehll2wz34xxkcv5j2vcshgp5a6w7u4h4aidpu@4oe2cwye2e6z>
 <0c990c7d-4df9-45c1-8c03-980d9842b963@intel.com>
 <ixp6wj4763kc5vgpmipyrijddwnxblhdn2v7hio7ze756w5f2x@6uyc7hwtrbbn>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <ixp6wj4763kc5vgpmipyrijddwnxblhdn2v7hio7ze756w5f2x@6uyc7hwtrbbn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVrWUxRdG9nRFB3U2dId0duZGZvZ1V3RHl1YzUzdUZvVkdNV3g1RnNYSGxZ?=
 =?utf-8?B?TlBRN2Q1UlU1ZEdkcXVqSVJIQVhyamU2b2lJQlNSdUtlL2pyUFlkdFhFOXBS?=
 =?utf-8?B?bjJXQkRqNjYwSXVmOE9TcTlaSG81MXk1UjBzZkp5Yk5TT3NPZWZHSzRMWG9M?=
 =?utf-8?B?NVJWQWhLYmlkRjFTSS9KVFFUL1hQV0V5RjFqZDk2M2hjMkdOOE1PZGwwMXB6?=
 =?utf-8?B?d3NIMlRSUXhHMWU4R05OSm5GSnp1TkJYVnNFR3hrOE1xamtHWjd6TXhyeDg4?=
 =?utf-8?B?N3ltenU3SStyVWtiaVlidCtTeHM4c3FLSUZZcEdVRERoajlZTWp1aTNDY01T?=
 =?utf-8?B?VkFrdTRhU1djTjRZdmk0Mm9TbkhaQkNFVTBnQkxTM3piRlRTWDlEZU1uVS9P?=
 =?utf-8?B?Y3UxakhJTStoRFcrdCtlYWdqQjdxQ0lTNlJyeVlOdkFabERrRHY1bEdqZzFH?=
 =?utf-8?B?N0ZpcDJrbUMxRHVNUGhvaEJ5UU9qTWI4SmxxSHNsUkNvR2haZzZ6SDRpU1Yr?=
 =?utf-8?B?ME5DdUZJMW9aR2FyVHVFZlZmbFA5cG5vVVo2U1RMVEJuR1kvQThRa28zdDFO?=
 =?utf-8?B?YkV4UkxYK0VIUDhMY0RMdnM3cklUdVBDR1kwNHJpdklIR3ppSFU5RlkvTEZX?=
 =?utf-8?B?QnI5YXBUeS9sV21xVCszaUdyVUVNZjVMWmRIZ0xzTGJHY0VkSThZdVU0UzBT?=
 =?utf-8?B?MzhCVUgrZW1XOEtsc20wWVp2dm5ueHdvRS93RGZTWUJZa2pvR2k5cU1YZWs0?=
 =?utf-8?B?RWJjSjF3OXZ2K1hsZWluNWltSGtjWnNhR3F0T0NHakFYK0NGUTZCY2VKZUor?=
 =?utf-8?B?cUMySEZ2b1VDMDk1Wi9xQk9GZGpLSklncUNldmhhTGRuOEp5VUUxbTZ0M1pT?=
 =?utf-8?B?OU1DZ1hqQVJRNEVIbU11YWUxYXp2SHpLUXA5aWM4Y2pLallwWGpENkcreXMr?=
 =?utf-8?B?czFFRGtBa1lHU2pJdnh4NzR3YXdCa3dYbWZERWtKREZpdW5BTHh5bmtHOE9K?=
 =?utf-8?B?dGNPV2lFVkwya3JkSmVCYXA2QWFzSUNVTHhMNUw2R0ZpaXg5Q1RBbnNnTjB5?=
 =?utf-8?B?bnV2NWFvNFNiM29YS2p2L3BTSmc3YS9qbHZsVlhLYTJJaGJRQTJQWDJiRDhw?=
 =?utf-8?B?S2RncFZ4Z1dzWHNXKzVSdDFJZ0hoeWFVMnZZM0lsdUg5QkwxL0tvOGtXTWhY?=
 =?utf-8?B?QWc1WDNzWWk0UHNWbUl6SkxiR2VjWDU5MVl3d1p2MGJoN1h4Z29Ib1BPSHBv?=
 =?utf-8?B?ZnNpS0FqakZETFVBUHlDd0JrZ3B0YXBWbUtOWnlHT1NtdGExUFpxRUtHVnho?=
 =?utf-8?B?R1J2akFZOXlsZnFZcjZGRC8zdDlBL3VuTTlVRStCWEpjSVYweHN1YzdJaVpm?=
 =?utf-8?B?ZkpLb05Gd2xXUnVRczBrSzFrYXpGK2RaODVmK1drenpFNjFEek1UaHpsUHdM?=
 =?utf-8?B?K1ZtQUZrU3Z0RUtKUm05aXY0YVd2WnN6SUZvZkhYVzlzSFB2c2xyaFA3OHpy?=
 =?utf-8?B?R2xuVTU4QVBOL1dxMW5jZGplSDVJQmdYU3RPRXZsVSs1eDFWeFZCWDMrWXZu?=
 =?utf-8?B?YmdNTXhaRGV1Kzg5aWhWUkt1K3BmdzdMSlBrNmplVkJwYW1aSGpCU2JXTWFo?=
 =?utf-8?B?dlBYbEJ1ZHFtQUlyUkU1WUJ0R1FIZVV2cC9pOVRhc2NDZm5xUnU5ZTdvVWdo?=
 =?utf-8?B?dGFMcHNLS0VqTWN4SXJsb1U1Sk1wdStzU1k1YkhNMlNMV3BreEVSK284R2hW?=
 =?utf-8?B?NGJmZVVvMzAyQ0dLa1RpM2puU1dvKy80dkFqU0dYeGF6cndXVDRPbldaYmJC?=
 =?utf-8?B?Z2dBUDVxbXpmem9Zc2NCcnFkZnNvOEYvNmNBUVpFSmJBeklLY2EvYm5xN0tL?=
 =?utf-8?B?VllobXNibjR5MURWOWxsM200VStBM21yQ0FPYnVSUnNXeFBhQ2tNVzBYWnRX?=
 =?utf-8?B?VHkzdG5sQ1EvUDJRVGRydHdONStwQis5WEtLUnpMRitMQUJBaitHMHlwT3Bl?=
 =?utf-8?B?a0RNbHowNStJVElCZ3BWYlVZeXNxRDNvMnhXWlIwVjRHZVZGLzFrQlAwNWFk?=
 =?utf-8?B?azNUbmp6OGpkazNSWjQvbFlCeTV6Z25qenEwanhONTVGUVM3MlU4dU1PSDhI?=
 =?utf-8?Q?Fzwja2f8vwDLogQw0ADj2DUYO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e743b15b-042d-42c3-d42f-08dc2334c62c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 14:47:55.3737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYPiM/S8uSgYIXk8W67CXgYsGk9sk2/w/L0L3iyzCOJ950owy8e+kfzsn8SqIxFqxIgMfinpE1AHgYCUBDU6iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5607
X-OriginatorOrg: intel.com


On 1/02/2024 10:39 pm, Kirill A. Shutemov wrote:
> On Thu, Feb 01, 2024 at 10:22:18PM +0800, Huang, Kai wrote:
>>
>>
>> On 1/02/2024 6:03 am, Kirill A. Shutemov wrote:
>>> On Wed, Jan 31, 2024 at 01:21:39PM -0800, Dave Hansen wrote:
>>>>>    #ifdef CONFIG_KEXEC_JUMP
>>>>>    	if (image->preserve_context)
>>>>>    		save_processor_state();
>>>>> +	else
>>>>> +		tdx_reset_memory();
>>>>> +#else
>>>>> +	tdx_reset_memory();
>>>>>    #endif
>>>>
>>>> Wow, that's awfully hard to read.  I really wish folks' gag reflex would
>>>> kick in when they see stuff like this to get them to spend an additional
>>>> 15 seconds to turn this into:
>>>>
>>>> 	if (IS_ENABLED(CONFIG_KEXEC_JUMP) && image->preserve_context)
>>>> 		save_processor_state();
>>>> 	else
>>>> 		tdx_reset_memory();
>>>
>>> save_processor_state() is declared under CONFIG_PM_SLEEP, so I guess your
>>> variant might break build in some cases without updated suspend.h.
>>
>> I tried.  If I turn off both SUSPEND and HIBERNATION in the Kconfig I got
>> build error：
>>
>> arch/x86/kernel/machine_kexec_64.c:325:17: error: implicit declaration of
>> function ‘save_processor_state’ [-Werror=implicit-function-declaration]
>>    325 |                 save_processor_state();
>>        |                 ^~~~~~~~~~~~~~~~~~~~
> 
> Moving save_processor_state() declaration outside all defines would do the
> trick.
> 
> Something like the patch below.
> 
> But finding the right spot for the move can be tricky. I don't particular
> like where I moved it.
> 

I don't feel I have enough justification to do such change.

As I replied in another email, how about:

#ifdef CONFIG_KEXEC_JUMP
     if (image->preserve_context)
         save_processor_state();
     else
#endif
     tdx_reset_memory();

Not ideal, but looks slightly better?

But I'll leave to Dave to comment.