Received-SPF: pass (google.com: domain of linux-kernel+bounces-48337-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <894db19d-5287-4ed8-a0d9-0211b365eafa@acm.org>
Date: Thu, 1 Feb 2024 06:48:34 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] RDMA/srpt: Do not register event handler until srpt
 device is fully setup
Content-Language: en-US
To: William Kucharski <william.kucharski@oracle.com>,
 Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
 linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240131062438.869370-1-william.kucharski@oracle.com>
 <20240131062438.869370-2-william.kucharski@oracle.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240131062438.869370-2-william.kucharski@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 1/30/24 22:24, William Kucharski wrote:
> Upon rare occasions, KASAN reports a use-after-free Write
> in srpt_refresh_port().
> 
> This seems to be because an event handler is registered before the
> srpt device is fully setup and a race condition upon error may leave a
> partially setup event handler in place.
> 
> Instead, only register the event handler after srpt device initialization
> is complete.

A Fixes: tag is missing. Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>