Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp237088rdb; Thu, 1 Feb 2024 07:14:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUwc++y9wCqMq+w2iMKVYyHlheV5BwOR/J1/wccxEMlntWit+mthmoNC6tFLXG5BjSC5/j X-Received: by 2002:a50:9f07:0:b0:55f:31f7:4279 with SMTP id b7-20020a509f07000000b0055f31f74279mr3541523edf.12.1706800440630; Thu, 01 Feb 2024 07:14:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706800440; cv=pass; d=google.com; s=arc-20160816; b=W1MnezpTX8zFJC/9fpH9cFuD1dN5PvY/rqOiLeD9IHlG9w/WVQ8euCmpALvou7LZIh uYpvShvEOtWf5odlcuP+/R47kiVOF6UKOfScCn9UoMiaXmLHN73YsP54OrFHq5zt7b6V nzHLox3cdMmD7k99FKlIbmKgwC3VSOHs0ZZINf58RTaKEkNJVzIUZr5ucu0rM/4Rn50h drUYw4+3Cx/dr1AxaEJJkjhwMe6n1NQSDk8uJwu9qI/iAALD/n91PLxC15WRNgLpA/Bl +stOhdypcUc2+WcAyYypIlXXMkpI3kHueF29Yv0aQYwiO05wZl0VMqtMe8MRDQV+dXO/ dQrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=PW8LtK3eLbT+R6BUiYkc31jj/KAv643Uqyz0nvPLHqs=; fh=mvywvzqfNoMGrm2MJBYfYOBZV2sekxmlQLfPEsh+3Ok=; b=bakVg7XEgfbDujbxjHf3OdcjEcejS+Pdiv0pQY0vV3cWkFRVZ8ctehpKnoycdUYtt8 xjzyYpxnGRIC6MjPHmakR9/uoj7XzwJ5xn7HLRLmPliydnMtlyZ0SAZnt1Kjmd+qHXf1 qD1pcodnItCodOtmXMhJZbVIVNMxrEIv8fkldfObW+cMkt0IuMYx9jae6N2nHfn7oOQZ up73smMLdUqfX5vYuLiw0ciSN1BrSubFQmL6vzydaYc953NbJ1io4t+tWq1hdaBqT3FH w+9DPqrzikm7TsMcbUtrfV2uPwGKgwwv2F6QZaXyEGCZQzPahzbCtYUG7dHKZsvoTkI8 FIJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WwRdsEgn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48368-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCUIItMkU+pkjRc/h60Z/HifTWPwsd8C1WhVYlRRGgosjT/f9yNTvwjHWiNV+Rou7+vH8lOpW0zb+JUfIlA8sj+mnooqNyNHjtVXPjPUZw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g11-20020a50ee0b000000b0055ef9e79403si4307234eds.180.2024.02.01.07.14.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 07:14:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48368-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WwRdsEgn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48368-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2F66E1F28AA0 for ; Thu, 1 Feb 2024 15:14:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 134066215A; Thu, 1 Feb 2024 15:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WwRdsEgn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A43E5F49E; Thu, 1 Feb 2024 15:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706800430; cv=none; b=fFWik2sO5Ogu1H7jwMJKSNdUQu9p3/NFL68P0WfyREhIk1+tkmQV5G1y0tJwL16+N9z/HOUB8Ci7Ht/YuGTig/bHyqbhZGSWpX86Op0QdkAutWB6sshOkrBNwWCk5c5bIfiygQbXBSMRLVHQk9tot67msBDH+3bdfxKg2P514l4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706800430; c=relaxed/simple; bh=J25LSF02c3Gihi6ywJToP8/0dpuIX20uFfdRTlYxyRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Giya0wkA4NM5SBmK7pVoD+r/vzGsxxAsMEqCA0OV+241RwzkKQdtEsgwoLPYw9IK5kTdaugCAdatSqjr4odZWRMma9ajh4/t9q+5xHHoKAyM9mrtaHVDTer7UykelmbE2iHNTXPmlYgIe0We8F4nyxaP4Tq5COt1w21bW3yZUfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WwRdsEgn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F423DC433F1; Thu, 1 Feb 2024 15:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706800429; bh=J25LSF02c3Gihi6ywJToP8/0dpuIX20uFfdRTlYxyRg=; h=From:To:Cc:Subject:Date:From; b=WwRdsEgnfVREwIGEX7L2Y0qvFc4a+QOfttbXdf6t8ZoZNJqEAF6ntKisAF9lamz/c CKCOXaJCB1NwUOAuFSWq5OWNXl4pXVdZJnYhNcZuW8JGTQ8u0Z4Sosso2c5GgnCgPB 7dR5pfRAW6HrAqvmWuJCBnh6Y5X0kIVJ/KhHUPFuPT9K03GqVRjJtfGP6m6hNgbZP2 X3Sn7bLvYa98cxeGVu0bS+gecxyjnBFLZlorUBZQDP2GS/v+EMk8hjl0Evn3X1dB5N EIKY1bGR+sRwskTDZMEvuuAvwRImAxta9NDT3WI6wbIW8tPUXCNpYlze1Q51t/tRyl 8tmRRAUrucKXg== From: Daniel Bristot de Oliveira To: Steven Rostedt Cc: Daniel Bristot de Oliveira , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open() Date: Thu, 1 Feb 2024 16:13:39 +0100 Message-ID: <7324dd3fc0035658c99b825204a66049389c56e3.1706798888.git.bristot@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the timerlat's hrtimer is initialized at the first read of timerlat_fd, and destroyed at close(). It works, but it causes an error if the user program open() and close() the file without reading. Move hrtimer_init to timerlat_fd open() to avoid this problem. No functional changes. Fixes: e88ed227f639 ("tracing/timerlat: Add user-space interface") Signed-off-by: Daniel Bristot de Oliveira --- kernel/trace/trace_osnoise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index bd0d01d00fb9..a8e28f9b9271 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -2444,6 +2444,9 @@ static int timerlat_fd_open(struct inode *inode, struct file *file) tlat = this_cpu_tmr_var(); tlat->count = 0; + hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD); + tlat->timer.function = timerlat_irq; + migrate_enable(); return 0; }; @@ -2526,9 +2529,6 @@ timerlat_fd_read(struct file *file, char __user *ubuf, size_t count, tlat->tracing_thread = false; tlat->kthread = current; - hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD); - tlat->timer.function = timerlat_irq; - /* Annotate now to drift new period */ tlat->abs_period = hrtimer_cb_get_time(&tlat->timer); -- 2.43.0