Received-SPF: pass (google.com: domain of linux-kernel+bounces-48429-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <dbcff3a5-8b02-4cc0-9d8e-1116ff7a3ffd@intel.com>
Date: Thu, 1 Feb 2024 23:44:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] x86/cpu: allow reducing x86_phys_bits during
 early_identify_cpu()
Content-Language: en-US
To: Paolo Bonzini <pbonzini@redhat.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>
CC: Zixi Chen <zixchen@redhat.com>, Adam Dunlap <acdunlap@google.com>, "Kirill
 A . Shutemov" <kirill.shutemov@linux.intel.com>, Xiaoyao Li
	<xiaoyao.li@intel.com>, Dave Hansen <dave.hansen@linux.intel.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
	<x86@kernel.org>, <stable@vger.kernel.org>
References: <20240131230902.1867092-1-pbonzini@redhat.com>
 <20240131230902.1867092-2-pbonzini@redhat.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240131230902.1867092-2-pbonzini@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkEzMGtyRFZVcWZrMG9QeWg1bnBrRUxkRzBwYjFBK2VHemlmOUdsVHQrRHNj?=
 =?utf-8?B?UGt6Y0tGYnhkQlpkMVY2L29pTzJNYlpOWmkvdHFpZUhuUWpvTTdHV20wMlpw?=
 =?utf-8?B?MEJFcG1VKzVVVmtvN05OQnp2UVFMNTRzb2kwbEY4T2hzV043SlF0ZExQbVU4?=
 =?utf-8?B?S2pKaHV2Sml5RndTa054TE5GN1ovOHFtMFlGOVptQTh1am1UZ0NPZXFnSDRK?=
 =?utf-8?B?aWZMZjJxM1VxdkpzYVFpSUxQSHFzZTVSMVJpQkFoYWYzM1oxSEdTb0swZUhE?=
 =?utf-8?B?NHN3QTUzY1cySDVUZHFjMUdSa3NrLzh5K3RFYkEvRk83WUhmNkEvZC9zZUJK?=
 =?utf-8?B?aStDN0dndDJ0Zjh4dldlY0tZb3RiNHRTdkt4Z1JVcEcrUEpKNk9oeStLMU15?=
 =?utf-8?B?OTlVeXFMSjdITnNTTGNMVzZCVG9INUV0WnkwVWM4cHp6NnJCVXhMUnY4cjJn?=
 =?utf-8?B?ditKUVJkL25QMCt0NllSckViSkVYVWJEMUVQOTM1cWFpT0pJT1E3R2p5OTlv?=
 =?utf-8?B?L0pnbEJUaEtPaW5YRDNiWG1sc1cxZGlCMkxIQVAwa050WXVlNlBwUDVaN2RN?=
 =?utf-8?B?b09VMFNNVmdLRWxCTGQ2Ui9LQ096V0pvQlpFaGNJU0ZTem9BQmJmWkRhM3RZ?=
 =?utf-8?B?cDRUL3F0NWZicU1Ga3piTkU3RElJb1JtbnNNR1A0aVZ4R1dJajhwTGVhWmYv?=
 =?utf-8?B?MWQxUU5ML2NxMW5YeTNmdENnOGxydjRndEhnOUkrQ2N5UmRLbUhRdjB0NjBN?=
 =?utf-8?B?ZS9oMm1WSjlVNXpQYXRWWWw5anJCaThqOSttcXRFY0dPUlJadjZtRTJ5MHoy?=
 =?utf-8?B?elViQklTMTdyUmZsNGdnQ1BtVFZwZzJmRXRBd2dKK3JnSkNhclZPMW5TTkFC?=
 =?utf-8?B?RGVtalVPcFNVRFYyWERMbndWK2FzeWJ3OHN3RENRT3BCN3QxRDFEaVlDWGdn?=
 =?utf-8?B?NW9CWVBidXhxK3hBdnNualZyQWRnbmtlajR2NXU2N3JNcnE3VFVFTUIvT1cx?=
 =?utf-8?B?bkFjUWJTaUM5MXV4aTRKTWNCWVpWeEFIV25vUzJPaGUyREFnV1daaEM1aGNK?=
 =?utf-8?B?M2V6bFNvbm9wSU5WZ0d1am9GODREdGpVelJjNWNJTUhNZFJCdzdJQ0kyU3F2?=
 =?utf-8?B?anhhNC9xUlJDcHd6aWVjdjY5cWhkaFRTcEFZaVF4YWQrVjhvSFYwdnp5bmYw?=
 =?utf-8?B?K3YwaWp0SDlybmpUd3ordEJPQTdIL0RnQkJOZnRTUGpXbFZBSnlTd2drTlNi?=
 =?utf-8?B?THd5THU5czZwZllEUjB0b1V5akFHek10MU5rdVhFSEw1Y3g2VmRXdHJlRUw0?=
 =?utf-8?B?OW9OeVFKQmVaRUdKZ2tIK3JjR0plZ05aOGxQMGZnS2U2UE91MmwvUkF2Zm1O?=
 =?utf-8?B?ZGx0YXFRL2NMMXQ5RWJJaVM5VzlGZ2RiTjh3ZlpYSkZOY3VlN0RGMFc5UUF6?=
 =?utf-8?B?dkFMSGprZTZYM210ajJwbFFTd0dZbmdnMDYyMU9TUWsyZVdUTWpPbUliSjRZ?=
 =?utf-8?B?SUo5NHRoZS8yVjhnRmxEN3Y4amdWK3VuZlZ3b2JQbzFjckxHR0Q5aHVjNkNN?=
 =?utf-8?B?R3NxYkk1b3NqZDhjTm1ZTlBVQ1dNbkxQYnd4d0tGL1BYUTJrTGc0TllKOFJH?=
 =?utf-8?B?QStTMDNnbHpDeFh5VmlSVkNyTStVOW1pb0pzc0dLTmFqU0xMWk1IMHpqbXBL?=
 =?utf-8?B?NVdjMGp0UkhsK0RPUVV1UitGdU4zVUhHaFlTc2g0ekVmZVJLQTFEVEFVOVFu?=
 =?utf-8?B?MEswTUhYNUlvMytTVUVwVFpFc0R0Q1VBN1ZQbHZBRWlvY1JtaHNmcm5JQkpt?=
 =?utf-8?B?SGNhR3Z1eWdzTDJqTHFOc2pyN2x5cGVKWEdFU0F0UXgvL2lXcndjb3M2YUY5?=
 =?utf-8?B?dTZXR0lEclVwOEI1WUZGbzRjUjUwU3E5UjdlOU9WVXFxWlJNTk5CQnRSYXhi?=
 =?utf-8?B?OXlTRUNWTWFQUDg3S0EzbVRXYlhaK01hcUZKN21JaDR3RTFpRmNFdFhqT0Jn?=
 =?utf-8?B?TXNndFUvVzJiazBUN1VsVHBuQTZLcmVuQmRPVkpkZ08zVk11M0tyWkpDQzVE?=
 =?utf-8?B?Q0s2TG41VGZWdEdhcDZqMXUvSURlMk10UzJ1ZHliS3dFWkJtc25rV2NmUzZB?=
 =?utf-8?Q?BPI5Navex9PerVdxN1wixqjxd?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2fd41f-7f09-4fe1-da3f-08dc233cb2ed
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 15:44:38.9971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g0iAy71+2B9c0dJKwoe7NJwzlrGW2XKetT4TPSlFA1Yp278Od8UUopY249QTIDo63k0YXAOfZ/c1w510jpKpPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6363
X-OriginatorOrg: intel.com


On 1/02/2024 7:09 am, Paolo Bonzini wrote:
> In commit fbf6449f84bf ("x86/sev-es: Set x86_virt_bits to the correct
> value straight away, instead of a two-phase approach"), the initialization
> of c->x86_phys_bits was moved after this_cpu->c_early_init(c).  This is
> incorrect because early_init_amd() expected to be able to reduce the
> value according to the contents of CPUID leaf 0x8000001f.
> 
> Fortunately, the bug was negated by init_amd()'s call to early_init_amd(),
> which does reduce x86_phys_bits in the end.  However, this is very
> late in the boot process and, most notably, the wrong value is used for
> x86_phys_bits when setting up MTRRs.
> 
> To fix this, call get_cpu_address_sizes() as soon as X86_FEATURE_CPUID is
> set/cleared, and c->extended_cpuid_level is retrieved.
> 
> Fixes: fbf6449f84bf ("x86/sev-es: Set x86_virt_bits to the correct value straight away, instead of a two-phase approach")
> Cc: Adam Dunlap <acdunlap@google.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Xiaoyao Li <xiaoyao.li@intel.com>
> Cc: Kai Huang <kai.huang@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: x86@kernel.org
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Acked-by: Kai Huang <kai.huang@intel.com>