Received-SPF: pass (google.com: domain of linux-kernel+bounces-48436-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 01 Feb 2024 15:48:00 +0000
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
From: Emil Kronborg <emil.kronborg@protonmail.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] serial: core: introduce uart_port_tx_flags()
Message-ID: <eduudp2uvoer2haaixxhh7vntvir2qtm62nceykxn6jcfaepno@ws2iiisuxq7o>
In-Reply-To: <20240201105557.28043-1-jirislaby@kernel.org>
References: <20240201105557.28043-1-jirislaby@kernel.org>
Feedback-ID: 20949900:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 01, 2024 at 11:55 +0100, Jiri Slaby (SUSE) wrote:
> And an enum with a flag: UART_TX_NOSTOP. To NOT call
> __port->ops->stop_tx() when the circular buffer is empty. mxs-uart needs
> this (see the next patch).
>=20
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Emil Kronborg <emil.kronborg@protonmail.com>
> ---
>=20
> Notes:
>     [v2] fix/invert the condition
>=20
>  include/linux/serial_core.h | 32 +++++++++++++++++++++++++++-----
>  1 file changed, 27 insertions(+), 5 deletions(-)
>=20
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 536b2581d3e2..55b1f3ba48ac 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -748,8 +748,17 @@ struct uart_driver {
>=20
>  void uart_write_wakeup(struct uart_port *port);
>=20
> -#define __uart_port_tx(uport, ch, tx_ready, put_char, tx_done, for_test,=
      \
> -=09=09for_post)=09=09=09=09=09=09      \
> +/**
> + * enum UART_TX_FLAGS -- flags for uart_port_tx_flags()
> + *
> + * @UART_TX_NOSTOP: don't call port->ops->stop_tx() on empty buffer
> + */
> +enum UART_TX_FLAGS {
> +=09UART_TX_NOSTOP =3D BIT(0),
> +};
> +
> +#define __uart_port_tx(uport, ch, flags, tx_ready, put_char, tx_done,=09=
      \
> +=09=09       for_test, for_post)=09=09=09=09      \
>  ({=09=09=09=09=09=09=09=09=09      \
>  =09struct uart_port *__port =3D (uport);=09=09=09=09      \
>  =09struct circ_buf *xmit =3D &__port->state->xmit;=09=09=09      \
> @@ -777,7 +786,7 @@ void uart_write_wakeup(struct uart_port *port);
>  =09if (pending < WAKEUP_CHARS) {=09=09=09=09=09      \
>  =09=09uart_write_wakeup(__port);=09=09=09=09      \
>  =09=09=09=09=09=09=09=09=09      \
> -=09=09if (pending =3D=3D 0)=09=09=09=09=09      \
> +=09=09if (!((flags) & UART_TX_NOSTOP) && pending =3D=3D 0)=09      \
>  =09=09=09__port->ops->stop_tx(__port);=09=09=09      \
>  =09}=09=09=09=09=09=09=09=09      \
>  =09=09=09=09=09=09=09=09=09      \
> @@ -812,7 +821,7 @@ void uart_write_wakeup(struct uart_port *port);
>   */
>  #define uart_port_tx_limited(port, ch, count, tx_ready, put_char, tx_don=
e) ({ \
>  =09unsigned int __count =3D (count);=09=09=09=09=09      \
> -=09__uart_port_tx(port, ch, tx_ready, put_char, tx_done, __count,=09    =
  \
> +=09__uart_port_tx(port, ch, 0, tx_ready, put_char, tx_done, __count,    =
 \
>  =09=09=09__count--);=09=09=09=09=09      \
>  })
>=20
> @@ -826,8 +835,21 @@ void uart_write_wakeup(struct uart_port *port);
>   * See uart_port_tx_limited() for more details.
>   */
>  #define uart_port_tx(port, ch, tx_ready, put_char)=09=09=09\
> -=09__uart_port_tx(port, ch, tx_ready, put_char, ({}), true, ({}))
> +=09__uart_port_tx(port, ch, 0, tx_ready, put_char, ({}), true, ({}))
> +
>=20
> +/**
> + * uart_port_tx_flags -- transmit helper for uart_port with flags
> + * @port: uart port
> + * @ch: variable to store a character to be written to the HW
> + * @flags: %UART_TX_NOSTOP or similar
> + * @tx_ready: can HW accept more data function
> + * @put_char: function to write a character
> + *
> + * See uart_port_tx_limited() for more details.
> + */
> +#define uart_port_tx_flags(port, ch, flags, tx_ready, put_char)=09=09\
> +=09__uart_port_tx(port, ch, flags, tx_ready, put_char, ({}), true, ({}))
>  /*
>   * Baud rate helpers.
>   */
> --
> 2.43.0
>=20

Tested on i.MX28 board.

Tested-by: Emil Kronborg <emil.kronborg@protonmail.com>

--=20
Emil Kronborg