Received-SPF: pass (google.com: domain of linux-kernel+bounces-48509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e51824ae-ac3b-49d6-ab2d-add4c91c2c76@intel.com>
Date: Thu, 1 Feb 2024 09:16:49 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH 2/2] cxl/trace: Remove unnecessary memcpy's
To: Ira Weiny <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>
CC: Davidlohr Bueso <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-cxl@vger.kernel.org>
References: <20240131-cxl-cper-fixups-v1-0-335c85b1d77b@intel.com>
 <20240131-cxl-cper-fixups-v1-2-335c85b1d77b@intel.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240131-cxl-cper-fixups-v1-2-335c85b1d77b@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1JYODJ2RXhBYnY1ZHZHbmUrSEdaQzJGYVFaUVNFa3Rua2V0eWo5a2dPWEts?=
 =?utf-8?B?dkRSbW4wNTdVRVdjUm53cmd0SVFua0lYOUpzVXJ6aENjTDVXamdPdm4yMm1G?=
 =?utf-8?B?cGhMMFFRdlcvNCtGNDl1ekJWZ3dibGV6RVZ2c1J4dUJEcjBnRUFSb2E0RE5O?=
 =?utf-8?B?bE4rbkgwNHlqWXVlZDFyUkh0UjQ5Q053UzZOMTZCSktSTmVRWjI0UkNid3BB?=
 =?utf-8?B?VCtHV1lBb3lBSlRuL3BEeVpEQlN5cFBtc3FGMkM5a0FaZ0ZuSWxCY05nV2Jh?=
 =?utf-8?B?VVI4MS9iWFFvUERMbGJxTG5PRW1nbFgxcjczQitkbU1yWTQ5RmNMYlkvR1FM?=
 =?utf-8?B?TnAvQ0QwYXdrMEs2NDdxN3dWclJjRVR3aVdjZGlXbFRLNVJIaGNua3I4NWVy?=
 =?utf-8?B?KzZneS96TEM3VDZxb3MzREZ0a0QraHRxdVFydjFFZmQrakttckJtMGZBQlhO?=
 =?utf-8?B?MXRwem5EdzFLbDFRNXpaWU9yTTNtNTlRRHcwa2N4OTJuNmhzeThxOStEVE5W?=
 =?utf-8?B?RlRwck1xV0ZUd05iS3RhRk1UTklxQ3JOQzNtMWl1TjBFZk91WmROS0VkcjZn?=
 =?utf-8?B?bHF3ZndMNG45RlpQZkUyQjEyQXZIUjRGa3kzOGQ0SEY2UU5naG9rTWFBN0ZR?=
 =?utf-8?B?djNBSGhVUnZmMkJCMmdjRHYrMjJhQ0VIRCt1cVZFeURvVGtNcWdzaGhJS3ZC?=
 =?utf-8?B?cWMyaWN0RGhSZ0VCWVh4US9NaUl3N2dWMjhzTk8yWFA2cytUTmk1Y1RMZnY4?=
 =?utf-8?B?RnNOTXF6YXE3UWlKWUtFVStSOUVlTnlYeUFQL2ZVQ1NBNzFpTUlEZlppdk5Y?=
 =?utf-8?B?QnllblFxSFJ3YXl4R2JDZ1FTL0R5ZWtQZVI3V0xycXdTTXFkRlFvZTRXN2lP?=
 =?utf-8?B?cHR4Z3FCQzRqNkxLNUxBd2l3d3hweEZQQXdxbGo4U0FXM2dwY1p4QzVGcWZz?=
 =?utf-8?B?Vng5NS9vNEk0QTJ4Qkh0QWVZRXlGc0xybFNESXJQbXdrUWcxVjNRaFFCbTNq?=
 =?utf-8?B?WU5OREVrTzB2MGxud3lDQzZJcUI4OUFQUE1mcFd1VXNua0JGQVFycW1ZWVNM?=
 =?utf-8?B?VW9JbTh1eU9WMnFYcTlZRjlzZTV1ejNFTDBoZjIxd29uV3NHdExnYjVFdEly?=
 =?utf-8?B?ODFRSUIwNW1GdG9UTVJTUy91cEEwMWhzbU1IQkQ4MWkrQ0NnOVFyaWRQZmpK?=
 =?utf-8?B?ZWo0RGtvUm5JVWxOOWdJbHpWODNjdnZXWW9vV0k1UXE1NEYyTEVNU2RpUEx6?=
 =?utf-8?B?TmNrMzBpWG43TDg4WjVoRkxiMCtlWWI1WkQ2Q2dmL3JDaTFDcTV0eFFHTTRF?=
 =?utf-8?B?WmFBMVBNNW85alFqZkFEZXpsc2MzOGJZbXZ6VjArWGRXaDBKaVprRGlJWjU2?=
 =?utf-8?B?RmFkRmVpTXFVT2pZdG5OWURmWG9LZlZrYUoxc0VaY0twejhMYXBUbkxGd0VI?=
 =?utf-8?B?YXFNU24vT1dlc082YW55WUc4M3c1MmVVcHA1SUJqOUJhZ2pEdWlwQVlHd1h0?=
 =?utf-8?B?QnlhWkE5Vm5oT2duMG9LaytGbDBRMVRrc1g2Ylh2QXM3MUx2WmtxME5palQ0?=
 =?utf-8?B?YzNnL2RzeFozWjEwR0VmZFpuVGhUNno3Y2FUYnFXaTdlU1RFMVhRMFFGanRK?=
 =?utf-8?B?VklZdVRkYmwzdmF6dXJkOUlmcW9mWWp4dlZ1UnByOS81NXgwQUp5YTNHcWJx?=
 =?utf-8?B?MnoxQUJ5U3FBbitmYTJoaE1jVWdDOEF0QXJMNjBRZ1h3ck1mQ1VYOEtOWTVm?=
 =?utf-8?B?YmM3QnBCZmYxRCswRDYvV2pCSEljbG5HZGZORXF1NXF1eHhNZjNVL0sxSGtW?=
 =?utf-8?B?bFc1L1BsM3o4b21pZ2JTVlpZRElObnZVMktBSkZHNkdRRkg1VUtDQXJkTU1h?=
 =?utf-8?B?TUF6bUxjdXBOYW9jNG9hOVBjZ1JTb1owWEdjaUszUjUvNURCSmdQRmlvOUdX?=
 =?utf-8?B?ZTFPVEpJUG12dzk0U2tUNndIM0VQL21tVTQ2TSs4bWpHUW1tam9DbjdKME1s?=
 =?utf-8?B?NGc4MjViZ3pjd2tzYnZBOUVab2FxSHhDKzdwRHBNY2dmWDExbUhVNmdDQXpt?=
 =?utf-8?B?Sm9Cd3J2L282S3FYY1laTS9SaHBDUDBtU2tzV2hEcXNreDhNalZQWjZJWGZs?=
 =?utf-8?Q?tyFMFDNLB/IEosy8VxIdOsLhJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 178403f1-1704-40e5-3589-08dc23413308
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 16:16:51.8339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SYbCTd/sK8Tlvq/NMZIX/dotAKhXrvMvmgYCwnjwzv9Cnn6clzc6stbokvZDh/6idAF5wTiEINbSBJuafM9jOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7718
X-OriginatorOrg: intel.com


On 1/31/24 16:55, Ira Weiny wrote:
> CPER events don't have UUIDs.  Therefore UUIDs were removed from the
> records passed to trace events and replaced with hard coded values.
> 
> As pointed out by Jonathan, the new defines for the UUIDs present a more
> efficient way to assign UUID in trace records.[1]
> 
> Replace memcpy's with the use of static data.
> 
> [1] https://lore.kernel.org/all/20240108132325.00000e9c@Huawei.com/
> 
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/trace.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> index 89445435303a..bdf117a33744 100644
> --- a/drivers/cxl/core/trace.h
> +++ b/drivers/cxl/core/trace.h
> @@ -338,7 +338,7 @@ TRACE_EVENT(cxl_general_media,
>  
>  	TP_fast_assign(
>  		CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
> -		memcpy(&__entry->hdr_uuid, &CXL_EVENT_GEN_MEDIA_UUID, sizeof(uuid_t));
> +		__entry->hdr_uuid = CXL_EVENT_GEN_MEDIA_UUID;
>  
>  		/* General Media */
>  		__entry->dpa = le64_to_cpu(rec->phys_addr);
> @@ -425,7 +425,7 @@ TRACE_EVENT(cxl_dram,
>  
>  	TP_fast_assign(
>  		CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
> -		memcpy(&__entry->hdr_uuid, &CXL_EVENT_DRAM_UUID, sizeof(uuid_t));
> +		__entry->hdr_uuid = CXL_EVENT_DRAM_UUID;
>  
>  		/* DRAM */
>  		__entry->dpa = le64_to_cpu(rec->phys_addr);
> @@ -573,7 +573,7 @@ TRACE_EVENT(cxl_memory_module,
>  
>  	TP_fast_assign(
>  		CXL_EVT_TP_fast_assign(cxlmd, log, rec->hdr);
> -		memcpy(&__entry->hdr_uuid, &CXL_EVENT_MEM_MODULE_UUID, sizeof(uuid_t));
> +		__entry->hdr_uuid = CXL_EVENT_MEM_MODULE_UUID;
>  
>  		/* Memory Module Event */
>  		__entry->event_type = rec->event_type;
>