Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp294357rdb; Thu, 1 Feb 2024 08:40:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFnfaedYIiMoI7ClbdgiLePsh4CdoQ743mdXGL3Q5j7rCp0zxX3rZi1by+g5xuzzsduNCsh X-Received: by 2002:aa7:c895:0:b0:55e:f33c:ea4b with SMTP id p21-20020aa7c895000000b0055ef33cea4bmr1648233eds.40.1706805656468; Thu, 01 Feb 2024 08:40:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706805656; cv=pass; d=google.com; s=arc-20160816; b=nrX0n5dr2lz2VaPNWv2LVzraudNt+fAgP6/Us/8fL75SUb6Nzgki2RRp+JFZ7CmBcD GMxyIan3fB/MAfVhvSlgAOx4JNeTCnKJjcmyX4OVZ+pLYvnkoPhdfUs9nT0R7gWhfvTv HUBav4EOq4+Ljaw/HkfA3t81HkVMtvhReVWfGYBbL9ksW8jna16fp+lIP9zUXksaZ73g HQZsQRoxUhA7ZOOaWei6Ndf0BOcdT+pazFjhVwx1Fsc+DY97ntxoxSq+PN8sKKSRlerE 0UDh8qp9bGWxmr64q83GmGHW6nrHCj3th//V1x1mKoJ1RI1b0MkbrPZ0NQenhsiI2nA/ XkIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Ms3yjmWr7uVaxx1x/3FteKOmdGsnLgEUuBEufd5GKp8=; fh=aYPI7SpauJEJRoWOgAbtBgO0ipIg+KzzaQF5ywCF0DM=; b=AId2wq3GRPlnCuDu5OE1D3jBEh1UTWPk30S76YT8FzOE/nyqsnTzMbNOV7gMqBgdHP 7LZDofA2CtJnzEedzt4ksIbzXjyZbkq+eXN9QSKFrlngGG+jQvVl8rrj+6P2bW8ig9R4 JoK0Fn/A3/kR6sY5h+2eMxW1uAY0JcoLJgWyttqHVzmJvsMazGr7AxXWV5ojBiFldW3V 7u7WlbvPcPmZpc9kgKXMuzD81+yXXLUYb7+Xs1wHnbLBD50lp6b2IcW/Owm283IwUbPG whSWgJfSWGCeL7RrndKsUrugzXeYe5fW3HYFEfvdiFw+5YwfLLDi0QGnpiF6sfxEVJO/ 4LOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=legpP2Iy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48542-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVPgbRM164t6d24LtRf0ZN+AaQGRekoF0FRX+A7mg9OobOzKuebiXD2EntojpFiNkj6FXbtGGcofbGXf4OL0V3VicBpARy9OP+dykIGSQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m20-20020a056402431400b0055fcedf39ffsi307503edc.357.2024.02.01.08.40.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 08:40:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=legpP2Iy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48542-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 382041F226BF for ; Thu, 1 Feb 2024 16:40:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DFF17E0FD; Thu, 1 Feb 2024 16:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="legpP2Iy" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E855220; Thu, 1 Feb 2024 16:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706805627; cv=none; b=Mn3baYHBvsQCbPsSFzQ6/hu2l0Z6O+RtCfIIb6OCv8KNkW35Bv0eN2LrUKiAmooWQr1wc9v5/xDSPlNl3L163COXX1dKdXITkI8U3coH0nHdTmdWFNJyaNGrFDeLRpSQDvUsVIEQMR3iHAVybyk0aD/eHUaNpZ9aYb65meHhc5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706805627; c=relaxed/simple; bh=cEeiNYKArm+VYNgUm6O2A02TGK3a297C60jApYVOn98=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=Kstfxy1wkE4wktLTvtPk9KNwUeSZkd+aNfaCe7N0KDcyjsHgDu4ix7uu7Wsk4ijqnk43yW/9Hg6H8RL57yO+qLpY7TZ01j5d+kDAkwGSvlV7KSN1LuFBiaROFXjpmN9RKJkzVxRH/WQgKAdZpVgdjDLn7eV5+3lOZaKDEkensik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=legpP2Iy; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id E5EA0C43394; Thu, 1 Feb 2024 16:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706805627; bh=cEeiNYKArm+VYNgUm6O2A02TGK3a297C60jApYVOn98=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=legpP2Iyco/ENQwWpCazE2ZQ7lro7yMbH+fUnmbTsUZ93ltNeCemnU/i2OAR8ktO1 z6Tal1lytqo0gU8XTTfEsQ3gynyVQ8hp42TWd+js388O5xMIndV2+3fnB7nK3RqOdL JfMTP02HqekWuLtUshOiJmkO+FqcUzulC5CmbrUFC/AnTxQE+k3UogvpMsz8RXRmJ/ XwAfRzK2jkrx3IpuaEyMAjhvabz2oKjBGUvGr+dVA2h24Dilw+VuMr3VcMSmQ/RprM EML0Ef6fhbcOyAo25B36NcTO4SKr688xvJG/YrvCNgJeBG/g6oAqP0nHNmVcwlB8Uf k+hA+LwKiq+CQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id CC251D8C9A3; Thu, 1 Feb 2024 16:40:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH V2 net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170680562683.32005.9726914174097287156.git-patchwork-notify@kernel.org> Date: Thu, 01 Feb 2024 16:40:26 +0000 References: <1706686551-28510-1-git-send-email-schakrabarti@linux.microsoft.com> In-Reply-To: <1706686551-28510-1-git-send-email-schakrabarti@linux.microsoft.com> To: Souradeep Chakrabarti Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com, yury.norov@gmail.com, leon@kernel.org, cai.huoqing@linux.dev, ssengar@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, schakrabarti@microsoft.com, stable@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 30 Jan 2024 23:35:51 -0800 you wrote: > In commit ac5047671758 ("hv_netvsc: Disable NAPI before closing the > VMBus channel"), napi_disable was getting called for all channels, > including all subchannels without confirming if they are enabled or not. > > This caused hv_netvsc getting hung at napi_disable, when netvsc_probe() > has finished running but nvdev->subchan_work has not started yet. > netvsc_subchan_work() -> rndis_set_subchannel() has not created the > sub-channels and because of that netvsc_sc_open() is not running. > netvsc_remove() calls cancel_work_sync(&nvdev->subchan_work), for which > netvsc_subchan_work did not run. > > [...] Here is the summary with links: - [V2,net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove https://git.kernel.org/netdev/net/c/e0526ec5360a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html