Received-SPF: pass (google.com: domain of linux-kernel+bounces-48534-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <520f3ba5-3f72-4312-9841-0563aa721255@amd.com>
Date: Thu, 1 Feb 2024 22:02:21 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add
 wol-arp-packet property
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
Cc: krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com,
 claudiu.beznea@tuxon.dev, davem@davemloft.net, edumazet@google.com,
 kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, conor+dt@kernel.org,
 linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240130104845.3995341-1-vineeth.karumanchi@amd.com>
 <20240130104845.3995341-3-vineeth.karumanchi@amd.com>
 <824aad4d-6b05-4641-b75d-ceaa08b0a4e8@lunn.ch>
 <09ce2e81-01cc-431f-8acb-076a54e5a7e6@amd.com>
 <9b4a2c23-5a96-45eb-9bdf-cefc99f25fec@lunn.ch>
 <7a063832-e1b5-42df-92cf-66486d4feecb@amd.com>
 <fb8f56b1-c961-478d-ac3a-8136408771d3@lunn.ch>
From: "Karumanchi, Vineeth" <vineeth.karumanchi@amd.com>
In-Reply-To: <fb8f56b1-c961-478d-ac3a-8136408771d3@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d3pvK2dTQTdJSU9YVTFlcXlscHgzaE5sclR5QVNOTWxhclpSUXZ5UFRlaitw?=
 =?utf-8?B?WnJiaUU5dXRIUlg4OVozVDVnVHg5d2w0MnpKR2JGZGFQRkt4L2tmNXR0T0J5?=
 =?utf-8?B?SmhMT00vb0w1S1IyMHB4NCtDbzN3QTlyUXF4cUladVdGdGhsT1JuSnlDa3RR?=
 =?utf-8?B?RFRZbG1uejVrSkJPUmFXbkxzVEpzVnhvWjhESURjZ1FJcmJuWDl1b1lVZ2hC?=
 =?utf-8?B?TndVRDN5bDBMOWc3dXVHZS9lVExxajhBUnBwNmlQbHNCRVYrWWdyQVBHQlJK?=
 =?utf-8?B?UXNXWlVjNzhuY2wxRnRwdWlSN1ZqbHdiYkNyR2pjNW9TTFNrNDI4eDZhMExh?=
 =?utf-8?B?YXFxWTRPL3ZBTXErcDE1eDhjUEthb0JENHI2VzRpcjlCL0drTTNscVdwU2hh?=
 =?utf-8?B?WTRSOGEySGZMUXRuNXZRYWxYRGdtMVFwbm1ROUZ1Tm9qWGViVk4yVE5EcnJj?=
 =?utf-8?B?cjNxeCtLVnZOYUFtSzJsenpGY08yVzloNFZ3b3Zrc1YvVGdwNDExT1pSUWVx?=
 =?utf-8?B?eDVyVzdoZm9POHlCSGRTejM3R2xxN3l6TXlJc1FPS3ExRzhSZEk5ZExjQXg0?=
 =?utf-8?B?RlJmQ1R6YVpPbGthYjlDaVdLMG1pOHlEeTk0RTBsOUxRNU5WOXpYdVRTMEhV?=
 =?utf-8?B?MXBUVWNyZVZaUWdxQkQwRFkxQmJYMDZPL0VYWEd5RG1TSFNuN3JrS2pOWjR3?=
 =?utf-8?B?N3M2NENJNnVkdDU3UXZVVUJVcnYzS0txdWhpekZUUVFtRXVGWEhvdENMY1BC?=
 =?utf-8?B?VktYV0ZDNkVTTGdOTVB6OG1WWVFGWTJiU1U5Y083d2czc0toOHBWZnNGOC9j?=
 =?utf-8?B?WWtZcXBoOXhBdkFidmkvSG11TlpTc25HajFRNlV1Q0hYVjErZnJQcXEvQ3hi?=
 =?utf-8?B?bW10YU5kN2tGTFNIbWVjNFl3UXlmeDcvVEhZSjIrWHpxR2xpUyttcVJhb1pW?=
 =?utf-8?B?SSt6ZEFpSHRubFp4c3Ztb1NXUzhCYk9sOEY4UWt3Umhpc0JiM3ZDNHVBQytE?=
 =?utf-8?B?bE5jRmhnWVZ4YmNxU2prMWQ1c1ZVeGh3SlpVVnlGWG9FSTBrTmM4aHVvdFdM?=
 =?utf-8?B?VzZQanpNLzVzWkk3M1hwdDNjZW9DSFVubmo5aVpWNWRHdmJJVk1JaE05ZXdm?=
 =?utf-8?B?NmwyVnRYZ3FBN1BNY0loOExGTHJtVUd6Q3JYTlZJU1dxQVFHRExTWVdhZ3Nv?=
 =?utf-8?B?dGovT3drc2F3R3M2bFVLNWhibjZubWhCUzExbkc0cU4vYm1yc3lYMzRMQzlK?=
 =?utf-8?B?SmVhcXZ2dkpRd3Q1R1dLUzJ4eE5hWmovNlJHQjVCUUw1cy8ya21aWWRUSWtL?=
 =?utf-8?B?QTlVREJoamFsbVlXWTV0bG5GVHhRRU54Y2lPa2dpZlFSOXBXenY2WXRqUGpv?=
 =?utf-8?B?R3huQWZRQ2Q0a2MyeHBIMXhlSU8rcURxZFdMTHJYdytNeUpHT1NESDFCVHVP?=
 =?utf-8?B?aVhtWExGbCtudUJFNFRuSzhHQmhKQlFPamZhOXBNbE1VUXowalhESURsc1l5?=
 =?utf-8?B?WlkxWmgxcjNOdnRCNklPclN4NGlEQkRQTWVZaUVIZGw2KzdBdEgwWVVCYW52?=
 =?utf-8?B?TzdwRFhnazQrY2F2YXMvbDZwL2kyOTl0VmxiOTN2eG4wbUlWT0doeFR4L0N2?=
 =?utf-8?B?UkhmQi8rRmcvZGVkQ21aSFNXdHRpNmYySEdmQ0lOVWJQdVdvbGQrWExObTI0?=
 =?utf-8?B?VnIzanBsVElJdXBwSHo4eWJ4cTZHZ3pJZnBiZDV5TVYwdlZJT2U1Y2owSDJ0?=
 =?utf-8?B?WWU5cGduT01SVGsva3V5WlVrMVNSVnRnaWh4OXNuNXUxa3lvSEtyV0tGSTZM?=
 =?utf-8?B?NFc3U3QyRWV6bzZzcXN6QWtya3BsSW4vSCsvbDZ1Nk1GZCs0V3pRWjZJdVk0?=
 =?utf-8?B?Y09oVHlqRmJReWhWcG1Ha0dMb2JObmRLcG1YeGhmcHVxYkZ1eTZFWEQ3UHpt?=
 =?utf-8?B?djhZWnFyVjZ0eFZ4aWhVYlVSOHpzNGtKMkdSbHpVdlBRanpEUTl4VE9HMkRk?=
 =?utf-8?B?UzhQTTIxTjltSHJBcDJ1cG1DMlFYNjZ6OXluTGQwelJQNFBkbTlJNmx5Y0Rz?=
 =?utf-8?B?djRKRE9NajBDOXNvSmlEVjE5NVpqK25KeWh1bXRHSlI4MUZjcnJwUFhrM0Zz?=
 =?utf-8?Q?+0DRoTfo8d/PfblTaXg9soV3p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7616618a-066a-4fac-9649-08dc234363d7
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 16:32:32.5887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e9+rNiEb23sDvwqOVw9h8XtnXg88RPB0SH7JNbEwYyiwyCUuszFdb2j1Ju+MP2+F
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8326

Hi Andrew,

On 2/1/2024 6:42 PM, Andrew Lunn wrote:
> On Thu, Feb 01, 2024 at 12:11:15PM +0530, Vineeth Karumanchi wrote:
<...>
>> The earlier implementation of WOL (magic-packet) was using DT property.
>> We added one more packet type using DT property to be in-line with the
>> earlier implementation.
> 
> I can understand that. It also suggests we did a bad job reviewing
> that patch, and should of rejected it. But it was added a long time
> ago, and we were less strict back then.
> 
>>
>> However, I echo with you that this feature should be in driver (CAPS).
>> We will re-work the implementation with the below flow:
>>
>> - Add MACB_CAPS_WOL capability to the supported platforms
>> - Advertise supported WOL packet types based on the CAPS in ethtool.
>> - Users can set packet type using ethtool.
> 
> Yes, this sounds good. Maybe add to that, mark magic-packet
> deprecated, and a comment that ethtool should be used instead.

OK. We will implement above functionality and send V2.

Thanks
-- 
???? vineeth
> 
> Thanks
> 	Andrew