Received-SPF: pass (google.com: domain of linux-kernel+bounces-48568-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 1 Feb 2024 09:02:17 -0800
In-Reply-To: <7d74cea0-2d98-476b-8d55-ec3a4e3c0fc7@amd.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240131235609.4161407-1-seanjc@google.com> <20240131235609.4161407-3-seanjc@google.com>
 <7d74cea0-2d98-476b-8d55-ec3a4e3c0fc7@amd.com>
Message-ID: <ZbvOmf8N-tLOr-0r@google.com>
Subject: Re: [PATCH v4 2/4] KVM: SVM: Use unsigned integers when dealing with ASIDs
From: Sean Christopherson <seanjc@google.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Ashish Kalra <ashish.kalra@amd.com>
Content-Type: text/plain; charset="us-ascii"

On Thu, Feb 01, 2024, Tom Lendacky wrote:
> On 1/31/24 17:56, Sean Christopherson wrote:
> > @@ -2312,7 +2314,7 @@ int sev_cpu_init(struct svm_cpu_data *sd)
> >    */
> >   static void sev_flush_encrypted_page(struct kvm_vcpu *vcpu, void *va)
> >   {
> > -	int asid = to_kvm_svm(vcpu->kvm)->sev_info.asid;
> > +	unsigned int asid = to_kvm_svm(vcpu->kvm)->sev_info.asid;
> 
> Since you're touching this, you could switch this to:
> 
> 	unsigned int asid = sev_get_asid(vcpu->kvm);

Ah, good call, will do when applying.

Thanks!