Received-SPF: pass (google.com: domain of linux-kernel+bounces-48522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 1 Feb 2024 08:27:17 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: Simon Horman <horms@kernel.org>, "netdev@vger.kernel.org"
 <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, Sunil Kovvuri Goutham
 <sgoutham@marvell.com>, "davem@davemloft.net" <davem@davemloft.net>,
 "edumazet@google.com" <edumazet@google.com>, "pabeni@redhat.com"
 <pabeni@redhat.com>, "bcreeley@amd.com" <bcreeley@amd.com>, Subbaraya
 Sundeep Bhatta <sbhatta@marvell.com>, Geethasowjanya Akula
 <gakula@marvell.com>, Hariprasad Kelam <hkelam@marvell.com>, Suman Ghosh
 <sumang@marvell.com>
Subject: Re: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Message-ID: <20240201082717.7b946987@kernel.org>
In-Reply-To: <MWHPR1801MB1918CFDBEC70A298A3781945D3432@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20240131024118.254758-1-rkannoth@marvell.com>
	<20240201093119.GB514352@kernel.org>
	<MWHPR1801MB1918CFDBEC70A298A3781945D3432@MWHPR1801MB1918.namprd18.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 1 Feb 2024 09:35:15 +0000 Ratheesh Kannoth wrote:
> > The use of bitmap_zalloc()/bitmap_free() looks good to me.
> > But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I think
> > kcalloc() is the way to go.  
> Kcalloc() is a wrapper around kmalloc_array().  Why do you think kcalloc()
> Is better ?

AFAICT this is not the first time you're questioning Simon's obviously
correct feedback. Are you genuinely asking for an explanation why
kcalloc() is better than kmalloc_array()? It's an equivalent to 
the standard C function, calloc().

The reviewers are the most valuable part of this community, we will 
not take frustrating them lightly :|