Received-SPF: pass (google.com: domain of linux-kernel+bounces-48572-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        "jarkko@kernel.org"
	<jarkko@kernel.org>,
        "peterhuewe@gmx.de" <peterhuewe@gmx.de>
CC: "LinoSanfilippo@gmx.de" <LinoSanfilippo@gmx.de>,
        "p.rosenberger@kunbus.com" <p.rosenberger@kunbus.com>,
        "lukas@wunner.de"
	<lukas@wunner.de>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
Thread-Topic: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
Thread-Index: AQHaVQMsqdJbvpVSekKSGk2C/t7RT7D1rPbA
Date: Thu, 1 Feb 2024 16:40:35 +0000
Message-ID: <MW5PR84MB184274E28D83DC337B486CEFAB432@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20240201113646.31734-1-l.sanfilippo@kunbus.com>
In-Reply-To: <20240201113646.31734-1-l.sanfilippo@kunbus.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GVlvPMn8Tz+2aCGRQEoiVwzbg7eELcLGeGnTuS6WDy7/whFKuU5DjjayDbBW?=
 =?us-ascii?Q?UZc+qmYHdOK0nddArF8x/Xlt8jPqRewmkvUI7s8mIl+jGSY+8mUpeIXYodpp?=
 =?us-ascii?Q?8kMVxRA47d4Y6LIoaSuakaiZa22KqyYd5TYXOuTEQEUYt3nIBaApPm58l/70?=
 =?us-ascii?Q?UEd6Lzce5paeX31/PsUmHPNphrt+pdjEDKzAROUzZmJYFIJQYVzu2lKfBIdR?=
 =?us-ascii?Q?FQpmrI8jMkrmtnThjxsXZY7l5UKCn6o6mjY3SRA7s4a4ve8aNU3ShgQpLgbi?=
 =?us-ascii?Q?pXTdbMCN/OGU5TpRV3/SfiSf3dk3GKsCIaXzZ0U5h3/OLhTbS4HcK41oCw8u?=
 =?us-ascii?Q?uE1o7VFlHauV6QQflOodULwR0TKlJFdRaVNKEfA0O/CEqWZmGyRGvFzPkxKM?=
 =?us-ascii?Q?VMr720FoI+YBKJO35E3rPTv46KMKlOWUa4QpPoE4VDLn3aLvsqZj9HthhDVc?=
 =?us-ascii?Q?cMaJpMdyZBYFxKTJzwt1F46rw2d4zA5udmbGvyYnEdeimPB/iacyjMKS80WT?=
 =?us-ascii?Q?cIlBKwpPtCiace6mdbsMhhcH1sj7gI8X0UOpOnxaJm8eMgfWM3S5o2weRanY?=
 =?us-ascii?Q?q0dtvqCDOr/5ZGcAqumtqANJv8iaJl4611eJnpzNF6uX0mkDhU0xZvrWT/OB?=
 =?us-ascii?Q?hcKC0iVK3Sbr2zpH41lsEdI1afmeEXHJAfm4VAzRFXQQszg7yOeCh3A0fW4x?=
 =?us-ascii?Q?BBpPaNV3kVjpMzrjjfv97RaVyMJTycYcHPt6jbzdCrHytcaYLuPOnYXBlbl1?=
 =?us-ascii?Q?z/HiZqHX+LJKuqAQXA6G8OLZQbS0ShW7uCF8Zvyp+rG0ZhhB1R5iPbd7WCQ/?=
 =?us-ascii?Q?uA4j0Fu0Qn4fKy4G3zTZYo+RHDFFfi0zKcJXDbNiy/p03Z08eIgLx+7SKO1c?=
 =?us-ascii?Q?pqJcDc+VcGbHv8ehbbV4sbZC7cqBESb6Hg391rD9WbZ8NQiV+IDtNkIyxEN1?=
 =?us-ascii?Q?wuIsIQr+QyQhCTdaIfeLQjMEOQrV/8BeGsaDOaPHE1rYxR+46OzfM9FyEkb3?=
 =?us-ascii?Q?PHyL/TDzmLRqye3r61AxtaguqTQprtK6J+3/8GyhZMy80aEb5LUv79MR+SOz?=
 =?us-ascii?Q?urP/BA2NgmZOB8ZA58bAc/k7ziieRXZ7+CXIPi1TjuxbMTcPGDdcP16NVxk6?=
 =?us-ascii?Q?kKHckiF9OCSG2i8iF47HisZAkQSlJWeE0Tonzuhb8noJqu5mdHvs7P87s7uC?=
 =?us-ascii?Q?LiUephVzKl6gFtSJfCpStCFuRWJSRbBknNQoPk7d8JkbMJgUBmuqq+Aq4QS4?=
 =?us-ascii?Q?OR7xwf/Nvb6BycgiGylyFNEgLoNL3jPVL0goSlOO0hp1J6xBi7utavOFnEBH?=
 =?us-ascii?Q?50xsenA1tLJtE+V3QNQJxqWU8sPdOJip1qPf9unRcrlY/SEEWFpHPP3Oavn3?=
 =?us-ascii?Q?FqAN04J2zSOFvWfX2kADUd4vSZZhM2mSEmgl8rDn8opxXIKTmhVFSiEAk9Hc?=
 =?us-ascii?Q?Qgjbi4BxfrbSGdwaMmmSL8QA8fyil2smYZOaq8WUWfdk0dARB1PAA/+6UTd1?=
 =?us-ascii?Q?sbHcpy7u4LVYlgQF6P9gOaLHq90pSBniDV1u4vZYmKwDqAlvfB6khgqJJzJc?=
 =?us-ascii?Q?XzhxStLrOiWM8bIlrdg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 20382ace-56eb-492c-c685-08dc234483e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 16:40:35.6649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LJ0so137Tes4nu7Lsw7Y4gW64SfGdK/c2w//F2/SBhLdiJThx5hEqaGsrTxkAyCw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1539
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: yzAebmcD9Ic7U5XXcU74tzFLQ25s1OVu
X-Proofpoint-GUID: yzAebmcD9Ic7U5XXcU74tzFLQ25s1OVu
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-01_04,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0
 spamscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=670 malwarescore=0
 impostorscore=0 clxscore=1011 phishscore=0 bulkscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402010131

> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> Sent: Thursday, February 1, 2024 5:37 AM
> Subject: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
>=20
> If interrupts are not activated the work struct 'free_irq_work' is not
> initialized. This results in a warning splat at module shutdown.
>=20
> Fix this by always initializing the work regardless of whether interrupts
> are activated or not.

That's using flush_work(), which just waits for one to complete. Is there
any case where multiple work entries could be queued, and cancel_work_sync(=
)=20
would be necessary?

tpm_tis_probe_irq() has a loop calling tpm_tis_probe_irq_single()
for 3 to 15. Could each of those could trigger an interrupt storm and
call tpm_tis_revert_interrupts(), which calls schedule_work()?