Received-SPF: pass (google.com: domain of linux-kernel+bounces-48547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 1 Feb 2024 17:47:26 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	John Stultz <jstultz@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Arjan van de Ven <arjan@infradead.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Siewior <bigeasy@linutronix.de>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Lukasz Luba <lukasz.luba@arm.com>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH v10 19/20] timer_migration: Add tracepoints
Message-ID: <ZbvLHnigSf1NOZ5M@localhost.localdomain>
References: <20240115143743.27827-1-anna-maria@linutronix.de>
 <20240115143743.27827-20-anna-maria@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240115143743.27827-20-anna-maria@linutronix.de>

Le Mon, Jan 15, 2024 at 03:37:42PM +0100, Anna-Maria Behnsen a ?crit :
> +TRACE_EVENT(tmigr_connect_child_parent,
> +
> +	TP_PROTO(struct tmigr_group *child),
> +
> +	TP_ARGS(child),
> +
> +	TP_STRUCT__entry(
> +		__field( void *,	child		)
> +		__field( void *,	parent		)
> +		__field( unsigned int,	lvl		)
> +		__field( unsigned int,	numa_node	)
> +		__field( unsigned int,	num_children	)
> +		__field( u32,		childmask	)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->child		= child;
> +		__entry->parent		= child->parent;
> +		__entry->lvl		= child->parent->level;
> +		__entry->numa_node	= child->parent->numa_node;
> +		__entry->numa_node	= child->parent->num_children;

__entry->num_children ?

> +		__entry->childmask	= child->childmask;
> +	),
> +
> +	TP_printk("group=%p childmask=%0x parent=%p lvl=%d numa=%d num_children=%d",
> +		  __entry->child,  __entry->childmask, __entry->parent,
> +		  __entry->lvl, __entry->numa_node, __entry->num_children)
> +);
> +
> +TRACE_EVENT(tmigr_connect_cpu_parent,
> +
> +	TP_PROTO(struct tmigr_cpu *tmc),
> +
> +	TP_ARGS(tmc),
> +
> +	TP_STRUCT__entry(
> +		__field( void *,	parent		)
> +		__field( unsigned int,	cpu		)
> +		__field( unsigned int,	lvl		)
> +		__field( unsigned int,	numa_node	)
> +		__field( unsigned int,	num_children	)
> +		__field( u32,		childmask	)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->parent		= tmc->tmgroup;
> +		__entry->cpu		= tmc->cpuevt.cpu;
> +		__entry->lvl		= tmc->tmgroup->level;
> +		__entry->numa_node	= tmc->tmgroup->numa_node;
> +		__entry->numa_node	= tmc->tmgroup->num_children;

Ditto.

Thanks.