Received-SPF: pass (google.com: domain of linux-kernel+bounces-48588-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <31c94125-06e3-4459-9688-d371fcc87b2a@opensynergy.com>
Date: Thu, 1 Feb 2024 18:26:32 +0100
Subject: Re: [virtio-dev] Re: [RFC PATCH v2 3/3] SPI: Add virtio SPI driver
 (V10 draft specification).
Content-Language: en-US
To: Haixu Cui <quic_haixcui@quicinc.com>, virtio-dev@lists.oasis-open.org,
 Mark Brown <broonie@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>,
 linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: quic_ztu@quicinc.com, Matti Moell <Matti.Moell@opensynergy.com>,
 Mikhail Golubev <Mikhail.Golubev@opensynergy.com>
References: <20240104130129.17823-1-Harald.Mommer@opensynergy.com>
 <20240104130129.17823-4-Harald.Mommer@opensynergy.com>
 <6171c1c3-55ba-4f74-ae60-764820cf1caf@quicinc.com>
From: Harald Mommer <harald.mommer@opensynergy.com>
In-Reply-To: <6171c1c3-55ba-4f74-ae60-764820cf1caf@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjlWNGpLWFc2N0NnT25YRFcxUTZSVEJSUnJDMU5QaExFaHY1dHdpNklIcTFv?=
 =?utf-8?B?TkZDajhHbnpkZFBZQXo0d1J5dGF5R3VjekR0OWlodTFhMEJmZDdnb2ZQMHdq?=
 =?utf-8?B?cGwvSzFNbHJKUm5JQUtNVzc2d3E4Q3NYc1hwRHlxenkzcDlUN0VHeHZqY3JN?=
 =?utf-8?B?NHlrd3FteGJCRjEyMFVuWVA2VEFqZUgzY2p5OW9DVUJoWFZsYjVyQmRkVTh6?=
 =?utf-8?B?VUdJV3dOcXE5Smpya01SbVBkbmxDV0ZleVF4dWVjZ1YzcGxPTm96YzdEbzNv?=
 =?utf-8?B?cy85Wkd0VTFvb01SbXorbEgrTUUvMDhJUUdGUzJYMHkxMFhwYUJaMjRIWUsv?=
 =?utf-8?B?OTc2Q3BoaVJNV1N5UDh1dXB0ZkIyck1ydjFqTTlPc3ZXRHRlSEU3ZDJncVNH?=
 =?utf-8?B?WW5yMWUzbjRLSUE3MzM2TmlWTW00MnV2WmZiS0hSRVJxY3BEbUMxWld2eVhn?=
 =?utf-8?B?QURnSHFncjZkQ2F1RWJKZ1RiY2kvZkp5aExLS0xIUWR3aGNEUVpiSHVzMkVz?=
 =?utf-8?B?Mm9Xd1VGekNKZGtrOHNxL1NQTWpPUnVYZDRxV2w5SEVFWmZNSnJvSzhZK0dK?=
 =?utf-8?B?RUFkeWVxWWhBajN2TDllQjNaUkNpMGxTWjFVZlpNZXNLZHdta2g5dXVUSXpR?=
 =?utf-8?B?SEFwSFVja0YxeUI5N2QyRU0wNm43WWFKak9yQkhMWWlwZlhhSEorZjVuMEZE?=
 =?utf-8?B?NTVYSXNMNyswd2NFVWI4NDFXOHpaZWp4MFVYQXdFb1VBWTVSUk5mWm51Uzc2?=
 =?utf-8?B?Ni8xazg2UGJiU3dIYlNsUGxacm9UVGNobmoyazJsWWJoNDVpdXJLUTB6ZHhs?=
 =?utf-8?B?MlowM3lNRE80eGFyMFBJOEw2UXRnZHdjTlRSRTlaSk1hR2hPd29kN01NYWgz?=
 =?utf-8?B?b01LMkh1c0dSUnBzSFFTWEFncHNVWFp4bFFQTlJIRWNIS1dibVp5NTRXbC96?=
 =?utf-8?B?dndaQ1V1WHcwaEkzWU5rSVZEYlg2c2I2NWlhdi9tS1laTk42ekV2bXd4ZktZ?=
 =?utf-8?B?b3hsNGJFaUNsc2o1MHA5anBoZ0w5c2VBRjhtdmxUaGlINHBJRWtLeGQ1Q1ls?=
 =?utf-8?B?RHNFc3BQT3VkVUxMcHpsemEybys1NUs2VjhIYUxkOThrNGY4d2ZYeHM5THhv?=
 =?utf-8?B?UW5SRUVNYXhEWGFJYXB1REttYzJyejczMG1DRGhER2I4MmFMYkhoUFFmNFYx?=
 =?utf-8?B?RjJEZDh0UXMxUndSbGdHQ1BDeVJHMzZraUxNczJYeTg2UDFlZ2orYWZSMWI0?=
 =?utf-8?B?YkdiNE1LVHd3WnNmR29FdmR4cWhFeml3VElVNTkrYkw5dU1ndm1TdHprckJW?=
 =?utf-8?B?anlGaU8xZytOa1dPckpFb2VCeFJxNzNvVDlSc2pvZ1E4UEg4VWVWUDRMTUM0?=
 =?utf-8?B?YTVoMjM4aXlrNE9uRVpDTE9lWm54RmZieGxkSWszUUNUMHp6QUJGa2dxVDZC?=
 =?utf-8?B?Q2NNWjN4YjRvS1dXMzgySUxDS3FBZFhiRE1WbC9wcWpheHphRC9DbUJlTVFy?=
 =?utf-8?B?ZFdxUHdzVThEK3l0QVZzUkh5d3d2YjJqcnFFbkg5WEhoY3BqNFk5TTB3NXhX?=
 =?utf-8?B?cDIwV2E2MHZyVk01U0ozRE9pMUpVTGFQYnFoTDE2d244TjNvNXZmcWJXSk1y?=
 =?utf-8?B?bG5JdVBFa0tvWG03K2JJUnJuOGYweFdmdmtGQjM4NGRXQnFHajNmRFhQYTJo?=
 =?utf-8?B?ZWRGYW1uZ1YyRGc3U3dTWGFDOFJ1MDIyTjFES01FZmo1OEpVRjUyTUNKZEpW?=
 =?utf-8?B?Q1hjTGRCOGRHN1R5U1ZRUlBvaFF3R1dGK1lLTmRST21MSkM1THVTbUs5b05U?=
 =?utf-8?B?TmZlcmF1MU1aZXJJWm9SeGV0UHphaVp3UjhIdmJ5Qy9WN2xZYno5UUgzSWo4?=
 =?utf-8?B?NE1VRmc5Rm9EU2J0em5Xc0krdmtha3hMci9iQ3JzMjdRekk3ZHdkazIyWmFS?=
 =?utf-8?B?THJzRkNHZVRRTTJWMVVrZTgxQk92Kzg0UzhoL1NNbEFhNDJIZnJtRWxxWVRP?=
 =?utf-8?B?WVY3VldIREl3T2hJb3FKMFJvanFGazJUSTlzK3dHY1pFaXA1L3cyZ0tkQXl3?=
 =?utf-8?B?bE9RTUZvTUlyRWUwS295MyswcmtNMkYreHNBbE9VdXZrYjVMODhNdi9WRElH?=
 =?utf-8?Q?4xMzrbw/zEYGRr1M0X8IcRo/b?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37a91bb5-f244-4468-6a1c-08dc234aeff0
X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB2279.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 17:26:34.0859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CfyC7akxZCVYYIfklmN1ksRwzq1xCi08GG08bmnYF29HSsUAtDVEta8wV6CVB8LLf2Z2phvMV8mbkdw2cMIf2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR2P281MB2127
X-TM-AS-ERS: 104.47.7.169-0.0.0.0
X-TMASE-Version: StarCloud-1.3-9.1.1015-28158.001
X-TMASE-Result: 10--15.520200-4.000000
X-TMASE-MatchedRID: 8+bhjh9TQnH5ETspAEX/npGPSO6O5JCaTTDWNi9ivw+J3Smid9WN/ZZ1
	P5vNF6357E4hcO6MtBZnL2Fmt9cIIByvYkiXIxX7iu6u4shZ+fEH/MsNCRnylTC402g4LjYv84Z
	CfU4ptaA5hCQFWpSptiPJ2hEK0g1YYNP5ZvfGAKvOlc6uOs4xMfJDp0CY93MS4j+plUCB/Tou1L
	sXcrdKSAmz/HlFMCJXEVh8nh3wkeLM++KBJYTUQWKwQsDFdhcMJbzZuwLx+4WZlZD1Y4akg11HP
	AVML+u5OSKcrSkG2gig9SIO+VAFXuYEkpbanTHuQfEHsmyy6QIUb00fKSHNj63/rEOakn8sT0BR
	ZNI+YwbANog326X8vtXNOAQ2MSi2muMpo5XKw2858Sarp97J825FeHtsUoHuthEh7LXCm+W/hfz
	PDA48fmkIJe/rPpLiU4iF1jKxJ6iwFMlIPaIBbQ==
X-TMASE-XGENCLOUD: 3dcee6a9-ff04-493c-9609-a83a29d843a8-0-0-200-0
X-TM-Deliver-Signature: 671EF3F6A6472E86F37AA7FBAD324E4F
X-TM-Addin-Auth: sYJhKQnzhzVpicWH1lRpymmchr0sb8Uas/HOkZn7ejEbc0MhlcscoOjTdEz
	V7igpqMavFDqJIULsq1ttmFrAdZ+1yx+8fqBqmTC6eSdjgVJHyo63VLGbPsXlPuRzHG7OEZI+Ep
	7VhOQiOZuGH6a5eVyEClv1NRFDUCOwFP/Cml4vD6idART6P9yUUJFJWZXQo4HxjXuRjGKcVUlEI
	JVg6Ct/5+0AURcOnKHI2C6yDVYdU2whb8ufmpGwLuvMw7WXT6bFY7ko/6kB57IUBNSI3n/AOTHn
	OjA2NoecZIXBOVU=.nXRipX3oo8SIongewef6CFVmY20p/5bZK84yJpwIv6wRlumesm8ubimeCz
	y89RhvdxhA2fxHNPKBQiZixO4+RAqpiZwHY12JsIICGEn3+nzYaG6vIRJYyqSFyhH/uYJNIhgWi
	M7eM7azS3d20f4v6Q1TxuhAA5Y9zbBxbopQxZCgaFzQBWro2e5voB+pz5BWZBF6Teg13VCZnygu
	5cmMxk8hw3SENqKI/W7SOKaPSJgRTm4hVKCPDjXkj+wD2OE7yv9RzU5bM6Sr3lfPepcY8IteA0c
	b99vxLgUAHefwW3sfo+px6JfqNaj9CJQkgDD3672Dkl23pPe2yKh8VVMscQ==
X-TM-Addin-ProductCode: EMS
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opensynergy.com;
	s=TM-DKIM-20210503141657; t=1706808396;
	bh=cP/VshhGLU9fBJlCgcmRC4W+KxR0f0qWH2Qb56TcEjg=; l=2287;
	h=Date:To:From;
	b=B5pz8IK4MdL4+eY4DhuTosn/a5HL9rFKgLIWVCZQoS1QKb/W2LYQPlzJtSgxfKCqm
	 b0V7qtDjZcEbvYvO1yf2iQArEYVXYM+1YuUtFqePXpn5nuaQfbMpXPsHSXE6xdIYu6
	 Ix3cTEwq7qF4yxGAI8OyNN7yOpDRC5QEI5l3qdDLH17Kkao1YWykLDfUyVWraTOedd
	 h5cqBiBcvGNWVj8wMOqpgvMLe5g+Zi0gTIbq8zxKXXLsnu/+zfJ177THS7vrY6GIi/
	 Nvft8jA69tSLXsujUZCktPcQhnfJDAdOxu+Fhukh+3PfspXTlR4N8CnrqzN+WNa7Mg
	 D+6M58UPL7c9Q==

Hello Haixu,

Thanks. This was a hard one. I knew that I did the delay settingsmost 
probably somewhat wrong but I had no idea that I did it so wrong.

Reworked, made a new function for this, currently testing. Added the 
link to the place where your E-Mail is stored

https://lore.kernel.org/all/6171c1c3-55ba-4f74-ae60-764820cf1caf@quicinc.com/

as a comment to the source code and hope this will survive the reviews. 
Another option would be to add the diagram + the explanations below as 
quoted here as comment to the code. Whether 30+ lines of comments would 
survive the reviews I don't know.

Just to say nothing in the code making live hard for people trying to 
understand the code is something I would like to avoid.

Regards
Harald


On 30.01.24 04:21, Haixu Cui wrote:
> .   .      .    .    .   .   .   .   .   .
> Delay + A +      + B  +    + C + D + E + F + A +
>       .   .      .    .    .   .   .   .   .   .
>    ___.   .      .    .    .   .   .___.___.   .
> CS#   |___.______.____.____.___.___|   .   |___._____________
>       .   .      .    .    .   .   .   .   .   .
>       .   .      .    .    .   .   .   .   .   .
> SCLK__.___.___NNN_____NNN__.___.___.___.___.___.___NNN_______
>
>
> NOTE: 1st transfer has two words, the delay betweent these two words 
> are 'B' in the diagram.
>
> A => struct spi_device -> cs_setup
> B => max{struct spi_transfer -> word_delay,
>          struct spi_device -> word_delay}
>     Note: spi_device and spi_transfer both have word_delay, Linux
>          choose the bigger one, refer to _spi_xfer_word_delay_update
>          function
> C => struct spi_transfer -> delay
> D => struct spi_device -> cs_hold
> E => struct spi_device -> cs_inactive
> F => struct spi_transfer -> cs_change_delay
>
> So the corresponding relationship:
> A <===> cs_setup_ns (after CS asserted)
> B <===> word_delay_ns (no matter with CS)
> C+D <===> cs_delay_hold_ns (before CS deasserted)
> E+F <===> cs_change_delay_inactive_ns (after CS deasserted, these two 
> values also recommend in Linux driver to be added up)