Received-SPF: pass (google.com: domain of linux-kernel+bounces-48584-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 01 Feb 2024 09:22:09 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
To: =?UTF-8?B?Tk9NVVJBIEpVTklDSEko6YeO5p2R44CA5rez5LiAKQ==?= <junichi.nomura@nec.com>,
        Borislav Petkov <bp@alien8.de>
CC: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "ardb@kernel.org" <ardb@kernel.org>,
        "david@redhat.com" <david@redhat.com>,
        "nikunj@amd.com" <nikunj@amd.com>,
        "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
        "debarbos@redhat.com" <debarbos@redhat.com>,
        "jlelli@redhat.com" <jlelli@redhat.com>,
        "lgoncalv@redhat.com" <lgoncalv@redhat.com>,
        "dzickus@redhat.com" <dzickus@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] x86/boot: Add a message about ignored early NMIs
User-Agent: K-9 Mail for Android
In-Reply-To: <TYCPR01MB83890E6AAACF90C3A45A8E0F83792@TYCPR01MB8389.jpnprd01.prod.outlook.com>
References: <ZaEe8FC767f+sxRQ@jeru.linux.bs1.fc.nec.co.jp> <20240112120616.5zjojjmjeqg5egb7@box> <ZaTziftQSSg/v5Np@jeru.linux.bs1.fc.nec.co.jp> <20240123112624.GBZa-iYP1l9SSYtr-V@fat_crate.local> <TYCPR01MB8389C46BF755C31EACE8DB37837B2@TYCPR01MB8389.jpnprd01.prod.outlook.com> <c0527ca3-22c3-4b92-a34f-adf0cae78146@zytor.com> <TYCPR01MB83890E6AAACF90C3A45A8E0F83792@TYCPR01MB8389.jpnprd01.prod.outlook.com>
Message-ID: <411D32E2-4D7F-457A-B61A-731E1264CAA8@zytor.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On January 25, 2024 6:15:15 PM PST, "NOMURA JUNICHI(=E9=87=8E=E6=9D=91=E3=
=80=80=E6=B7=B3=E4=B8=80)" <junichi=2Enomura@nec=2Ecom> wrote:
>> From: H=2E Peter Anvin <hpa@zytor=2Ecom>
>> On 1/24/24 03:44, NOMURA JUNICHI(=E9=87=8E=E6=9D=91 =E6=B7=B3=E4=B8=80)=
 wrote:
>> >> From: Borislav Petkov <bp@alien8=2Ede>
>> >> On Mon, Jan 15, 2024 at 08:57:45AM +0000, NOMURA JUNICHI(=E9=87=8E=
=E6=9D=91 =E6=B7=B3=E4=B8=80) wrote:
>> >>> +	if (spurious_nmi_count) {
>> >>> +		error_putstr("Spurious early NMI ignored=2E Number of NMIs: 0x")=
;
>> >>> +		error_puthex(spurious_nmi_count);
>> >>> +		error_putstr("\n");
>> >>
>> >> Uff, that's just silly:
>> >>
>> >> Spurious early NMIs ignored: 0x0000000000000017
>> >>
>> >> Would you like to add a error_putnum() or so in a prepatch which wou=
ld
>> >> make this output
>> >>
>> >> Spurious early NMIs ignored: 23=2E
>> >>
>> >> ?
>> >>
>> >> So that it is human readable and doesn't make me wonder what that he=
x
>> >> value is supposed to mean?
>> >
>> > Yes, it would be nicer to print that way=2E  I used the existing erro=
r_puthex() just
>> > to keep the patch minimal=2E  I will try to add error_putnum()=2E
>> >
>> >> Btw, please use this version when sending next time:
>>=20
>> Here is a *completely* untested patch for you=2E=2E=2E
>
>Ah, I was preparing decimal only version but yours is much better=2E
>I tested and it just works=2E
>
>I would like to use yours as a prepatch=2E  May I have your signed-off-by=
?
>
>--
>Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd=2E

Signed-off-by: H=2E Peter Anvin (Intel) <hpa@zytor=2Ecom>