Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp342301rdb; Thu, 1 Feb 2024 10:00:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpgX9TnPuzoiRWbirJgnF1QnrtTwn1p5chQjPJBSryl16a4ADcF41SZ1gQrWWvshLxEmpu X-Received: by 2002:a05:6214:29eb:b0:686:9f99:97de with SMTP id jv11-20020a05621429eb00b006869f9997demr7475854qvb.13.1706810402577; Thu, 01 Feb 2024 10:00:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706810402; cv=pass; d=google.com; s=arc-20160816; b=QWoObPqoA/ocudO3Wn7k2wlQaWNQgCNV+KTHtgn80kun3U3Yaxa/O+tAnDeh3jJVy2 jG7h6kJfbYhXLDK87iaG1E6JnvPzo0xsTYXsF3h9t9zB0LkbuHItR54g90MtsBU5St+N x2S+Eg03N/WCpIDC+uHL7TaQaTtPg0mOseAWZ6u8rdAK3SFOvmN05V1f/ywPT3yIfXv+ 7F9WZZxiYMi50vHoo2wQLMufMprJ5Y7i/hsKJAcBiAg8oS6/x85Nl0HP0VW5y3Gu6ayN /+b+OB9ETPE2Wqn8zHIx6Vp0KJUdsDzx78dtUV4hnjEqLT3DpEsROK4sYLx49L6jL3gY 6ViQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=rIrh059PrpeyXbaJr/t3/vTFAkpJFqhcp54WmRwO6II=; fh=uAokXQai5qdCvEaRs8+tjHsg6rFllqEbl+di9Jq8kto=; b=hb5ZTwVKwVwG9VaQBYdw6F2IVsTmHgNIEGVxCXuoci/kj4LdBN71OoKCbrpSuazNCZ T0WxR2mR2kdadn7SXXPlxADK96PrlarYY11KzTkNYz29CNHm4Srd4H/GQlaAaBXmjcga c4WctrpfWqTtb3lkCikb3+x9W+3wbDhgFNS7IpX3dqQ+WZsgvjoLz5Wpu9NrVSXhSepQ Q3AxM/7fzJIZaQwbuM6TU40Pmk6ty9DxzXjdq2Ny+ZFEE2/GQVjPJ8ZSoxWPqTpg+ht9 BPtgk11LTiKJQQLYWAxJIh2f0/CPsPxBJpohL00EUqpLx+edPW0tB0ItnrVqwJCXFidc lV+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=q+Fs1l+E; arc=pass (i=1 spf=pass spfdomain=gmx.net dkim=pass dkdomain=gmx.net dmarc=pass fromdomain=gmx.net); spf=pass (google.com: domain of linux-kernel+bounces-48629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48629-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.net X-Forwarded-Encrypted: i=1; AJvYcCXDwxMH/RXdVREJVNNpKXX8tsqp4GSvDBdbIVfHvOko93dDHqaLcsN75ZeWa9Gib/BeVsVTWpVx42xJ3igHilvpk+o2HzAMmwaSHoDiAA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c11-20020a0ceb4b000000b0068c51eb0a95si8964qvq.83.2024.02.01.10.00.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:00:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=q+Fs1l+E; arc=pass (i=1 spf=pass spfdomain=gmx.net dkim=pass dkdomain=gmx.net dmarc=pass fromdomain=gmx.net); spf=pass (google.com: domain of linux-kernel+bounces-48629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48629-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4F18D1C249CE for ; Thu, 1 Feb 2024 18:00:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD5DB7C6C6; Thu, 1 Feb 2024 17:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="q+Fs1l+E" Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D493782C9C; Thu, 1 Feb 2024 17:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810394; cv=none; b=RV+ba4BHQ7acpkSAbCdJZOxXXmdudIHvMgRqEl1s2F8wQwBtmobn5It6TV+2iACuJOPW7bjvNJgiz/kGJuDTsptZ/I8rvZ1GXwaohXrauKgqOE8ETQ+9vegMlQy6btqFm3gVnWRWO6czEEBgNjk41Trd0HdOI42S0O6eXnIrhGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810394; c=relaxed/simple; bh=rIrh059PrpeyXbaJr/t3/vTFAkpJFqhcp54WmRwO6II=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=smrwhwVESSMibG+E4mEQjNS2pM0KojKmGH4/Z/BV4ttyjlqwgTAZACp2BkUnjTPMsQvV8W3zPDM/IvpKDnuyWW2Fir8AYi8Wsxsonj6W8op4QssMXoUATUVc3wrgwYReQuy8xzbgjoevipdXI34MHX4gU9/H+yj3+r0PU03UIzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=q+Fs1l+E; arc=none smtp.client-ip=212.227.15.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706810378; x=1707415178; i=wahrenst@gmx.net; bh=rIrh059PrpeyXbaJr/t3/vTFAkpJFqhcp54WmRwO6II=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=q+Fs1l+Eh6RRfby/tGba/XuicnWTiMYKuAnqLqYVoVWLCTaFlGRCQymVSHD2GudZ mrcLBA9SuVwFDw97oXl7dvDU7oKCkEj8zU0rISnOvcA9xOgJ131ns9nc3klkk9ZrS sPaif2Q8U3RjDQ9yO2c/ynGFIp8/tGOWo+g2uR9vghLWUG7EkgeigeeLrK+5F75Tb djXXf1PmxfG4RzvMuFThjxqDgOQUwAJpHnNorVVGUZWt/qMXkZwJpt+KHV193Dagw RJvZc0jcUKz33McF9x9WiqvjsxdWiqTfuEl3bWr2c4LZpxWJYBXn+JBMulv0ZshJw PSBuqRWFdQ9WzyF4TQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.167] ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWRVh-1rWv5e49AB-00XpU5; Thu, 01 Feb 2024 18:59:38 +0100 Message-ID: Date: Thu, 1 Feb 2024 18:59:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] serial: mxs-auart: fix tx Content-Language: en-US To: Jiri Slaby , gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Emil Kronborg , Shawn Guo , Sascha Hauer , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" References: <20240201105557.28043-1-jirislaby@kernel.org> <20240201105557.28043-2-jirislaby@kernel.org> <3935b841-77b7-4265-a727-98a358cd56be@kernel.org> From: Stefan Wahren In-Reply-To: <3935b841-77b7-4265-a727-98a358cd56be@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sXH13v5sOclhojjCcbDB3ZiwD232n6qyAlzp6uIb51/p5gQDxPC /LWgrH1BsvCbGKHIdMZaebaawSvaK1uVuCyVoE7dPDCdZzoPzRcz2GX7FoBBSEnFoYAHCVr 7bkcBbchWMzIp0FP49HIxL/UcxiFi2oqknqpKg54uP5QOBeWPEoqQXvRK2LLGbKmueE4yO8 Esp96CrFy6HKm2I/SgNlA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0cadcR9eHiw=;Hi1bLUCBqnOjcfDicUxDZLbsY1C hEXa/uBP8PB/Siux9/71IqwlWbG6kvNmigcI2Inq+ONUGkdstpHWVVOEobmT9qVTlcjR6zWNB DgmJeVtIQa6ywrslbKb0zGN2ZU/ffNXzOqqjQaoeNImEKYjpzFhY5fYTg5dx1xuve0gKdNQMI JrzEMcG0ONkP32xkh2noS7ZPjG9NGk7RHN5ZGYfSXEO8pMm17/m8Aq707ptZGQmNONUCOoA3k mZ4Xt2YxeGG+j8uEg4eTscFVKuQyOT8dWB/KWpqUjkSgLpSVZsX1rdtiSbZbE6c5vzi4E/j6k iU7lo1naqFgslX/f59L/gi4B5ov3YRi9F96BCltOkSY/IiVBd8zgT/gizf98ev1//7vRxT+mh qK9GhbL5CRrrMRoXKnDHbvuhxmUTME8uzm6g5XFWq0w8O42HIrWG+qm4PG4M5RrYxSKwkqaOe F5PWvRlVbqHBGqAsWtmfx9kS6IQSMhzaGmF107Bi3WT4XArFjP6biNX5+f1i+HZOkvXB43AkS pEfQnXEBcIdd8As84L4SQF+VFNGIOpAoV2Tt3NwbeBCL3fkKnByj6R0Xk9gHs3b4xEMweAZrK waVTliagtJBhs3c+cBpVosA5usS9pXP/cx0OXmDa5nGUqx4PIeYA0t8V09ihUGRLd0Ek+aKiX pWra6O1A05UEiD/dQC6asRx7KLZ6p1RPwJMspdw89Sx/lDU9Bqxz4y6C+4/8pXuo3JXYg/NyB Vt+o9iZksm0C2lNcwR9jFS3byiiFntyycUFDEg3CAJd7T+stjlzhJ/2Y7WLxZx/ArEM9RPbzQ OfZRMDwxTZW7KpFAo2aZVJBDJxnbRWimK4UTbqK2uNWr4= Am 01.02.24 um 13:05 schrieb Jiri Slaby: > On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote: >> Emil reports: >> =C2=A0=C2=A0 After updating Linux on an i.MX28 board, serial communicat= ion over >> =C2=A0=C2=A0 AUART broke. When I TX from the board and measure on the T= X pin, it >> =C2=A0=C2=A0 seems like the HW fifo is not emptied before the transmiss= ion is >> =C2=A0=C2=A0 stopped. >> >> MXS performs weird things with stop_tx(). The driver makes it >> conditional on uart_tx_stopped(). >> >> So the driver needs special handling. Pass the brand new UART_TX_NOSTOP >> to uart_port_tx_flags() and handle the stop on its own. >> >> Signed-off-by: Jiri Slaby (SUSE) >> Reported-by: Emil Kronborg >> Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper") >> Closes: >> https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bub= bduu23s@om2lptpa26xw/ > Tested-by: Stefan Wahren Thanks