Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp353134rdb; Thu, 1 Feb 2024 10:14:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpZNkH5tZbx6KE+vCm/x+gUhdLRR64ibSglBv/rv4/rjpoAVKk0hliiqhNCUtSeWoCF+YP X-Received: by 2002:a17:906:d0c9:b0:a36:6c96:3161 with SMTP id bq9-20020a170906d0c900b00a366c963161mr4216651ejb.32.1706811254907; Thu, 01 Feb 2024 10:14:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706811254; cv=pass; d=google.com; s=arc-20160816; b=I+OG5wwTFcShdBGzK+5X8Lip8TUxnR/0dAu3H4/QJwnoZxuwiWm5fks0WsLPu1Vfrz C5IwbTfhG+IASYo5b/DgoXGKWtTRUolJBdAKEgp+8J9c/T+hyGl4vVsSQsBs1jid7mi7 JlggjT/cvOtFa0Y8lxeF6Qm1QuI4G+mUIQ4AtWsneOO+zfp8aFo+meJjFQ/08+WocNHv vWHnpj2GY4mYlIT0OOgmzjRekk+Yo/Y9IsfO5d8pkgaAclYZLYaY7JvNo2u0PzT9y7rt y5+1D5C4cAxMr5L4XK6uARK2baXU3gpkbybxRQ85bP/bmzEy+2sgB7XIG6jL6zMOqbX+ t30w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=GToPV7msCPjuhO1dWFLWs/ihnArgx8snuOE7VU2ptxg=; fh=lB3xJxd0AhPckn7VhSGKHgq+nkNgfue1gFKgoUn1MgA=; b=hWKZj5S1yXKNLv41HTRyfU6yCJ5jut8nEYjkL7P4xsw56RKyDmcHBhIiPZet57ario dcyUu1rJihMaBz3kUB0ltVxNySrtSN3W2x1UHPLKDjaFZ+G/vxJNPfM1GgGragpPmHZY QRzRImBkdKRIq+h8vell3VJwoovq0YYjyiH3u+KXM/aYJ+CH9YjaUAa2a0BoJ1xv5fm6 vvMlx/xWOYHWbI7CEJhNnwAhPbElE6nLgtFVEkVhBysWOJ21STx1TNgOmbbhu2UHpsbS uzTyg54KZ3cZ3gq4OHGlTrC91eBTaWnx9fkeb8rXrc9dxVE/KQ3WSWvTEuTm446fppes CQCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WdRRDQiY; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-48672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=1; AJvYcCWu9P0UR2yavkBKyo3MqMR7YDVk+sJCI1ftCJ7PZ+1WZ1O51+KZNWsbblnEBGP3kHX6c/psAtotaU1pduLV2L7WL0jhoxFeGxkve49YJA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qw22-20020a170906fcb600b00a352ec01517si36186ejb.161.2024.02.01.10.14.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:14:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WdRRDQiY; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-48672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A4A061F23EEE for ; Thu, 1 Feb 2024 18:14:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9868084FBE; Thu, 1 Feb 2024 18:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WdRRDQiY" Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 680DD12FB04 for ; Thu, 1 Feb 2024 18:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706811065; cv=none; b=ayPdlT0+FpiOkAphM8yi2Gs6fFayYrv4WOt7g6nmjD9HqyPXVLACynW5FG63dxCt1rt+DZqLUAZXag0txxN0smg4ZlbHLM5Rn12sGGwZANOIltHkaFmOpMhsQqGYmAKe3fULrZ0IJEkGp0ogmQgaYU4tA6Ez39qi47ivm0giFr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706811065; c=relaxed/simple; bh=r200j0k5z6M8FPk7ea3dtycPDKu5zgqHntQsz9dmHCM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=u8comshStCuM+Ur92uRvW5XvZ5Gauc72SiAlMNeExB5PFhzuczXg1mryeB98tD8Ibd2tsyDqeyWrJoD3cpsGfpCZjv7GwxrIgY9EmtBMu7j/iuYd0g9Du5pFzPlasjhH1wer5+qIi7fiKrpvqvXzwap/yS+k0QQzOAn4wId4TCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WdRRDQiY; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2906855ac5fso964813a91.3 for ; Thu, 01 Feb 2024 10:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706811064; x=1707415864; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GToPV7msCPjuhO1dWFLWs/ihnArgx8snuOE7VU2ptxg=; b=WdRRDQiY1y1r8t39ffQ14BjgrJexJXOgBqWyYctncm2e9e1LPwDTBUgI+e4T9tZtkF 4fGUNfMdPZjnTJDAYZY0HtUQk2C4ZENP8sYc83w/Y37Kx8H6FuFpfSl0esJBf5W8whdq M+ZtIw+CYYUUkIiGxXeuUkQ7GJjsFXk/4lLm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706811064; x=1707415864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GToPV7msCPjuhO1dWFLWs/ihnArgx8snuOE7VU2ptxg=; b=BrQ1TPVgM9iFVAw8m20gLuQlk5A2KGgtCYFsA+/ysSYuKcb2lfGH/Pg4O+/s6K3kx6 9OkRNAER2EqnQj3ak2kQHn+7fe2JQ/2mxBNn7NR/AdmGhPx6HlXStjY/D+MU3VZMEzx/ H5GsVP1cnvbLlFYxfboos4Z2BxZqVVfqYZV49gxEvsyFqf6TzmHwiIaG8vr9QUpbRYkS 4Y26YwnN2Pz8b0sX0wK2ibcfToFkF6IGfbXy8hS2I3ypx7yMTWv6V9shlfJtv4Gvoj0+ +ssE6jjFubBxfcYckFH1Sfn+BqUKca7Zpr1uWBYrLsKnLscFyMs3HVLCgouYK05yhni6 s6lg== X-Gm-Message-State: AOJu0YxmEvlSQtTnCtiWWg4Ui5hiwsBMt/yUXXZ8McPWRh4YhINE4Hwz PjXxbIbC03yz994JQ9bObil6E9AQdghvFv5Rfyp4nTogHE1sUPTwsQPl5xhpqA== X-Received: by 2002:a17:90a:bb93:b0:296:2057:28c with SMTP id v19-20020a17090abb9300b002962057028cmr1860044pjr.31.1706811063830; Thu, 01 Feb 2024 10:11:03 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW2krWTMKExdhHWt6TyQjL1Rm7yRFYGUHQLWTf7/hqr1tPiDR9vLa5HYLg2BT6axZpvzUHe1a4RkKIU2cVjAPjFY7+u9f8gUSExtTZUFYdXRlLVh/dASAxqvvGt+AEOCDtKyRGq3ZT7wMKv3FDiXcAH23xD2EnLrrRCRHcyHJ2+OMIZfloJn1XE7zlo3TwFcMS5LrGZmeY= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id su14-20020a17090b534e00b00290a6b587fbsm112120pjb.48.2024.02.01.10.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:11:03 -0800 (PST) From: Kees Cook To: tony.luck@intel.com, gpiccoli@igalia.com, Kunwu Chan Cc: Kees Cook , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pstore/zone: Add a null pointer check to the psz_kmsg_read Date: Thu, 1 Feb 2024 10:10:59 -0800 Message-Id: <170681105755.3764329.93715039657741016.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240118100206.213928-1-chentao@kylinos.cn> References: <20240118100206.213928-1-chentao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 18 Jan 2024 18:02:06 +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. > > Applied to for-next/pstore, thanks! [1/1] pstore/zone: Add a null pointer check to the psz_kmsg_read https://git.kernel.org/kees/c/69f381e67d6f Take care, -- Kees Cook