Received-SPF: pass (google.com: domain of linux-kernel+bounces-48679-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 1 Feb 2024 18:15:20 +0000
From: Conor Dooley <conor@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, srk@ti.com, r-gunasekaran@ti.com, b-liu@ti.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2
 register space
Message-ID: <20240201-viewpoint-upload-fb714f650ff5@spud>
References: <20240201120332.4811-1-rogerq@kernel.org>
 <20240201120332.4811-5-rogerq@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="OtyWSM2MmQ63Tw2S"
Content-Disposition: inline
In-Reply-To: <20240201120332.4811-5-rogerq@kernel.org>


--OtyWSM2MmQ63Tw2S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote:
> So far this was not required but due to the newly identified
> Errata i2409 [1] we need to poke this register space.
>=20
> [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf
>=20
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>=20
> Notes:
>     Changelog:
>    =20
>     v3 - new patch
>=20
>  Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Doc=
umentation/devicetree/bindings/usb/ti,am62-usb.yaml
> index fec5651f5602..c02d9d467d9c 100644
> --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> @@ -14,7 +14,9 @@ properties:
>      const: ti,am62-usb
> =20
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: USB CFG register space
> +      - description: USB PHY2 register space
> =20
>    ranges: true
> =20
> @@ -82,7 +84,8 @@ examples:
> =20
>        usbss1: usb@f910000 {
>          compatible =3D "ti,am62-usb";
> -        reg =3D <0x00 0x0f910000 0x00 0x800>;
> +        reg =3D <0x00 0x0f910000 0x00 0x800>,
> +              <0x00 0x0f918000 0x00 0x400>;

Why the double zeros btw?

Cheers,
Conor.

>          clocks =3D <&k3_clks 162 3>;
>          clock-names =3D "ref";
>          ti,syscon-phy-pll-refclk =3D <&wkup_conf 0x4018>;
> --=20
> 2.34.1
>=20

--OtyWSM2MmQ63Tw2S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbvfuAAKCRB4tDGHoIJi
0mWrAQC3uMg2ymui8kJ6/QbX6cNAVZEC+xxJc3kwh3We812E4AEArck+H328Eujt
zt2rkVVVHTdwtsoFF7DgMldm202/zgc=
=6c4e
-----END PGP SIGNATURE-----

--OtyWSM2MmQ63Tw2S--