Received-SPF: pass (google.com: domain of linux-kernel+bounces-48680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 1 Feb 2024 18:18:05 +0000
From: Conor Dooley <conor@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, srk@ti.com, r-gunasekaran@ti.com, b-liu@ti.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2
 register space
Message-ID: <20240201-violet-chalice-51a73f113e7b@spud>
References: <20240201120332.4811-1-rogerq@kernel.org>
 <20240201120332.4811-5-rogerq@kernel.org>
 <20240201-viewpoint-upload-fb714f650ff5@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="8eQ0qgWYbjjWzvr3"
Content-Disposition: inline
In-Reply-To: <20240201-viewpoint-upload-fb714f650ff5@spud>


--8eQ0qgWYbjjWzvr3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote:
> On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote:
> > So far this was not required but due to the newly identified
> > Errata i2409 [1] we need to poke this register space.
> >=20
> > [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf
> >=20
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
>=20
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Actually, where is the user for this that actually pokes the register
space?
You're adding another register region, so I went to check how you were
handling that in drivers, but there's no driver patch.


>=20
> > ---
> >=20
> > Notes:
> >     Changelog:
> >    =20
> >     v3 - new patch
> >=20
> >  Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/D=
ocumentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > index fec5651f5602..c02d9d467d9c 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > @@ -14,7 +14,9 @@ properties:
> >      const: ti,am62-usb
> > =20
> >    reg:
> > -    maxItems: 1
> > +    items:
> > +      - description: USB CFG register space
> > +      - description: USB PHY2 register space
> > =20
> >    ranges: true
> > =20
> > @@ -82,7 +84,8 @@ examples:
> > =20
> >        usbss1: usb@f910000 {
> >          compatible =3D "ti,am62-usb";
> > -        reg =3D <0x00 0x0f910000 0x00 0x800>;
> > +        reg =3D <0x00 0x0f910000 0x00 0x800>,
> > +              <0x00 0x0f918000 0x00 0x400>;
>=20
> Why the double zeros btw?
>=20
> Cheers,
> Conor.
>=20
> >          clocks =3D <&k3_clks 162 3>;
> >          clock-names =3D "ref";
> >          ti,syscon-phy-pll-refclk =3D <&wkup_conf 0x4018>;
> > --=20
> > 2.34.1
> >=20


--8eQ0qgWYbjjWzvr3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbvgXQAKCRB4tDGHoIJi
0sdAAP9CwtjgDQiVIVOeUV887o2JKyoIPBrTD8GYnJlNJha6DwD9GbpvvnGm33n9
XM3cVekUSO7RnwTFzob/dvmPCq/PrQM=
=Qazv
-----END PGP SIGNATURE-----

--8eQ0qgWYbjjWzvr3--