Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp361467rdb; Thu, 1 Feb 2024 10:29:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXSowyRZ37IvxujHfVu/79KPbmCv0C6K3bgEfR7VYVefr6lIEvUwRPWqmE3tLUMHQitbM7 X-Received: by 2002:a05:651c:c9a:b0:2d0:7307:ca2e with SMTP id bz26-20020a05651c0c9a00b002d07307ca2emr3085568ljb.52.1706812161620; Thu, 01 Feb 2024 10:29:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706812161; cv=pass; d=google.com; s=arc-20160816; b=B0JOwKZ9MYmjjQ7Nsjm0u17qDQVWWZHZ0RlbEskdOVBAUlHzL0XUYrcFT1FH0yHoRV bo4XuwBhIIM5z5rK4QaW7pjBa4f0D2p1i0W4+4P4AXBgkHb88w04ki8sVKtR2nvqBTEp QVs+daQFZRJnO/cy7xp0mBSIoRVdOlgyU653cakMGUJp3uAgblHtFYdVuPenPcYOKh4V 9s9XUzPFOf5bJE2N5pU6FgP4rsLdP3eJ9O8WA0tJDd9LV7qPaG81GfsVMjI/gnTPJy92 faTHZ5ohWfvwuyBTHem+Bt8g0k7HeB3PQyKGsn3AdNxSH2/1LjT/D/BPZiQljU9xR3Zm wtWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ptlYUHPBjTorPme5FFETdL+0v5DBis3wWZaw8XLRVOY=; fh=ILdjeTN6Xhysa9Ipa8tCgVwlTvLShf/KURlWF/DQCCU=; b=tDYfiWE9JODflAvI6NyU06mxmmJ7UFWZZA7DH3eydoWKrku30uDi4TrXPD16lFTsoD Dk9+RPYiZPUqdj0prqZTjwpct/xT8rP7JJ1ig9K2r+lA2g7NK9dLe3rMhJul7Pv09idU dJqjuYCDupvrOM2RiTtYP1Z8F7IqCTPCI53hbjkUcHVBG3+34/C+a6zWTIr7GQM5ajq7 ANXc13LeqdFXaDK7uiDmwOQD1suI2hn9aubTjid+M3E6XZOysHJaBajIDRR5nZIP0ZhE 3q598zYApPS60b1MSVMk1YG14yAcs8h85vUlTGoQflG5Dns4X6iUeycb7YAErr1hofFr bbgQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mCrzTO2F; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-48698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48698-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=1; AJvYcCWTGYwQaVG0dFBsMbAxm7smKnkAbRrDpOLIadryvNRKa29tp2bZ5Q2XjnONAUxDhiMe27K6cGstioBn7cyojDO8BKySJcv8eTBz3Ac2bQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cz12-20020a0564021cac00b0055c9c70f91esi53044edb.182.2024.02.01.10.29.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:29:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mCrzTO2F; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-48698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48698-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 31DD51F22D51 for ; Thu, 1 Feb 2024 18:29:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4EB012FB27; Thu, 1 Feb 2024 18:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mCrzTO2F" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6711912FB35; Thu, 1 Feb 2024 18:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706812148; cv=none; b=Os1+U2lsYnYWUN/Nh6V0hPH0ZVMy0934BT8c1hjrNUgiCQlNa9A87nx99Rpeh0hkxsQT2K8QrX9ni1M/4G+rHwVDVQzCjxAXx/GLGDri/v27RIuT1wbyIG3iWxWuJl+lyZ7qUd7lWMptILICsxCvWtg87MheQ4/veu2dykto4Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706812148; c=relaxed/simple; bh=X5ke3Fq30tjNM9uPVjkoXRrXzpI6iMqEb4EhoycEHuA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X2OZ8RfvgcIBoA/trpq/ZWxKzm3lI3fSr3wssBRyTzjEWQVOPnyNamrIRFaBkj6c3XDCihgWjfXWcrOOg+VxUQaaYZj1x1C7dr+AQoxhK3s+E3YPCn8a0FMTrc8GBwH1IRZPiyniIPHFJVuqkwcW5JE8qCc4f7GMkWc5vki/Sy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mCrzTO2F; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706812143; x=1738348143; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=X5ke3Fq30tjNM9uPVjkoXRrXzpI6iMqEb4EhoycEHuA=; b=mCrzTO2FAyEEHsm7G3lEMAHZd+fql9V7l0jwr0gEA+BNARos/Ak/cnQK Svf4RMVZNSehesiz214UF1bgIhEtPWXbfj242z3EBUrWmHBlGoba5VnU6 9zaS7cP1Jt6/y8e/tvxG+0xrN3YBNrIrfsIFWJlXNjoo5bQpYS90ycPhd EK9TADtMrz/td1KwYNQpPDRCCwxZynEXllv1AiJkUFeKE0vkK3lQ897vT eFk+PBQ8odaVTO4vTXkTGNxPG9QkMdRiKTa864iNeP7DGH3f+bJct7JOc rVdTacadDXHiGWuiEPcE1xLmyw6RsnuYu6BErjaSFBe6N+mlL1nWhtkrw Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="25432184" X-IronPort-AV: E=Sophos;i="6.05,235,1701158400"; d="scan'208";a="25432184" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 10:29:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,235,1701158400"; d="scan'208";a="84318" Received: from arbartma-mobl.amr.corp.intel.com (HELO [10.212.155.10]) ([10.212.155.10]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 10:29:02 -0800 Message-ID: <2b5e6d68-007e-48bd-be61-9a354be2ccbf@intel.com> Date: Thu, 1 Feb 2024 10:29:00 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or TME Content-Language: en-US To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Zixi Chen , Adam Dunlap , "Kirill A . Shutemov" , Xiaoyao Li , Kai Huang , Dave Hansen , Thomas Gleixner , Ingo Molnar , x86@kernel.org, stable@vger.kernel.org References: <20240131230902.1867092-1-pbonzini@redhat.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240131230902.1867092-1-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/31/24 15:09, Paolo Bonzini wrote: > However, as noticed by Kirill, the patch I sent as v1 actually works only > until Linux 6.6. In Linux 6.7, commit fbf6449f84bf ("x86/sev-es: Set > x86_virt_bits to the correct value straight away, instead of a two-phase > approach") reorganized the initialization of c->x86_phys_bits in a way > that broke the patch. But even in 6.7 AMD processors, which did try to > reduce it in this_cpu->c_early_init(c), had their x86_phys_bits value > overwritten by get_cpu_address_sizes(), so that early_identify_cpu() > left the wrong value in x86_phys_bits. This probably went unnoticed > because on AMD processors you need not apply the reduced MAXPHYADDR to > MTRR masks. I really wanted get_cpu_address_sizes() to be the one and only spot where c->x86_phys_bits is established. That way, we don't get a bunch of code all of the place tweaking it and fighting for who "wins". We're not there yet, but the approach in this patch moves it back in the wrong direction because it permits the random tweaking of c->x86_phys_bits. Could we instead do something more like the (completely untested) attached patch? BTW, I'm pretty sure the WARN_ON() in the patch won't actually work, but it'd be nice to work toward a point when it does.