Received-SPF: pass (google.com: domain of linux-kernel+bounces-48711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 1 Feb 2024 10:36:37 -0800
From: Ashok Raj <ashok.raj@intel.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>
CC: Mike Rapoport <rppt@kernel.org>, Linus Torvalds
	<torvalds@linux-foundation.org>, LKML Mailing List
	<linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@intel.com>, "Ingo
 Molnar" <mingo@kernel.org>, Song Shuai <songshuaishuai@tinylab.org>, "Ashok
 Raj" <ashok.raj@intel.com>
Subject: Re: [REGRESSION] Platforms supporting SGX fail to kexec due to
 96c6b8f212a ("memblock: report failures when memblock_can_resize is not
 set")
Message-ID: <ZbvktYF7Oi53qpjx@a4bf019067fa.jf.intel.com>
References: <ZY4T7YxrJZCxhMxx@a4bf019067fa.jf.intel.com>
 <ZZEXnl3w0K6avYR3@kernel.org>
 <07f1cb33-e908-48cb-85f9-83a040b2ca5a@leemhuis.info>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <07f1cb33-e908-48cb-85f9-83a040b2ca5a@leemhuis.info>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WyzRNQVVhnZoCSK6eC/C19UkYi2wzmq0BUVxtsAkJmjh7ptVINdTV28pNedx?=
 =?us-ascii?Q?ZDsSoo6cUwfCVeAcgjJANiQriAXuHeFQO6yGQ0cA8SB2d7ecdjAz0Ftg8bti?=
 =?us-ascii?Q?O7ztFP8ISbcwNDds304S6dkHAt4njBkqncNgXwh4yVG+JUgYf8musle/FjO9?=
 =?us-ascii?Q?UlhkXCjQZarYnKX4tTjoGesNPUfQzXQdbvTjGGSodFAq2v4BIBqI9msiiJQr?=
 =?us-ascii?Q?Vy/SBTrONBm3fWawBw4deCQLh0dKD6pcKIT8/4QMmXYVAebn/p/J6OfzSHqy?=
 =?us-ascii?Q?l+ffXSu+jEYxagNaQNlZNJPk32ytNYYgzHSI+52E7k8h0yv2C4AiHsySPhWs?=
 =?us-ascii?Q?51q+BXJswOhz6MQSVm+LxEpCjutQIeSBshNh5fUIt7zxoo374dKCvBmVUU23?=
 =?us-ascii?Q?OvOcL7MHn3K9VPY23UXkMaZrW5DH2dbuCeuvi6tHJYqN5K7VN4sPt2cCz60O?=
 =?us-ascii?Q?VSvm0zWEm755JpJUUe4MMAhS83gab0ZTynsjBXi7TQ5RJDJAnKgk2ABVXyo1?=
 =?us-ascii?Q?KDfUoM70i70cvoeWaRgqFlzWRJQ7INEgC0aoFnXnm8du+sLHQJqK+oH+VEtN?=
 =?us-ascii?Q?B2SGJuz/SQdJaIAfuNEHWF3QjOJOmHtUfqNKMHpPVcBBL3ddeuA26lQeHMgR?=
 =?us-ascii?Q?lQqw5GOXAQrAdq/nwtmC1JGbkyqpAXrRdZKdgiiD3LOM0WmrZ9htiYa7YOGM?=
 =?us-ascii?Q?fEvC7wkvoaaO3Ltz4bgCtSuPeeZ7TXn/DbemqZvOVrGytba5utfwuaD+vA2P?=
 =?us-ascii?Q?EAcbV2epIQA/OC75GPcT46rXWBRvkxm0azKShOfNKRgbcuydf9uO5oNRL4AO?=
 =?us-ascii?Q?JKp3vxuLUYQe1s8rxQYriqAmDTwwvS2lafWWIc8flU93tkvijeExuCXnLfWN?=
 =?us-ascii?Q?VKYelolJCgktcQXUAj4UYeNWy6wBGL99xkyrpKOZVsCGc9riSwPEvm2X1Vg7?=
 =?us-ascii?Q?CtCZyQTf29/TZM8gzLLpSG2H/ePp1Scq3Pg1BYhLWz9xyctqfTTo6KMOaC2k?=
 =?us-ascii?Q?L7HUwYCKGGC3wK5JSoNN3F6vckRndJGhWjifjnZfVEipYGajqN29YZ6Wi2wS?=
 =?us-ascii?Q?rVleEnBW0SfkcNviTrmXC0FaTlDo2or9IlPIowINf7sLDiJoRk4EJ5qXRMfQ?=
 =?us-ascii?Q?L1YjMhNMjiwYnv26IGGHHkRwm/bp16AVmvXozRFokVul8pZnZ1Jante2CM5P?=
 =?us-ascii?Q?Jli/22e6Lmli4Vz4sdcFkM3NjXp6aR+PwuM9YjYWJkM6vMZLMQvCY9vlqCkw?=
 =?us-ascii?Q?xHsE3hkv6ULx0e71PCaInuhvQSr4z6HpI6IdHdWdAuPcCMi56XCJlDvrNAci?=
 =?us-ascii?Q?rRANUmaAFHNeCoHjxchCRmSEONzzUTiMrLS9JiKuk8H8mX4s0pYsgOIKe6JE?=
 =?us-ascii?Q?lAMnwkplCGWBD9rRGJlx3MiWhJzIS/UMY8U0j8Ib2yeTG1bj7PFOS1yAOlyt?=
 =?us-ascii?Q?kWuXgxnW0Wzrh2Koq05tE63WSCQhRUmY5acrtT/uZdMWpOa1paImE5YPsysP?=
 =?us-ascii?Q?xgO1E47HoMR0yfm8GWfUxVXiyKoEkON07fZ7ifW5wrqbRxqmz1V4dryJUeIu?=
 =?us-ascii?Q?GkW30P/BF8qf5CLPHEAr4ru4foO4e9+lX9md939FHaJ5j/hv5kY0MLWfaD8o?=
 =?us-ascii?Q?FQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff1245a-5be1-4fdf-727c-08dc2354bb7f
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 18:36:41.2604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 32f8PoAtVnk23aPyt/AtQ35NLkY/I/z2F8jKTaRZO6WbpImVRKoZY4RdUu8FuIMcGQS4xWCq8iXs83QIuuPRaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8009
X-OriginatorOrg: intel.com

Hi Mike,

On Thu, Feb 01, 2024 at 11:38:38AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 31.12.23 08:26, Mike Rapoport wrote:
> > On Thu, Dec 28, 2023 at 04:33:49PM -0800, Ashok Raj wrote:
> >> 96c6b8f212a ("memblock: report failures when memblock_can_resize is not set")
> >>
> >> Causes kexec failure. Backing out this change, kexec succeeds. Symptom is
> >> it appears to hang, possibly hung at the panic. Although I have the
> >> earlyprintk enabled, I don't see any console messages when new kernel
> >> boots. 
> >>
> >> Also tested turning off CONFIG_X86_SGX, the kernel with this commit
> >> included also kexec's fine.
> >>
> >> Booting from warm/cold reset has no issues. Only kexec to new kernel with
> >> this change included and CONFIG_X86_SGX=y causes the kexec failure.
> > 
> > Can you add memblock=debug to the kernel command line and send logs for
> > normal boot and kexec with CONFIG_X86_SGX=y and e96c6b8f212a reverted?
> 
> Ashok, you afaics never replied. Did you forget about it? Or was the
> issue resolved later or never a regression in the first place? I for now
> assume it's one of the latter and stop tracking this:

Sorry I went AWOL on this.. I did try the newer kernel's (6.8-rc1) and its not
happening any more, and kexec seems to work well. 

On the same problem kernel adding memblock=debug make it dissappear, and
even adding some code to that suspect area changed behavior.

I'm not able to reproduce it again. Sorry for the delay.

Cheers,
Ashok