Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp366949rdb; Thu, 1 Feb 2024 10:39:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfTC95zu4qv3N4UataxCxqlDtyXUAsqbTWEpw9ZWWOMc9o64ZAajv5OgfKK5HBpX4c9oyS X-Received: by 2002:a17:902:da87:b0:1d7:c27:2d32 with SMTP id j7-20020a170902da8700b001d70c272d32mr4202160plx.12.1706812785454; Thu, 01 Feb 2024 10:39:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706812785; cv=pass; d=google.com; s=arc-20160816; b=InkleATJCbjEhlnciWhUxWDcyiagG397loEu8vUzoea+LDiun4joY8dn90f039EL+F /w5KvURNnhBCGvVdjvFph/hUEdTAVDz+euxs+pYjEAFWfsWHLJ47gw8grbNvG/DXDXVz yZwlO1Xod2umgyGQuKiJaAot8xrH0joJIfLJtwiiZBsc6cly4pYdqpyhNoEwtcKnzpYT 8moZtsfi1VS6jxUp5aDyJy1fxaja7zzeFD+2Tj8/+QSMm1Bxo8bULteNvw2C1g/UOHlV HzgeICJbpf5ctXDQ2jFRcr9ZDQHZElsiy05OXNGKdHiXaUA5vDtanMXvHGP51MkP6Oru v6PA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=0M7HdB/Ln7k5cmlXcTGUtiNuQylG7V6KZfKoZDxv6bw=; fh=RV6dOfBAIc83hWrHW1zDXrWeOEWOmCdrbcFmxJWNQww=; b=mmDTJ0zHzJPDR1NgG5K5nSJ6K6GQmuOgi+Uqe5kAUvSpX8FiNO337Iwg2pjntdrylp H0pL9J1r+2V9bwh7cDgUR+y4zHrbdSrBk0CyqtKXdEddi4ouMHLi8NNeywJM4NXSE7N5 +shLLZatH/Vhac79t1whlRaW9vPttesKYqyORK3TRF2lI6vdRNPwp4kiPg/m7D0RYGUX KluwcFbhg3QNAq0f7B3xYsC8MS/Z26W1/545t22aaZOmvNMj5XqfYUxbN4PYfPPjRX0A DIugeVuj2BuaUMEsAFsDTb3jYh71M9BTz6ex0kF64R2JjVK0IxdIXH68bpYcofQ+kbPk B3Tg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dhrGiisU; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-48663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48663-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=1; AJvYcCUQEwWVO70WI3tWP3Qhs1KVY2rJ4sWxs/bespn+CSnK+rfqxsHwZ1cMIwlRGLJ0ONJXKYwd0uDnocfnM7A5RpikS6fA/pDI3tUBWtJCzg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y2-20020a17090322c200b001d6f5cd088fsi253333plg.288.2024.02.01.10.39.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:39:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dhrGiisU; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-48663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48663-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A8119B27994 for ; Thu, 1 Feb 2024 18:11:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3DFA812E1F1; Thu, 1 Feb 2024 18:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dhrGiisU" Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E651612D168 for ; Thu, 1 Feb 2024 18:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810840; cv=none; b=AHg5+OhDtmIi1PX6axbeNYFHb5AlTSqn2hcG0tYV1fsTiAsNX7HdUhumcP26kt7NAQ3rYtcDlKGRhprv1GWv6Z8xCP8rOegaaMGICik/OUQHKgvXnV84SR6dTyYs/vXYhntr+P/WBFt/mZqZodgoOcXtkoSmwPDYPUXs6QWMcwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810840; c=relaxed/simple; bh=T86R8HpV7zXDhFND8oowyz9LtpNq2PuQYU95ptdb7h4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=O82TbouFsLCEDJsN3rNbYWPVPpq078TgrXhQGJ//mwdKy88epAiZikrUwDH4jzsXZxVHskOLXS5Y2fXX6nS17GIaYK+zMg4q8RMffclJOOFDa6WZEEI20kPzf+qCR0adwkXuaJ1A7SyeQ3paOAIkH3RjI0zVajeaAsZFCZjY4OU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dhrGiisU; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5ce942efda5so1062426a12.2 for ; Thu, 01 Feb 2024 10:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706810837; x=1707415637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0M7HdB/Ln7k5cmlXcTGUtiNuQylG7V6KZfKoZDxv6bw=; b=dhrGiisUhwadhWWe/IhUv+PQnT3WwpPe5xs2bK/x89Omzjn422liXPn41lYGp73EhX qSYfNEUcNBNYaeCXMFdwQ1ymt5pvhWAe4KJ5gDK/Jy7azgbxIj095YKUGn5EKyAvANmO Qw/UyjuK/OEjVyG/Mth5L0ECmDUbgto4MZqQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706810837; x=1707415637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0M7HdB/Ln7k5cmlXcTGUtiNuQylG7V6KZfKoZDxv6bw=; b=w53xhW+TEqjcPZpDDaWsTQQZYkJvn4Ei6nC6r2kFl3FeABoircqPjXcqGhlfZu3YcS PpuPCYz9weulpQVauo1OdAKLhRua7w/jpUQNnQPYh1yIYJUNlmFlj4ciK7KLA/vJXEnw ku7JBdzg69AOKD8vhyw/4WfYrVaxa3uUdQinldYc23Uu1lyCnr6jII46uOWwTJxkjsw9 jiuyAMfNf0PlVRJv1y7JE4YuQgMCs594/Py3+kxxSYAOz3NV8Q0CtcOnHhPaYIeXwXza an9424mXIsXtg2W0hdADv1EXuLr6xA/+OIGKezADlnZHRGw8hwkcbo9jiEdPTqWeL1vk aelg== X-Gm-Message-State: AOJu0Yz63F2PS/YNHhx2WNJkV007Qto9Qd3vC+QBDjQDcrGuTnuQZopV RjmaqU4Uig7g5wS+2V/7wn76gUMc1AgD1drFPAA1d8mpwufnVdGi2xejUAsuog== X-Received: by 2002:a05:6a20:2a0f:b0:19e:30b0:6ad4 with SMTP id e15-20020a056a202a0f00b0019e30b06ad4mr2993716pzh.55.1706810837327; Thu, 01 Feb 2024 10:07:17 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVJbAZjXQp86ijsd6GO7kukUS8GlA8+ilpBR2ZFQjKnYO3qfd2ORGJpiLlI8DkOGs/iziWlI+OtxFUCZlrTelSfulEVpQKRDvnjBwu+cF/gsrZ7/xb6/oMzs5Ei9sjltpWK5JrmhSUQ0E0uiDJBNdjJOl7XDYxRriY0u8IhE7lcH/YqgMtJN03est7wBrz8WozfgujI00xFJTdYE+ADgdnL5dRk2V3dyapAO4iJEhbc8d4JUJl4sUThfD6fua+p0pi0pIA89QEjah1n1fX2dMm1jGzkmYWIE8CyY4E/pMoV1xGUagwITwL3Jyj24wnMSUg4OytQXgtd2wAoIg7S3Bu5toJ81NcgHY1czpWerYDbrsossXSKtSQFdTxkk1YBiLOJ0mwJEmcNz+ezCpGlUH5FBuTVfQ== Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d11-20020a63d64b000000b005c661a432d7sm94693pgj.75.2024.02.01.10.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 10:07:16 -0800 (PST) From: Kees Cook To: linux-hardening@vger.kernel.org, error27@gmail.com, gustavoars@kernel.org, Bryan Tan , Vishnu Dasa , VMware PV-Drivers Reviewers , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Harshit Mogalapalli Cc: Kees Cook , vegard.nossum@oracle.com, darren.kenny@oracle.com Subject: Re: [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc() Date: Thu, 1 Feb 2024 10:06:58 -0800 Message-Id: <170681081625.3764000.6431595387488802492.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240105164001.2129796-1-harshit.m.mogalapalli@oracle.com> References: <20240105164001.2129796-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 05 Jan 2024 08:39:59 -0800, Harshit Mogalapalli wrote: > Use struct_size() instead of open coding. > > Applied to for-next/hardening, thanks! [1/2] VMCI: Use struct_size() in kmalloc() https://git.kernel.org/kees/c/e03d4910e6e4 [2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() https://git.kernel.org/kees/c/19b070fefd0d Take care, -- Kees Cook