Received-SPF: pass (google.com: domain of linux-kernel+bounces-48733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 1 Feb 2024 18:53:02 +0000
From: Conor Dooley <conor@kernel.org>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: power: reset: Document ti,sci-reboot
 compatible
Message-ID: <20240201-ambiguous-swan-a927ae8f126f@spud>
References: <20240131221957.213717-1-afd@ti.com>
 <20240131221957.213717-2-afd@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qZaAzCjNUu3le7WH"
Content-Disposition: inline
In-Reply-To: <20240131221957.213717-2-afd@ti.com>


--qZaAzCjNUu3le7WH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 04:19:46PM -0600, Andrew Davis wrote:
> This calls into the system firmware using TI-SCI to reboot the system.
> Used as a fallback when PSCI is unable or not available to reboot
> the system.
>=20
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../bindings/power/reset/ti,sci-reboot.yaml   | 33 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/reset/ti,sci-=
reboot.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/power/reset/ti,sci-reboot.=
yaml b/Documentation/devicetree/bindings/power/reset/ti,sci-reboot.yaml
> new file mode 100644
> index 0000000000000..aa628be33d122
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/ti,sci-reboot.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/ti,sci-reboot.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI-SCI reboot controller
> +
> +maintainers:
> +  - Andrew Davis <afd@ti.com>
> +
> +description: |
> +  Some TI SoCs contain a system controller (like the Power Management Mi=
cro
> +  Controller (PMMC) on Keystone 66AK2G SoC) that are responsible for con=
trolling
> +  the state of the various hardware modules present on the SoC. Communic=
ation
> +  between the host processor running an OS and the system controller hap=
pens
> +  through a protocol called TI System Control Interface (TI-SCI protocol=
).
> +
> +  This reboot controller node uses the TI SCI protocol to perform a devi=
ce reboot.
> +
> +  Must be a child node of the associated TI-SCI system controller node.
> +
> +properties:
> +  compatible:
> +    const: ti,sci-reboot
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    k3_reboot: reboot-controller {
> +        compatible =3D "ti,sci-reboot";
> +    };

I'd drop the example since this has no use standalone and just rely on
the one in the parent. Otherwise I think this is fine.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

--qZaAzCjNUu3le7WH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbvojgAKCRB4tDGHoIJi
0lQjAQD9jRgISimwK5XXqRkIOSmfbFMop/J2bMV+Hq0W/jsK4wD/V+Mx0ZYHEweK
6yVr+pLxeofwsOmv/jSXGp+DcgHJiAo=
=8HJw
-----END PGP SIGNATURE-----

--qZaAzCjNUu3le7WH--