Received-SPF: pass (google.com: domain of linux-kernel+bounces-48750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240130-rk-dts-additions-v2-0-c6222c4c78df@gmail.com>
 <20240130-rk-dts-additions-v2-2-c6222c4c78df@gmail.com> <CAGb2v65--rgb2FqmG_0-w1-jUL0odqKXxiZJ-XPYA4uomfYmaQ@mail.gmail.com>
 <5e3e12d65e4919372e7fb02d56202393@manjaro.org>
In-Reply-To: <5e3e12d65e4919372e7fb02d56202393@manjaro.org>
From: Alexey Charkov <alchark@gmail.com>
Date: Thu, 1 Feb 2024 23:15:28 +0400
Message-ID: <CABjd4Yx0kQ67fScrFVavjObMLaNt_PJ3TVOhLpCmj00Dx9dOqA@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] arm64: dts: rockchip: enable temperature driven
 fan control on Rock 5B
To: Dragan Simic <dsimic@manjaro.org>
Cc: wens@kernel.org, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Heiko Stuebner <heiko@sntech.de>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Viresh Kumar <viresh.kumar@linaro.org>, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 1, 2024 at 9:34=E2=80=AFPM Dragan Simic <dsimic@manjaro.org> wr=
ote:
>
> Hello Chen-Yu,
>
> On 2024-02-01 15:26, Chen-Yu Tsai wrote:
> > On Wed, Jan 31, 2024 at 2:22=E2=80=AFAM Alexey Charkov <alchark@gmail.c=
om>
> > wrote:
> >>
> >> This enables thermal monitoring on Radxa Rock 5B and links the PWM
> >> fan as an active cooling device managed automatically by the thermal
> >> subsystem, with a target SoC temperature of 65C and a minimum-spin
> >> interval from 55C to 65C to ensure airflow when the system gets warm
> >>
> >> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> >> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> >> ---
> >>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 34
> >> ++++++++++++++++++++++++-
> >>  1 file changed, 33 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> >> b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> >> index a0e303c3a1dc..b485edeef876 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> >> @@ -52,7 +52,7 @@ led_rgb_b {
> >>
> >>         fan: pwm-fan {
> >>                 compatible =3D "pwm-fan";
> >> -               cooling-levels =3D <0 95 145 195 255>;
> >> +               cooling-levels =3D <0 120 150 180 210 240 255>;
> >>                 fan-supply =3D <&vcc5v0_sys>;
> >>                 pwms =3D <&pwm1 0 50000 0>;
> >>                 #cooling-cells =3D <2>;
> >> @@ -173,6 +173,34 @@ &cpu_l3 {
> >>         cpu-supply =3D <&vdd_cpu_lit_s0>;
> >>  };
> >>
> >> +&package_thermal {
> >> +       polling-delay =3D <1000>;
> >> +
> >> +       trips {
> >> +               package_fan0: package-fan0 {
> >> +                       temperature =3D <55000>;
> >> +                       hysteresis =3D <2000>;
> >> +                       type =3D "active";
> >> +               };
> >> +               package_fan1: package-fan1 {
> >> +                       temperature =3D <65000>;
> >> +                       hysteresis =3D <2000>;
> >> +                       type =3D "active";
> >> +               };
> >> +       };
> >> +
> >> +       cooling-maps {
> >> +               map0 {
> >> +                       trip =3D <&package_fan0>;
> >> +                       cooling-device =3D <&fan THERMAL_NO_LIMIT 1>;
> >> +               };
> >> +               map1 {
> >> +                       trip =3D <&package_fan1>;
> >> +                       cooling-device =3D <&fan 1 THERMAL_NO_LIMIT>;
> >> +               };
> >> +       };
> >> +};
> >> +
> >>  &i2c0 {
> >>         pinctrl-names =3D "default";
> >>         pinctrl-0 =3D <&i2c0m2_xfer>;
> >> @@ -731,6 +759,10 @@ regulator-state-mem {
> >>         };
> >>  };
> >>
> >> +&tsadc {
> >> +       status =3D "okay";
> >> +};
> >> +
> >
> > Is there any reason this can't be enabled by default in the .dtsi file?
> > The thermal sensor doesn't depend on anything external, so there should
> > be no reason to push this down to the board level.
>
> Actually, there is a reason.  Different boards can handle the critical
> overheating differently, by letting the CRU or the PMIC handle it.  This
> was also the case for the RK3399.
>
> Please, have a look at the following DT properties, which are consumed
> by drivers/thermal/rockchip_thermal.c:
>    - "rockchip,hw-tshut-mode"
>    - "rockchip,hw-tshut-polarity"
>
> See also page 1,372 of the RK3588 TRM v1.0.
>
> This has also reminded me to check how is the Rock 5B actually wired,
> just to make sure.  We actually need to provide the two DT properties
> listed above, at least to avoid emitting the warnings.

Well the defaults are already provided in rk3588s.dtsi, so there won't
be any warnings (see lines 2222-2223 in Linus' master version), and
according to the vendor kernel those are also what Rock 5B uses.

This made me think however: what if a board doesn't enable TSADC, but
has OPPs in place for higher voltage and frequency states? There won't
be any throttling (as there won't be any thermal monitoring) and there
might not be a critical shutdown at all if it heats up - possibly even
causing hardware damage. In this case it seems that having TSADC
enabled by default would at least trigger passive cooling, hopefully
avoiding the critical shutdown altogether and making those properties
irrelevant in 99% cases.

Best regards,
Alexey