Received-SPF: pass (google.com: domain of linux-kernel+bounces-48324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 1 Feb 2024 16:34:30 +0200 (EET)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: "Hegde, Suma" <Suma.Hegde@amd.com>, naveenkrishna.chatradhi@amd.com, 
    LKML <linux-kernel@vger.kernel.org>, Carlos Bilbao <carlos.bilbao@amd.com>, 
    Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86/amd/hsmp: switch to use
 device_add_groups()
In-Reply-To: <2024020144-duplicity-nuptials-1cd7@gregkh>
Message-ID: <f48ebcb1-8f87-efee-08ed-844775c995aa@linux.intel.com>
References: <2024012822-exalted-fidgeting-f180@gregkh> <0d110d2a-da0c-017a-0e5a-fc6bef7b066a@linux.intel.com> <e73426f6-6d50-4ed7-8613-1ec42fa3f991@amd.com> <2024020144-duplicity-nuptials-1cd7@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-462016549-1706798070=:1028"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-462016549-1706798070=:1028
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 1 Feb 2024, Greg Kroah-Hartman wrote:

> On Thu, Feb 01, 2024 at 06:50:33PM +0530, Hegde, Suma wrote:
> > On 1/29/2024 6:16 PM, Ilpo J=E4rvinen wrote:
> > > Caution: This message originated from an External Source. Use proper =
caution when opening attachments, clicking links, or responding.
> > >=20
> > >=20
> > > + Cc Suma Hegde.
> > >=20
> > > On Sun, 28 Jan 2024, Greg Kroah-Hartman wrote:
> > >=20
> > > > The use of devm_*() functions works properly for when the device
> > > > structure itself is dynamic, but the hsmp driver is attempting to h=
ave a
> > > > local, static, struct device and then calls devm_() functions attac=
hing
> > > > memory to the device that will never be freed.
> > > >=20
> > > > The logic of having a static struct device is almost never a wise
> > > > choice, but for now, just remove the use of devm_device_add_groups(=
) in
> > > > this driver as it obviously is not needed.
> >=20
> > Hi Greg,
> >=20
> > Could you please hold on merging this patch for a week? I will push a p=
atch
> > for converting platform specific structure's memory allocation from sta=
tic
> > to a dynamic
> >=20
> > allocation.
>=20
> Push it where?  Ususally we do "first patch wins" type stuff, why not
> just do your work on top of mine?
>=20
> Also, when you do make the needed changes, please remove the explicit
> call to create sysfs groups and use the default groups pointer instead,
> that will make things much simpler and avoid races in the code.

Hi Greg,

Well, if you really want to "win" :-), please provide an updated version=20
which considers the changes already made in the for-next branch (the=20
current one won't apply).

--=20
 i.

--8323328-462016549-1706798070=:1028--