Received-SPF: pass (google.com: domain of linux-kernel+bounces-48775-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 1 Feb 2024 14:34:34 -0500
From: Frank Li <Frank.li@nxp.com>
To: lpieralisi@kernel.org
Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org,
	festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
	imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v9 00/16] PCI: imx6: Clean up and add imx95 pci support
Message-ID: <ZbvySvCoeNbBxYjW@lizhi-Precision-Tower-5810>
References: <20240119171122.3057511-1-Frank.Li@nxp.com>
 <ZbJ+tFPn3aOYHCwf@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZbJ+tFPn3aOYHCwf@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Mtu1h8UfM8moQ0VznFEr2luoPGF7ewG4/3iXH10q/ol2YrxlY+OyZtovflzW?=
 =?us-ascii?Q?ozn6hdBovtLk9odqoRub9gU12NK2IvWXb8XRRH9MXqSfbbdZSHX3FbPLemEP?=
 =?us-ascii?Q?f5DbCDCx228MZeA7JChLu9Z0m7p/9oUb2O0OffMKMKFsDzEvzca/hn6QjXG9?=
 =?us-ascii?Q?UIIll23saton3a5SNLLT9EiHjteQhTMDZuVNjvRaadx51ieMXlYSASlCMSkf?=
 =?us-ascii?Q?JbZdoK8GdZqOyw3/e2XQNwtAZPHVawHP824PKyxUjbZcXgeTBqNTkXBBF2t9?=
 =?us-ascii?Q?TQqRJXqBFnbPme6sMygNAqpZhBljCuMQ6t6f8fTWaRmsqOdYt3HGbB9FE48K?=
 =?us-ascii?Q?zfPumSvNbF9uQavVnyD3lGVDsdAh7xZAX1h84qStdMAJBM/BQdrJM92YR2x2?=
 =?us-ascii?Q?pZEpkLqgV2IzFLiw2n6ijAAFV6/NntnSgOwjLv1iKSN4U4SQDo2oYlxIc7/B?=
 =?us-ascii?Q?y2oJhcKuwKW2D97oIQUJ7ihz1WbqU85/aZNEe90cedN4kyPph1bgRR7l5nR7?=
 =?us-ascii?Q?Dp/LxEij+4wbZbSGOduuOZb6mhCFG/faJ9qd3bxFNgot+f8RE7kpwhhjCBdU?=
 =?us-ascii?Q?BX0onx9bEcJ0p/6Tq1FFDE6iXdPLbrAdt2RDrG1q/EeCAEbENdMcHy9iLAnj?=
 =?us-ascii?Q?Bkiw8iQPqYhGPxi/wUWKxqH1tiwFfhlEsL/dXELiDzrlDV6xXp66sgqQDfp/?=
 =?us-ascii?Q?fna3CAonHFU0l0/WQIy8EWc1t6UT3PjLIzxLOzoyBC2G6ydBeTGaIwsK2zHu?=
 =?us-ascii?Q?NgYPfOlMd30gRCBFO3lRe3sE+wl60fYFFC3Wt0MBNxf+zAodzSWUMhjzEaSb?=
 =?us-ascii?Q?wLKQ/4lWGcId8GzrNjAg78wHfQBBbmWdcJwRqab0dKCAjf3sDdxp3Be83CEF?=
 =?us-ascii?Q?ujhANpR+tBYcJ75ISMm5Tk73x9U/hmDONgMahquRrUxN+GeQWqGfGlIDmqgh?=
 =?us-ascii?Q?1exnV6Oh1a9wroNG5rPX8shgdSxHr273irudIsQa4ay89m8LCV75w08F87WO?=
 =?us-ascii?Q?LuVoHi6/4aODyNH3YT5nhUHIltyLyAXzIKbl8muTaR68dJxVgmn0aFLyqXD9?=
 =?us-ascii?Q?VFt2TCdSJEGNOYWnPw0+s8fjZEK4Qlo4olbAy41ffGDLXZU+A4kGd9QOJvIg?=
 =?us-ascii?Q?QRO8QSBzpexUdS38OGUFLpWHQR8/Lo/JMyX3CJrIVvKPcCH/IPJCagZaiQmE?=
 =?us-ascii?Q?YZEFX2R0Yama+1eV5OOf8LFR8UpPck76ZA1EofPOMFo1qWW2kZhT8cWRqkXF?=
 =?us-ascii?Q?dNNxZqHFHwkfjV2dSispukDhu5NkXuWqelt5rguprR2brVMrWUWwOM9fbrHk?=
 =?us-ascii?Q?EOMbq37vnvvlavjypHVSQ5dXV+a99VOa3sJPLyq3MmqmoymTTYOnEQnezAvl?=
 =?us-ascii?Q?db7Gvw1kRulGAeDsDvRct5hVEGt1DZBdKXpB+Toeb/X9E0THPDC9CSd5Lwdv?=
 =?us-ascii?Q?09IYP1fhQDTcLXRXy/rZABBJRjyzgK9Vnhz5f3UjAaNJis/pcz7KFuGlPtN0?=
 =?us-ascii?Q?5oKTcVCfKBucVi1BD0Rp+TeYq0GmbaI4jh8P5APr1Z0DFmS5BfM/KxxNdl01?=
 =?us-ascii?Q?2TPd9+QHUiwZnFSqkso=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f20d67b7-d0cd-47f2-47cb-08dc235cd7a4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 19:34:44.3413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PeMTILa/WjMGeC98K+Ho+qPc63lpArOYQNIkdtLaVRX0ftcFhB9OsGpCKobA0nhk/Cs5tMZG9/eiKsy9Kf1U2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7748

On Thu, Jan 25, 2024 at 10:31:00AM -0500, Frank Li wrote:
> On Fri, Jan 19, 2024 at 12:11:06PM -0500, Frank Li wrote:
> > first 6 patches use drvdata: flags to simplify some switch-case code.
> > Improve maintaince and easy to read code.
> 
> @lpieralisi:
> 
> 	Could you please pick up these patches? All already reviewed by
> Mani. dt-binding part acked by rob/krzysztof. Add it only impact freecale
> imx platform.
> 
> Frank

@lpieralisi@kernel.org

Ping!

Frank

> 
> > 
> > Then add imx95 basic pci host function.
> > 
> > follow two patch do endpoint code clean up.
> > Then add imx95 basic endpont function.
> > 
> > Compared with v2, added EP function support and some fixes,  please change
> > notes at each patches.
> > 
> > dt-binding pass pcie node:
> > 
> > pcie0: pcie@4c300000 {
> >                         compatible = "fsl,imx95-pcie";
> >                         reg = <0 0x4c300000 0 0x40000>,
> >                                 <0 0x4c360000 0 0x10000>,
> >                                 <0 0x4c340000 0 0x20000>,
> >                                 <0 0x60100000 0 0xfe00000>;
> >                         reg-names = "dbi", "atu", "app", "config";
> >                         #address-cells = <3>;
> >                         #size-cells = <2>;
> >                         device_type = "pci";
> >                         linux,pci-domain = <0>;
> >                         bus-range = <0x00 0xff>;
> >                         ranges = <0x81000000 0x0 0x00000000 0x0 0x6ff00000 0 0x00100000>,
> >                                  <0x82000000 0x0 0x10000000 0x9 0x10000000 0 0x10000000>;
> >                         num-lanes = <1>;
> >                         num-viewport = <8>;
> >                         interrupts = <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>;
> >                         interrupt-names = "msi";
> >                         #interrupt-cells = <1>;
> >                         interrupt-map-mask = <0 0 0 0x7>;
> >                         interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
> >                                         <0 0 0 2 &gic 0 0 GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>,
> >                                         <0 0 0 3 &gic 0 0 GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
> >                                         <0 0 0 4 &gic 0 0 GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
> >                         fsl,max-link-speed = <3>;
> >                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> >                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
> >                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> >                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
> >                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> >                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
> >                         assigned-clock-parents = <0>, <0>,
> >                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
> >                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
> >                         /* 0x30~0x37 stream id for pci0 */
> >                         /*
> >                          * iommu-map = <0x000 &apps_smmu 0x30 0x1>,
> >                          * <0x100 &apps_smmu 0x31 0x1>;
> >                          */
> >                         status = "disabled";
> >                 };
> > 
> > pcie1: pcie-ep@4c380000 {
> >                         compatible = "fsl,imx95-pcie-ep";
> >                         reg = <0 0x4c380000 0 0x20000>,
> >                               <0 0x4c3e0000 0 0x1000>,
> >                               <0 0x4c3a0000 0 0x1000>,
> >                               <0 0x4c3c0000 0 0x10000>,
> >                               <0 0x4c3f0000 0 0x10000>,
> >                               <0xa 0 1 0>;
> >                         reg-names = "dbi", "atu", "dbi2", "app", "dma", "addr_space";
> >                         interrupts = <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> >                         interrupt-names = "dma";
> >                         fsl,max-link-speed = <3>;
> >                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> >                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> >                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
> >                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> >                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
> >                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> >                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
> >                         assigned-clock-parents = <0>, <0>,
> >                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
> >                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
> >                         status = "disabled";
> >                 };
> > 
> > Frank Li (15):
> >   PCI: imx6: Simplify clock handling by using clk_bulk*() function
> >   PCI: imx6: Simplify phy handling by using IMX6_PCIE_FLAG_HAS_PHYDRV
> >   PCI: imx6: Simplify reset handling by using by using
> >     *_FLAG_HAS_*_RESET
> >   dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
> >   PCI: imx6: Using "linux,pci-domain" as slot ID
> >   PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask
> >   PCI: imx6: Simplify configure_type() by using mode_off and mode_mask
> >   PCI: imx6: Simplify switch-case logic by involve init_phy callback
> >   dt-bindings: imx6q-pcie: Clean up irrationality clocks check
> >   dt-bindings: imx6q-pcie: Restruct reg and reg-name
> >   PCI: imx6: Add iMX95 PCIe Root Complex support
> >   PCI: imx6: Clean up get addr_space code
> >   PCI: imx6: Add epc_features in imx6_pcie_drvdata
> >   dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string
> >   PCI: imx6: Add iMX95 Endpoint (EP) support
> > 
> > Richard Zhu (1):
> >   dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
> > 
> >  .../bindings/pci/fsl,imx6q-pcie-common.yaml   |  28 +-
> >  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       |  57 +-
> >  .../bindings/pci/fsl,imx6q-pcie.yaml          |  49 +-
> >  drivers/pci/controller/dwc/pci-imx6.c         | 640 ++++++++++--------
> >  4 files changed, 462 insertions(+), 312 deletions(-)
> > 
> > -- 
> > 2.34.1
> >