Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp400108rdb; Thu, 1 Feb 2024 11:41:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNDAuxkrMN8MHfM5aPB8aHPpUIti+EPQEScE/pZvWW15CCHwtu40HUzhbTxgyu4NNv5RpD X-Received: by 2002:a05:622a:1906:b0:42b:f793:69e2 with SMTP id w6-20020a05622a190600b0042bf79369e2mr3192929qtc.8.1706816472252; Thu, 01 Feb 2024 11:41:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706816472; cv=pass; d=google.com; s=arc-20160816; b=CkadzbsGP9doaZpAH6PZ2zIQWcCJXR/U5jcF23Ex9ccVUZN60hx7Bwy/kGH3Oufznp uAipUR3/QZ8sYP+NQDbEjboZA2F40Yl/F58LeV3ysJvG9tKSuZfKFq/UGnvrj7cO/Rs2 AiVx+eqlsTsDi+vpC9InwvY41126/EF1fI+1hYIppTrBFRu+UGUzr9BFc/r9iXaS3o3Q yoi/zs28UBQkKeuDtdzqjvLXgwPem0+M91Kku80+FrsrBi3R3/8PkbjHUcdI1vfJhRrb /22Dfh6q/HLXllT5ycYOZYf5zgxNOruU/xWGUoM21E6+ah8wpcfsBF2EfIfpJU3VrWBO rZeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=UXmjNNwtBKY2PToVChTPgp5c9XhvKlVs8iL0DJ46I+M=; fh=N9zYxvHyWfMbw2P5abA/UYhExM733so3NJQegEaYg8o=; b=LxLZ51NzRa0cjIONFjIxwZuxHt+YwkRRRq9Fh/O7sYqSoQm97gJj4ir+epMwA0g/WB IBPqXsdD5pk0X/aFbsF97HwkJ7ROnlttfRrx8FSwAH81suB5rzDRgml6b6jxihhaWaof VrffPfZubgYm0wX54/eioZbfCx0IqCXnroneagiddC4syFRF0yJL6DmnSMvswcyBnZEq 2/VRAgW6v/6iZgEUmuXmtN0SGy6Jbj6MKc7XvG99vFpjloScryO2Gic8b5z8yAxX099p ry6Fw+ay32FG4GjQflXguU6mzIeRR3mXkp4okfESLMvHZ++kM50YVQ6hmQMeHHNhrt/a 1Tyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IbTcrcsZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCUhPcRbuTf/3wCoUoFK9KqV7/Zu4Y2SLGBr3KU30EcUXzM07WYoE9A9Il9VfXeoGtNco+BTFiQO+fm1QclsA0va3b1w5txP/BOCaTWEwQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p13-20020a05620a22ad00b00783f7a6219dsi245371qkh.216.2024.02.01.11.41.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 11:41:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IbTcrcsZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 04D941C23CEE for ; Thu, 1 Feb 2024 19:41:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9805A85291; Thu, 1 Feb 2024 19:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IbTcrcsZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC807C6C1; Thu, 1 Feb 2024 19:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706816464; cv=none; b=oi+BjICPfTE1I6yon9Q2hqTUjn9Y31JLY30G5pI8ckgzXLzjLls9B7nslBVrlkFjKz6D47Kp8W9iza7rQx5aH8imLicoO8j3Ac73UURcmretgeO7ZiJWnTB7MSi4fB2XA6Gxh9pNzZYbd0SjNpNw0ms9ypi890MBeoPQtwc1NyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706816464; c=relaxed/simple; bh=mw8IruWtLhnVBZG2bw57KfvNyrKA6nWlauPlAegiYXo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CDboBe0om26ZBO/wwfNELDeuXzu2DzVwY3VrkZMi1XyAs0cVaGrQYG/hB0F54aDTc1Vrne5GUM98RMKwg1Qkx9yH6ZwF64sWnb2fQXnypQ366FXr7tXmDyhkKPfhl3iBdjqfBXvqrStCh+cER/83VS0n/Wlq8autMCb/VBeTz2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IbTcrcsZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2756FC433F1; Thu, 1 Feb 2024 19:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706816464; bh=mw8IruWtLhnVBZG2bw57KfvNyrKA6nWlauPlAegiYXo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IbTcrcsZUbMN85dPQYaJ8qHiKYG7r4m4/vfEYOZMt/h+f2q/V3Jc7gXKXWs+YfMTO 1elg+W0ORBzckh9fcP7CfBW054G/WcsrDwYiK1BmG1m+vN3a9npeL92wIDqwJ/pZeF Hb3Taetog6bGz8vOrfoiDKy01/JZWQfY1NbNmaBTSPTzP7T588bLgP13/Ms1XeVOtQ C0Pdm48g9a65sdi/W9/Hgb31NeKqeoO1TJjndCf7weVP8XYSwz6WpI5uB0uWySEXqj fUvChv/wDo2t0g5vYPMnLoQKDWFl/E3Rtf203kURT5zR3FQPUTLAR4c5NhPWD8xQqd bWhF7rbv7o7Xg== Date: Thu, 1 Feb 2024 11:40:59 -0800 From: Jakub Kicinski To: Breno Leitao Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, Andrew Morton , Mahesh Bandewar , weiwan@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, andrew@lunn.ch, leit@fb.com Subject: Re: [PATCH] blackhole_dev: Fix buil warning Message-ID: <20240201114059.50b1051c@kernel.org> In-Reply-To: References: <20240201133238.3089363-1-leitao@debian.org> <20240201085509.40a0bb76@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Feb 2024 10:46:08 -0800 Breno Leitao wrote: > > Since Jiri suggested a title fix I reckon we should be a bit more > > specific, still. Imagine this title ending up in a quote or a Fixes > > tag, could be many things.. How about: > > > > net: blackhole_dev: fix build warning for ethh set but not used > > Sure, let me resend it. > > I suppose I should recent to `net` given it is a building warning, > right? Not necessarily, net-next is good enough for W=1 warnings in general. Compiler warnings only show up if the file in question or some header it includes was modified. The linker warnings are a bit special. If you touch any file in any module you'll see all linker warnings.