Received-SPF: pass (google.com: domain of linux-kernel+bounces-48910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>,
	Peng Ma <peng.ma@nxp.com>,
	Jiaheng Fan <jiaheng.fan@nxp.com>,
	Wen He <wen.he_1@nxp.com>,
	dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM),
	linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev
Subject: [PATCH 1/1] dmaengine: fsl-qdma: init irq after reg initialization
Date: Thu,  1 Feb 2024 17:04:06 -0500
Message-Id: <20240201220406.440145-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?h7bX9YJEnkBAM3N36Q9cqvflYTj0JFh+X/toEEgilfZFusJ8GtBx70BY97Wb?=
 =?us-ascii?Q?zsCemUJgqL8dA5K8nz6rCU63/nZf3W21sN7zXyfur13MhMqQ/ZjwISKa+XC6?=
 =?us-ascii?Q?UhCQtIYESH8N4iFuK5d9uTUwHA3twB8QU0R5O37Xvb0CWX3IDN8SnGqDtsvi?=
 =?us-ascii?Q?p6T7R3xr0Usu5wXeTwhnxjm2DhtRN4eWleWWvLFGY1C9TFYYOw0d3CIHNDEl?=
 =?us-ascii?Q?msgcJuCVcstXn9Ug5rnCqtnbhgV+jhjU4EQDlIy0paYUHlFNtzEKQ/NVO0dB?=
 =?us-ascii?Q?rxAnNaAf6FlLOF5HDfpOaNVKG3bSQtWjCEhX9K51RD2kYS47ndESY1VG6B5k?=
 =?us-ascii?Q?xSNUgNuTc1pOem2wFANNQWYzfe0pAuOB0cbdU5R1oLZO52Kcs5B7z6I/O8cp?=
 =?us-ascii?Q?4av6dKuTRDdyXZgzdPSC11eT757GsLBEnptVR3qAnA29VQrefCDrckc6po8k?=
 =?us-ascii?Q?o+hTAUZ58wlJwaqipsIQYM1GRlYBYSjMlULw6r1Y0h0GFM7mSZN5mJOpSsR4?=
 =?us-ascii?Q?CgEze28x6J19xWO9zkivb0MqFVKeKfr4gef4IljvPOtzCdD8NxWGvPa1Z33s?=
 =?us-ascii?Q?KGsFaW8uLera/FpFue2orIJnAC4ehtYRg93dkiYW610oRx9IO9i1OOx9znAv?=
 =?us-ascii?Q?JhFKgv3hW7fx7GpZy08S/FwX7M3uYNZEWxJzGTiTTcZTUvhXp35ng4KM82ox?=
 =?us-ascii?Q?tQLQMqGNoMtSbVunOukhAmCO0Z9w9g/PaqrSbnlIchVenE+uUuuFK4vurgAW?=
 =?us-ascii?Q?3sE0AxUN0QlF33g+jug4dagJdonMmEj1/QXzQT8MPk8THDPlNHT+erhZK+BA?=
 =?us-ascii?Q?g5obPZXiiHZ2YF2sYX0W9gAmWfw22q4FxF3H6fdJE1wD1s2q1fnNluJRIrko?=
 =?us-ascii?Q?ND3PSoKS0/nZe4dUxY3Kzkg/fZyc0pm4FuoT/ZsAWLQkTxe3pzyVpfhCiMTF?=
 =?us-ascii?Q?WEjQPUZfQDmbw/kxrOgfzSA1A0enron/jZQ2DkBenEmIliUNj6zxfdgA3RSA?=
 =?us-ascii?Q?v9XCMAdcT2vtlwOqrOK/zMGQVquK4V7R+zw9uv3jBlhhXUd4jLLE8Vdrb0zc?=
 =?us-ascii?Q?yTVg33FAqchaodfTXlyTwqda76Vy4WAcwBeKvaDxWbGSl2WKmdWDcul572sm?=
 =?us-ascii?Q?myS3bxBhG7vGjttL1NbRQl7tkc+2kovfce2+FAedfuV3qU5hNCbywSADjYOa?=
 =?us-ascii?Q?g8RB8Ow7BalBhesJ7jvgMgV7+Qj9Zw7N9mdvKCp5XMqFR5N1DACZgengBFIR?=
 =?us-ascii?Q?eMbOGCZCOxdYQD/rqxgM9g3iJ8NriAViCJhn1+GKDoQQrldTiPuZFphHI1EF?=
 =?us-ascii?Q?rhitecvAU3/Vxw+ycKFMH1p+pBFCPOPLnX2FuzRgiNXYUp6TPVRtsJib/rwy?=
 =?us-ascii?Q?8p23xaag75DFuf1CzwkOSHOfBp6dIFY2+/JQSmgWcJnNFVbz7SnvuADw9TQr?=
 =?us-ascii?Q?0CYORbBokwvZRi86YUyw0sOY8bQDDD8/+4rfPupyKZO6DngHrEGipUJVbz8z?=
 =?us-ascii?Q?C5OTtT/rE99xlWILaYZ8Ubp6ob3rsbm3vyMVchV4/cW/G+AE3Du4yZt+APeR?=
 =?us-ascii?Q?muPbL06XutExT5hmU1OdvtFRFotxECNx6s8nqjl6?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2514c916-e507-4301-899f-08dc2371bea6
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 22:04:22.2401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bZZmF3kgbHzommMiJSqbaIC5hsDNzlkBIDIUIp6ZlD02gd7N52fLulkRWVUJSaaaehXYBps+hMAF7NR7VEgckw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9763

From: Curtis Klein <curtis.klein@hpe.com>

Initialize the qDMA irqs after the registers are configured so that
interrupts that may have been pending from a primary kernel don't get
processed by the irq handler before it is ready to and cause panic with
the following trace:

  Call trace:
   fsl_qdma_queue_handler+0xf8/0x3e8
   __handle_irq_event_percpu+0x78/0x2b0
   handle_irq_event_percpu+0x1c/0x68
   handle_irq_event+0x44/0x78
   handle_fasteoi_irq+0xc8/0x178
   generic_handle_irq+0x24/0x38
   __handle_domain_irq+0x90/0x100
   gic_handle_irq+0x5c/0xb8
   el1_irq+0xb8/0x180
   _raw_spin_unlock_irqrestore+0x14/0x40
   __setup_irq+0x4bc/0x798
   request_threaded_irq+0xd8/0x190
   devm_request_threaded_irq+0x74/0xe8
   fsl_qdma_probe+0x4d4/0xca8
   platform_drv_probe+0x50/0xa0
   really_probe+0xe0/0x3f8
   driver_probe_device+0x64/0x130
   device_driver_attach+0x6c/0x78
   __driver_attach+0xbc/0x158
   bus_for_each_dev+0x5c/0x98
   driver_attach+0x20/0x28
   bus_add_driver+0x158/0x220
   driver_register+0x60/0x110
   __platform_driver_register+0x44/0x50
   fsl_qdma_driver_init+0x18/0x20
   do_one_initcall+0x48/0x258
   kernel_init_freeable+0x1a4/0x23c
   kernel_init+0x10/0xf8
   ret_from_fork+0x10/0x18

Cc: stable@vger.kernel.org
Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs")
Signed-off-by: Curtis Klein <curtis.klein@hpe.com>
Signed-off-by: Yi Zhao <yi.zhao@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/fsl-qdma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index 11d10dcd8b45d..af7a86a3384ac 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -1199,10 +1199,6 @@ static int fsl_qdma_probe(struct platform_device *pdev)
 	if (!fsl_qdma->queue)
 		return -ENOMEM;
 
-	ret = fsl_qdma_irq_init(pdev, fsl_qdma);
-	if (ret)
-		return ret;
-
 	fsl_qdma->irq_base = platform_get_irq_byname(pdev, "qdma-queue0");
 	if (fsl_qdma->irq_base < 0)
 		return fsl_qdma->irq_base;
@@ -1241,16 +1237,19 @@ static int fsl_qdma_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, fsl_qdma);
 
-	ret = dma_async_device_register(&fsl_qdma->dma_dev);
+	ret = fsl_qdma_reg_init(fsl_qdma);
 	if (ret) {
-		dev_err(&pdev->dev,
-			"Can't register NXP Layerscape qDMA engine.\n");
+		dev_err(&pdev->dev, "Can't Initialize the qDMA engine.\n");
 		return ret;
 	}
 
-	ret = fsl_qdma_reg_init(fsl_qdma);
+	ret = fsl_qdma_irq_init(pdev, fsl_qdma);
+	if (ret)
+		return ret;
+
+	ret = dma_async_device_register(&fsl_qdma->dma_dev);
 	if (ret) {
-		dev_err(&pdev->dev, "Can't Initialize the qDMA engine.\n");
+		dev_err(&pdev->dev, "Can't register NXP Layerscape qDMA engine.\n");
 		return ret;
 	}
 
-- 
2.34.1