Received-SPF: pass (google.com: domain of linux-kernel+bounces-48931-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4468be08-1496-4092-93ea-1967aa667c4c@intel.com>
Date: Thu, 1 Feb 2024 14:16:48 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [patch v5 02/19] x86/cpu: Provide cpu_init/parse_topology()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Arjan van de Ven <arjan@linux.intel.com>, "Huang
 Rui" <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>, Dimitri Sivanich
	<dimitri.sivanich@hpe.com>, K Prateek Nayak <kprateek.nayak@amd.com>, "Kan
 Liang" <kan.liang@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>, "Paul E.
 McKenney" <paulmck@kernel.org>, Feng Tang <feng.tang@intel.com>, "Andy
 Shevchenko" <andy@infradead.org>, Michael Kelley <mhklinux@outlook.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
References: <20240117115752.863482697@linutronix.de>
 <20240117115908.410413470@linutronix.de>
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240117115908.410413470@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2FEd1F1OEh2cWFkWDJ6OE05WFgzVzZDSzFuY3I1b2t1QnRSV202Y0FUbkVz?=
 =?utf-8?B?cGlxTERSR3BORlVYWWlCK3dPV1lRUnNiM0puMElWZ0tlTTNyakUwWU5ZKzZ1?=
 =?utf-8?B?bWxWaTNhaFlGb0hXMXNHOXgxMy9GaFUxQ0FLUVQ4aU1aMGk2NU1RbzNMY1A0?=
 =?utf-8?B?QlFUQUROTE5zMGlST0E2NzdTbm40MlZFeVV0Z1pFZzIzZTNvTy9GbXpHNHBt?=
 =?utf-8?B?YUFzaHFrVHF6N2tSRjdScUJjMG1rOG9meXhGV1hjKzJ4QzFQMkNMN3VHbUEy?=
 =?utf-8?B?VmJTUjkrRVNlVjM0MmxoZmg1elNwZzlnZnFDZ0R1aU1SUkVGUXpFeDN6TnYx?=
 =?utf-8?B?NnQrakJ4TFRtYm9mRnBWNUlrdVY2ZWh6RDhQTVIvMmswM24vcS8zTGVPSkJl?=
 =?utf-8?B?SkhFSDRuaVAxd3NzOUczU3lEck5rYlIzeGlva3JhOHBudlRyWEIxSG9UeHVJ?=
 =?utf-8?B?d2hDd0hlR3JkbHF3MkI3bGhCLzFucWQxaTZQN1dGT3BlY0FZb0h1ZXh3M2t3?=
 =?utf-8?B?bGYxMUNUU3RINnRlaWxpdWdNUmpyUmYyQ1h6dnQ4YjNHUm8ydjNpb3BwRnZC?=
 =?utf-8?B?TFR1dHI0cG5NVXVKa0R6WnozM3dXUUZiUGRRbDV6Zk1yL0x6RlFDcjJuY3FE?=
 =?utf-8?B?dXhYZGJiUGZ3SUdxODMvQkhFeDV2ZmJPNnM4VkM3YmkvOE9rNjIrTXlHZW1s?=
 =?utf-8?B?UzFEREhtbjI5ajBQdUhDN3dtcm56eUp5V05yeDZBSGgydjl5Skg2WTJJdDB1?=
 =?utf-8?B?Y3hVWjdyRVdYVW9Od2RiYmhIQUFzc2dacW4yMW02OUhNK3o0YndmNFl0dUpH?=
 =?utf-8?B?c0NyTnJzSy9DYy8xNEpXeklwcnFicVlHMDgzeDVpUVdJYzZSdWdIcERsYkdU?=
 =?utf-8?B?bFZzanFoRktSVSt5eUQzQlJKWktVN29BOXdVcEV1TlpRSzgrbU5RbnpsN3BV?=
 =?utf-8?B?dnpkVk1GNDk1aEtpWGdGSEZlQVJWeFFNYmZZSFQrZ0FGbkY0MnRhaXZPdFhx?=
 =?utf-8?B?SnBOck85V3E0N2JLYndkaGZ1Ym1KdUJGSXZpcW1BZ2ZFb2d2Y29RVjB0WGM1?=
 =?utf-8?B?WVl0T2lPV1VYcWd5elFFWXd4NGR4UnRqZWpDNC9BaXNzeTZENTVDSnZwUDho?=
 =?utf-8?B?elJIZHhob0hyN3VzYUdEVmRQRjBYcVIzTE1uMmlOWU1uQ2k3MDBHYUR4VWFs?=
 =?utf-8?B?MGVwT1lmK05LWXBhaEdQWkRSbEpOWGIvZTNOaVprS0NzTWhaWHo0eTQwWjYx?=
 =?utf-8?B?SW1rK041S0FuVUwrN1gxVzRGbUMwTVhUbGgwY2tUS1g1NHlmbXdCU0tNQXUz?=
 =?utf-8?B?eEN2aUtQTkJXeEZrdm1wM3BJZk02djN1SDZBcVMyUkcxM3lvcWI3Y01BTUl5?=
 =?utf-8?B?MTNEb2wvVVZjNGJQNEpxOE1ieHRTa1o1M09VZU5SUTUxOWVvdFBZQXRLZmhn?=
 =?utf-8?B?N3Ard2tVTmE2OTFNRFQ2RHBjVGFsczRLMXUvdk1ScGQ4Y21yclV1SWxTWnFG?=
 =?utf-8?B?REhhOGE0VGFJdWZHTHQzREljRlFWd3A5UXliSTBmWXhkR1hwVkpQU3lMdzFR?=
 =?utf-8?B?cU5IbzM0dGw2L0Nza2o0WkFEdVgrcW5rR2VzY0psQUFuUjNIZXQxUmNJYkcy?=
 =?utf-8?B?UndJYnBwby8wT1pEMzR4cStjTUdpQ2I1MDZtM3lBZ2pYdFZXVEt3d20xT0R4?=
 =?utf-8?B?RTFpN1UxVWtsL0pNYWRzY0Y4RDZ1cGR1bWxIbkJVVDZiQWgvTHNrc2tvTU9Q?=
 =?utf-8?B?dEZ5UXZndE8veklaTzlyWTZUR25ORzFxU1VaRnUxSVJwMHJXdit5dHQzb1RK?=
 =?utf-8?B?d2NwZE14REtKRThPRVdCNTlYSkJLbmhvei8rZjBHS2F1TjhwYUFpV0NCM2ZU?=
 =?utf-8?B?WnVtSXAvUFArc2xoOHUxMk9lRXVYWUwxREZOckhCNEZNOFdhWHN4aFZaQ3Ri?=
 =?utf-8?B?bTRBbXo0R2ltYlRDODZDeDRaNjBnNUdvZytZaXpHSXRHMVdrclR5VkdGVmZN?=
 =?utf-8?B?aSs4QVlyVEFITVVKbktZSDZnb3VCaDdCVkp0Vy9ReXQzOWp4SndQWEk4TVN6?=
 =?utf-8?B?RE5BTFluTVFhazlib3J5WnZKaHh6d2NiaHNtQ2xQL1NGQ2hsb2R1RWo3VmJx?=
 =?utf-8?Q?KLMJNEftlFWpEIgYGqO7umPh7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0254b5ec-ad52-4049-adf1-08dc23737cea
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 22:16:50.4979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jpD/BiLsrWEoTlpvGFX3KKcU/gkeG5BoCiDptTP19+kJxrGUq4PR9AIc0DU+ANc8Li3o4Oh/MqmBpeETrBMjww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7393
X-OriginatorOrg: intel.com


> --- /dev/null
> +++ b/arch/x86/kernel/cpu/topology_common.c

> +static void parse_topology(struct topo_scan *tscan, bool early)
> +{
> +	const struct cpuinfo_topology topo_defaults = {
> +		.cu_id			= 0xff,
> +		.llc_id			= BAD_APICID,
> +		.l2c_id			= BAD_APICID,
> +	};
> +	struct cpuinfo_x86 *c = tscan->c;
> +	struct {
> +		u32	unused0		: 16,
> +			nproc		:  8,
> +			apicid		:  8;
> +	} ebx;
> +
> +	c->topo = topo_defaults;
> +
> +	if (fake_topology(tscan))
> +	    return;
> +

Need a tab here instead of 4 spaces.