Received-SPF: pass (google.com: domain of linux-kernel+bounces-48937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <49d3bba9-0235-466c-b84a-7eef4d8f6ac2@intel.com>
Date: Thu, 1 Feb 2024 14:24:28 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Arjan van de Ven <arjan@linux.intel.com>, "Huang
 Rui" <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>, Dimitri Sivanich
	<dimitri.sivanich@hpe.com>, K Prateek Nayak <kprateek.nayak@amd.com>, "Kan
 Liang" <kan.liang@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>, "Paul E.
 McKenney" <paulmck@kernel.org>, Feng Tang <feng.tang@intel.com>, "Andy
 Shevchenko" <andy@infradead.org>, Michael Kelley <mhklinux@outlook.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>, Andy Shevchenko
	<andy.shevchenko@gmail.com>, Wei Liu <wei.liu@kernel.org>
References: <20240117124704.044462658@linutronix.de>
 <20240117124902.600583242@linutronix.de>
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240117124902.600583242@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGk1WVp4dUx0VGxsVXRpLzdzdjE4ZEpNV0VHcFJKeVY1VDB3ZUI2RTFzWnBL?=
 =?utf-8?B?OFZyd0JrVHFDZ3dlSmU5bGlmLzJyNU13N1oySDU2cEFtUWc3SDJwREhNSUw1?=
 =?utf-8?B?ZjBTK09xNDVuWGhiMUxIVUQ0K3g4cnpaRjNjZ1JUaWlGT1oxOFRNWEVMMFh3?=
 =?utf-8?B?a21KRDhCNklsRnFHb0JPQUxFUWhZNWJQMWNMYWEzV2ZjbmZjNjM1cDF0Z1Qv?=
 =?utf-8?B?MFZZUk56eTY4TUVxNUVyUkgzZWNVOU1sOWVnbFg4TUFrUlNUYWcwNVN1Z0Zn?=
 =?utf-8?B?ZXFrK0ZZbVhFeXBlN1IyUXQ0dEpaUFlvK0FPMHl2ZDhmcHpoalFXeTlJakdI?=
 =?utf-8?B?SmppNVQ2QW42NXlvMG5UTzYyY2NYa2dUdWtPRnZDQ3c2dklpVm9yK2FhREsv?=
 =?utf-8?B?dEIwS0UySkVkbldwQ0lvalphS01IODNoRnRYVGVoakx6ZGNPR240Zm5WU0hq?=
 =?utf-8?B?aTd0VjEyT01sZ3BZajl4VWw3dm45d2ZMa254c08ybndHNUp1TTNxMFhaL242?=
 =?utf-8?B?UE5WRUdXU1ZuNU1jemkvY1lycEM3Z2VpU2ZpNHc3b2xPd2JoaHJxcDd0VDN0?=
 =?utf-8?B?OUdVVG5YNFRDM2ErTWR0RGdGQ29ldDZ1TzBIWUpwN3hzY0EwUFlXYW1lamZs?=
 =?utf-8?B?Tk0vaUZTaDAxaDRNUkpjMkxnMHhTYUw4NTRtcSs4RkF2Nmw5YXk3N2V5anJq?=
 =?utf-8?B?UEE3V0NGLzhvM0NOcVpzQ1hzU2VQeitlVUVwKzlGdXFHanlRTThlZTNYejM1?=
 =?utf-8?B?bDRIcHNHZjhUWjlZRzV2U0VaRExwalJlTDVmVmc4WlhCRUdnYWlHZXNMN2dT?=
 =?utf-8?B?UTQ1OUhZTlBUeFpOSklXLzJZRG5UelNBc1QwMExoWjB2VThMWVp6SzdCQVR1?=
 =?utf-8?B?T3c0SzJ5SHlxSXFlUyt6WEpzNk43RTNnc1poZmd1LzVxQzF4Wkw4OW5Oby9K?=
 =?utf-8?B?SU8xOW9tRXlaZlAvZFp6UXl4ZlZKdW8wRW5pOFZhVFh1RTk2WU8wOEdPTHZy?=
 =?utf-8?B?V0c5MjNVZ0MxK3hTeFNiSHQxWHJaMDdWaDk3a1NZSDFwK0lEUk5mYmhORFF1?=
 =?utf-8?B?NlBVazJaeFQ3Mkg0QStqRzVoNFQ3dktMSTR4VSsyR1FaZHZaVzFvZW1jNE1v?=
 =?utf-8?B?bFFPb1B0WlJtTUhPb1lrbWZYdHgwUlRiRDdmWHBBNitLOXZFdWZMUDF5VVQv?=
 =?utf-8?B?OFVkTTJ2dUp6TG5uM2NHUy9kckZqTkRFVzRqMFdGanJMZUNLWWZuZkxEd1Zh?=
 =?utf-8?B?MmdoM3dKQTJnTFQ2VDBxNnUwRkhkS3VWb1dUL1FwUjgzTTZQeGZxclJ0dUpW?=
 =?utf-8?B?Y3BYKzNBSkJvaitTZ3EwWC91MkZZMVBTWEw3UEw0YkdEYVNnandURVNrMmJj?=
 =?utf-8?B?SkppenlvVmZzRXZuNklxcVZEamc2ZUhvRE8rMnBSTU1LbU5reXY3Q2lpVDlm?=
 =?utf-8?B?YzM0bWJScjF2NnE5aXM3OGtRSEJGQ0s2MHRuRW1uMVNyQ3lHOG5WN2FodVZO?=
 =?utf-8?B?bk1hMkxzb083ckF6ZGpKK3RxbVFPZ0F3S1JRamdZaEtaQzdEVFhvZEFWeTlw?=
 =?utf-8?B?MTg5NHV6NlY1WVUxL3UrcVhqUy9NOThxcGtBUXRHUDBIY0pGU2lkdFdWUEZw?=
 =?utf-8?B?djVBd2JDOCsyQnlEbkZmQy9DOGd3N3pFTjdiWWxKemRwRFVoc0llNnpPdGNh?=
 =?utf-8?B?b3B6VE9wem9VUU9GL2pyb09HLzFhODdGTGtBTnplU0xpM3NoVzZYMmNVbS9O?=
 =?utf-8?B?OHcraUdKWjBidHFFbjI5TWlTMzlsTUdEb0tOcWppZ3FqYjJ3NWRYWG9mSXh5?=
 =?utf-8?B?UVRpL2RCeTI5cndjSlloaDIyUnQ3MldHZ2s1WHprcnB6ZHU4bC9oNTQ5eEFn?=
 =?utf-8?B?ZTlRM256bUpnU0krYXZNM2dCS0Nja0EyUWRaRkUvclZZSVRFcFNxckprQ3Z2?=
 =?utf-8?B?czBCRTB0aklxYW5YSnRDbjJZVW1kSkhaTlZGODJIVUNnamJnSnhDTWNFUGpm?=
 =?utf-8?B?YjJHbEJRQUZVT0ZwNUMvM1Qvd1dZZEdyS1RTK0ZHUlRQZXJHeXo0TlJVVFlJ?=
 =?utf-8?B?ZTA4WkZFQTVJWUVNSTloaExNSTlkQldPMEczYnFTWm9zNDZ5YXhWS1RVL251?=
 =?utf-8?Q?pWu1DikGrZddjuX4l1sWtxca/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 135a678d-f1e6-40bb-73a9-08dc23748ec6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 22:24:29.9361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o5UcPy2gXI9QEeqXAX0uZLkByi0oJreF+o4j749XgEefwChqzCXKYOgnVhBbsW1eDOHPBEISSh9vKvTYnd7PTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8020
X-OriginatorOrg: intel.com

On 1/23/2024 5:10 AM, Thomas Gleixner wrote:

> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c

> @@ -1499,15 +1498,14 @@ static void __init setup_ioapic_ids_from
>  		 */
>  		if (apic->check_apicid_used(&phys_id_present_map,
>  					    mpc_ioapic_id(ioapic_idx))) {
> -			printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
> +			pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
>  				ioapic_idx, mpc_ioapic_id(ioapic_idx));

The second line could be aligned to match the open parenthesis.