Received-SPF: pass (google.com: domain of linux-kernel+bounces-48945-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <15d8e520-c129-4b09-9a25-ecee5da36ca6@intel.com>
Date: Thu, 1 Feb 2024 14:31:21 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [patch v2 25/30] x86/cpu/topology: Use topology logical mapping
 mechanism
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Arjan van de Ven <arjan@linux.intel.com>, "Huang
 Rui" <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>, Dimitri Sivanich
	<dimitri.sivanich@hpe.com>, K Prateek Nayak <kprateek.nayak@amd.com>, "Kan
 Liang" <kan.liang@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>, "Paul E.
 McKenney" <paulmck@kernel.org>, Feng Tang <feng.tang@intel.com>, "Andy
 Shevchenko" <andy@infradead.org>, Michael Kelley <mhklinux@outlook.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
References: <20240118123127.055361964@linutronix.de>
 <20240118123649.971809766@linutronix.de>
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240118123649.971809766@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnJuTkFlQkhhYmd0Z3Znem52VlB3MkRDZzRoWUZick9PSzdjTmxRTWQ3MUJG?=
 =?utf-8?B?R0EzOWJTU0hrK1lKcUxHTWd5WDBOQjAxTFgwTC9KZFBLanRteTB6Z1JtU3Jx?=
 =?utf-8?B?WmZlV0Y2OUJRNTBRVFNtZytSTkMvNmlRaUZsT3FrcHFkZ1oxdWhJazFnYU40?=
 =?utf-8?B?WXdndjhRZHJDLysyaVNpazZENnJhQUhCZmVEODlvRElhV1A3cG9rdDE3ZUpQ?=
 =?utf-8?B?YXJLYzYvWlhyUXoxbW9xUlJQTHBIK1pTNGdPYUpZSFN0ckxnTGFIYTFGY3k5?=
 =?utf-8?B?eHN5TWhHSFBvMUpDaG9uN1ZYK3VDajhjdFc3d3ZMZEwrL1daZUpiSUVXcE5Y?=
 =?utf-8?B?cWUyY21pNXAwYW9HU1NMUUM5WEVJRURITjlDQXpJaUtzR2RUOW43TkM3aktL?=
 =?utf-8?B?UEpuVnhFRmdVYTh3eGNOU3VVcGZrOHcrMVJNK2FPaVlKNytncG45eFJrWkhl?=
 =?utf-8?B?OHVzSXNGaDN5REplYnVZNHJaS1NNRTg0SVRWVlZsM3YydzVhVkE1ZTFhVUVo?=
 =?utf-8?B?dHFFdDUzbHVEaU8vWitMUDJoUUUwK2JsOTJVemFUcUxhM0xlU3g0dFB2aGVo?=
 =?utf-8?B?U0swOWZHdUdoUTRERm9BaWZzYWcvYnAxVTZBWjRwQVVCVzlGUlp6TVh1bTFo?=
 =?utf-8?B?VktNano5Z3VEajU2OW9xbktSUjViWVpRcDVTdUhiaXB1d2ZGQUppQ0tWWUhu?=
 =?utf-8?B?aEFZNnBJK29CSGRYNUNUdWJqNFY3azQxeHdvZVdONlVZQUplQlN2dXQ2dzN6?=
 =?utf-8?B?b0xHbXN0cGpueEh6d3FYZGhpWDRxeTIwYUE1cXd4VEZ4MjYzMmx6WkYxNjFE?=
 =?utf-8?B?TThwdSt6VDNvaWhYWVVPYVNXckxkSGYyaDI4dFZMV25OTG51VklXT3BqNmcy?=
 =?utf-8?B?TTEvczYvbUcyd21EaWFrNXpkNjcxUnQ1aFprb05tTlFDMDAvYU01VzFzbTFI?=
 =?utf-8?B?RGxVcUZYN3ZBMkRoaCswSURYV2NTOHUyZGxaaDM2T3lYRkVmdWJhTGI5UnlM?=
 =?utf-8?B?TEM4SEY1ODQ4NGdMTVMydC9DRXlXemVPNEp0RElUR3NqMklNR1F2NllyUTNo?=
 =?utf-8?B?OFRFdFQzclhkMFZmMzZLT1E3UUx3b1JEcHgySklmWVduTlNMSHBZK0FVNXJx?=
 =?utf-8?B?MVllQW9ZQU1zaEVyR1RIRGF3S2tRaE93VFluUThQamkvcEk4am5kUnpTRWo1?=
 =?utf-8?B?OG11VnBpUlZkSklaYnFRNnhGbFF6L1gzMExuTEdxejFxMWQyakNiSmxGQVhW?=
 =?utf-8?B?bUlFU3g3dGU4QTJERFhGWTR3ZldKOGtSbWFnVnRhdmdvNHpkcGRoSG1lajIz?=
 =?utf-8?B?WmhJbXBSMnQ2Q0gxeEZ2MUZiWVhNSkRScDloNjhDb0lpRWlUZ1JTeFBGVzNl?=
 =?utf-8?B?Z2trS2NCOTdyM0F6NEtNaDAvWURDdlZBYlA4L2U2Uk5nMGVNTmw4WnBkcWVB?=
 =?utf-8?B?N05Jc3NqWXVLNnFnWGpRWUpSSWhzbmtESUd2a3ZjVjlWQmVVMDZXbEs2QXRO?=
 =?utf-8?B?SEtXeGtVUEN4TFl2QUZqaC8rYXRWVVRrcFptL2lWa1dhUlZUWkE3OXhIalZy?=
 =?utf-8?B?YnY2SHpxTVd5QWMreUdwbnpFWUdaRktidVZrRjZXSlY1Yk1lY21qV2pQdWtx?=
 =?utf-8?B?NzZETjN1bkZZOUtJTStZUW1zTVBBYWR6WUdzZ2lWNmlqcTVUNGM0SVVRUTBy?=
 =?utf-8?B?QmxUcWpGNU9BcWo1NWV4YXlYb2RjQXliK2lVQUxTWEhBeWNyS2Rxd0JEcW5R?=
 =?utf-8?B?OS9ONWVJOFFjZFMxU1U4c0l0WVNQTkdGWXhhaS83bEhoaERzcENHQytoSkxI?=
 =?utf-8?B?L0ZqNG41OTM0c1NMY3F3cnNiT3RKSHVjc0FIVC9EWmt1S2NPVjZxNjl1aWZB?=
 =?utf-8?B?RE8yV041a2NQcEgzU2VQREJrbnZGU2pkWG1sa2ZkSTk3SkoraFpZUzhoYUZI?=
 =?utf-8?B?WE1FRHpnYmU4VlpKRUozQ2tjbmUzZ1hCQzlDQmhnMzdHM2trREVDcVVnTG4x?=
 =?utf-8?B?ZG5tUVRiZklMUWNtZjIzb0tLVjVCSEFjWFBkR2VzOEZiamtMME1pNlh4UFQ2?=
 =?utf-8?B?Mkl2c0FJREx3WTVDWjhTM0dKUzAydlplWEc2ZXRiQ1ExZzZSOTN1b0x6WDAr?=
 =?utf-8?Q?TdiyRON878fkuuhMpy4gVEHDZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 21470e2c-1a0e-4abf-5ab8-08dc23758552
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 22:31:23.5803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nBUPHFd5vGERkiFRigrMprKv+r2A9TnkQCxB/kTWE9kjkSKqxJYmKTZGCGvqmChNFc5mxLEcCQB7MWkih1CuIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6765
X-OriginatorOrg: intel.com

On 1/23/2024 5:11 AM, Thomas Gleixner wrote:

> --- a/arch/x86/include/asm/topology.h
> +++ b/arch/x86/include/asm/topology.h
> @@ -172,6 +172,13 @@ static inline int topology_get_logical_i
>  #define topology_core_cpumask(cpu)		(per_cpu(cpu_core_map, cpu))
>  #define topology_sibling_cpumask(cpu)		(per_cpu(cpu_sibling_map, cpu))
>  
> +

This additional new line can be avoided.

> +static inline int topology_phys_to_logical_pkg(unsigned int pkg)
> +{
> +	return topology_get_logical_id(pkg << x86_topo_system.dom_shifts[TOPO_PKG_DOMAIN],
> +				       TOPO_PKG_DOMAIN);
> +}
> +