Received-SPF: pass (google.com: domain of linux-kernel+bounces-48943-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Kees Cook' <keescook@chromium.org>, Andy Shevchenko <andy@kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
CC: "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC] string: Allow 2-argument strscpy()
Thread-Topic: [RFC] string: Allow 2-argument strscpy()
Thread-Index: AQHaUvHLFgl6ZJLHe0apLw7TCgOYwbD2FRpA
Date: Thu, 1 Feb 2024 22:29:37 +0000
Message-ID: <9dae4c62fc164abeaa7915f9e53fdb28@AcuMS.aculab.com>
References: <20240129202901.work.282-kees@kernel.org>
In-Reply-To: <20240129202901.work.282-kees@kernel.org>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Kees Cook
> Sent: 29 January 2024 20:29
>=20
> Using sizeof(dst) is the overwhelmingly common case for strscpy().
> Instead of requiring this everywhere, allow a 2-argument version to be
> used that will use the sizeof() internally.

You may want to (try to) add a check that the first argument is
actually an array rather than just a pointer.

But the cpp output bloat can get silly and slow the build down.
I guess no one would do:
=09x =3D min(strscpy(a, b), strscpy(c, d));
but you can never tell :-)

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)