Received-SPF: pass (google.com: domain of linux-kernel+bounces-49052-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <cc182e56-d0de-4a47-bc0a-d0c830649166@kunbus.com>
Date: Fri, 2 Feb 2024 02:13:32 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
Content-Language: en-US
To: "Elliott, Robert (Servers)" <elliott@hpe.com>,
 "jarkko@kernel.org" <jarkko@kernel.org>,
 "peterhuewe@gmx.de" <peterhuewe@gmx.de>
Cc: "LinoSanfilippo@gmx.de" <LinoSanfilippo@gmx.de>,
 "p.rosenberger@kunbus.com" <p.rosenberger@kunbus.com>,
 "lukas@wunner.de" <lukas@wunner.de>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
 "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "stable@vger.kernel.org" <stable@vger.kernel.org>
References: <20240201113646.31734-1-l.sanfilippo@kunbus.com>
 <MW5PR84MB184274E28D83DC337B486CEFAB432@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
In-Reply-To: <MW5PR84MB184274E28D83DC337B486CEFAB432@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDBQYlhXYm5GQ2VQOEpLOW1kVmJHVDlPOVRzczg2VmNFcXJWMVk0bTBMYVlx?=
 =?utf-8?B?SVRjSC96Y29FWlZGYWJqbEV1T0Fva1M4aW84czlGUjB5TVZzVDMzUUpINzVN?=
 =?utf-8?B?MUpIb1Z6RHNvU2FKaGRzUDlLaW90UVJpQUU1V2xrdG9xckVIQnhLbTJPbWJ3?=
 =?utf-8?B?N2p0SjNKc08ydVg0cE9PUVVRcmJWZmQ5dVZveFJMaEFSazR3QWRmc2xwYTdT?=
 =?utf-8?B?TzNZaDFRS3A4ZXRidzI5NnlkcEw2elhMckpzcmNSNEVPeEg1MWNLaklFMDMy?=
 =?utf-8?B?MlhXVGFGWUU4RnpoVFlEMUJGc0crUmtXMEo5SThYSzRLRmRDcmlmM3hDNm9o?=
 =?utf-8?B?UU01bU5LTk15eGV1cDB2SkdRT0VsbGV0R0FFVjRsYVlnNU01bVJhU2xYdXNt?=
 =?utf-8?B?SEpKM2dINUROTHZEbW9mSlJ0VWlDY3EvaFdhQlJhWFZCVlBaM01SbEJrWDVz?=
 =?utf-8?B?ZDVlZkg1TmdzN2crY0c5NjRoM1VWU3RpT3ZvYTN5THc4SzVlR3FlUG1OQ3My?=
 =?utf-8?B?bngwVWhYdjZ5WmxXOGdtbzVGWWF5SS9QdTltYVlwa3RIVG02aFZLR1ZJV1E1?=
 =?utf-8?B?RmszYyt4YzIyci9RL290M3dLaDVJSTNFQS9iSC8rWEc5RUU0QTJ4WjFadW8v?=
 =?utf-8?B?NlBIYS9Ib0QyWEJFanNGcjFVNktCcTJ1WTRQMTFHMW1Cc3krNkJSNk0xUFdI?=
 =?utf-8?B?Qm5KN2JwRkZ3anA0ejVMelBidldxOVB0WFhwNEdVQ0V1bHg0MjhqUkxJRWtL?=
 =?utf-8?B?M0tMamtKZllqRTJpM1N6djM2WXhJSTUxdUZoMzdLMFJMU2V4d2RVZ2lzS0lB?=
 =?utf-8?B?OVFNYXNaaHBxU1Z1Q2ZOTFdrejNYYnU1UTFzdG5tckt1S0ZnOVBPa0ZwdHdS?=
 =?utf-8?B?d2RuZENlQ1F2TG94c2h4N3ZmbEVycnlmaEg3dEMvakM5NjFCV0h2cGVjUGNI?=
 =?utf-8?B?R0RBblpMZGR5MmpKdGJsbll6Z0JyOTJtRG5ieWxqYUxkeHZFaGM5MThDY3ph?=
 =?utf-8?B?eDY1OWdLTmsvNXFDcUtpYWVWWDlxa2pTU1Jrakoxck1rVEsvYXoyZ0UyWUVF?=
 =?utf-8?B?MTF5NGNpNXR1QWFySW5XaHY4WVJKeDNRWWIzakd0ckdKUXpYNXhrUFVrcGlQ?=
 =?utf-8?B?TmJkY3EveTg2UGtHZStuMUQ5SzR6M2NWMmFzNC9uYWpxQ1BKVlA4VVA3MWJB?=
 =?utf-8?B?SWdlNmxKekpwWHJZVEg1aGhQTXBKVWgrdjViQUZ4R1hrZnBKZUJXM1V5dVhW?=
 =?utf-8?B?L0x1NXJUY05vQTdOM1NuSW1RZmN2aTBVVnhiZ3daMk16N1NmU2dTaldpV0tD?=
 =?utf-8?B?bEJOcGRITC9qUWl6dW10WUhVZk1uNDF3REU4REQ2UFF3T0RtNGZQUnlQN1ZF?=
 =?utf-8?B?WThBaUl1T2tDdFc1KzQ3dHZrbU9YTHFnMi9hWmk0QlF4OGxoWXBYaVlrVk5U?=
 =?utf-8?B?UXBrcUlNNit6UDRmbnZGdWxqWGlscHYvbU9INTI1WlRubGl3RVFUVVRNTURE?=
 =?utf-8?B?a2hmNC9OUVFDc1FINEZsVzk4dUdDNmhXQndsdjR1b1BDdnlZVVV3bnl1Qzl2?=
 =?utf-8?B?S1RVTmNObUdYNEhlRC8rcFpLMDA5NExRSXdjQTNHUXMwZ0Q2VEdqNVpnSlRE?=
 =?utf-8?B?UU1VOXFwd1NwUy9zOFRrYjZDeDFEMHFaakZjYTgxczIzdG03WTVoek5oNHJw?=
 =?utf-8?B?cVNvNFBlclhZa25tVm0rZUZwdTkrTTVVL2dGb09oQU5JbS94VHlRQUpicUtV?=
 =?utf-8?B?YUFDTGJJNno1d2RFT24vbXBSZXpMTStMenRtS2p0WmdwVWFqdjlEWStnWHVx?=
 =?utf-8?B?Skw5cFdlWU80MHFBN1JZKzdYS3plS3pVdHNpUkVCVEZPY0s2SnN5VVJ1ZnMv?=
 =?utf-8?B?OEE5WWJsSms5SWdrWU1YcHRaQkhkWUhlYzM5UzR6R3E5bjE4QXp6Y3BXMmRM?=
 =?utf-8?B?N2wvVTlnUE0zZjFTekFrU3ZJYkVCbVgzM05QdkZEenFKR2xncG4vOXMwVmNV?=
 =?utf-8?B?akJ2WEh5c1dtaFEwS29kTjJBQTRyZlUrYlRUMm80UVdKQXp5NU5LNExBME5B?=
 =?utf-8?B?K0I5VVozQjJacnZuN2EyMVRZK1diaEgxOWlDK3AzeVVEQWpjK05EY3BWL2pm?=
 =?utf-8?B?UFQ0S3RpNVM1VnhnSisyVW1HYXZxcHg1d2RiblNveEFCSk9JYS9ESGZYV0ZG?=
 =?utf-8?Q?nQypU6BZ845qPa44Vxy5MfSvvQxMK1F9hsU93klZAiew?=
X-OriginatorOrg: kunbus.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dcd100a1-a028-41e0-a756-08dc238c2e2a
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 01:13:35.9166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6q6MPaATf72qYqD7QRPtPA1l/+dHPp7kZz5st2dkdqCltxKdsjTCDjX1jPdhl4kYahfkrGIhsRXNrbw/CHT2rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1895


On 01.02.24 17:40, Elliott, Robert (Servers) wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
> 
> 
>> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>> Sent: Thursday, February 1, 2024 5:37 AM
>> Subject: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
>>
>> If interrupts are not activated the work struct 'free_irq_work' is not
>> initialized. This results in a warning splat at module shutdown.
>>
>> Fix this by always initializing the work regardless of whether interrupts
>> are activated or not.
> 
> That's using flush_work(), which just waits for one to complete. Is there
> any case where multiple work entries could be queued, and cancel_work_sync()
> would be necessary?
> 

No. There is only one work struct (namely free_irq_work) and it can only be
queued once at a time (note that schedule_work() does not queue the same work
again if it is already queued).   

> tpm_tis_probe_irq() has a loop calling tpm_tis_probe_irq_single()
> for 3 to 15. Could each of those could trigger an interrupt storm and
> call tpm_tis_revert_interrupts(), which calls schedule_work()?
> 
> 

The iteration stops as soon as there is an interrupt found that "works" (i.e.
as soon as one interrupt fires, see the "irq test" in tpm_tis_send()). If this
irq starts a storm it is handled by the implemented irq storm handling and
deactivated. No other interrupts are activated afterwards. So no,
I do not see that multiple interrupt storms are possible at the same time.

Regards,
Lino