Received-SPF: pass (google.com: domain of linux-kernel+bounces-49056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Subject: Re: [PATCH v5 2/8] md: changed the switch of RAID_VERSION to if
To: linan666@huaweicloud.com, song@kernel.org, neilb@suse.com,
 mariusz.tkaczyk@linux.intel.com, shli@fb.com
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
 yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com,
 "yukuai (C)" <yukuai3@huawei.com>
References: <20240201063404.772797-1-linan666@huaweicloud.com>
 <20240201063404.772797-3-linan666@huaweicloud.com>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <3a5628b8-ebe2-2385-b289-6a6ced8baf51@huaweicloud.com>
Date: Fri, 2 Feb 2024 09:19:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240201063404.772797-3-linan666@huaweicloud.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

?? 2024/02/01 14:33, linan666@huaweicloud.com д??:
> From: Li Nan <linan122@huawei.com>
> 
> There is only one case of this 'switch'. Change it to 'if'.
> 
> Signed-off-by: Li Nan <linan122@huawei.com>
> ---
>   drivers/md/md.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 1b509fb82040..3b4e0ef49675 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7636,11 +7636,9 @@ static int md_ioctl(struct block_device *bdev, blk_mode_t mode,
>   	 * Commands dealing with the RAID driver but not any
>   	 * particular array:
>   	 */
> -	switch (cmd) {
> -	case RAID_VERSION:
> +	if (cmd == RAID_VERSION) {
>   		err = get_version(argp);
>   		goto out;

you can just return here;

if (cmd == RAID_VERSION)
	return get_version(argp);

Thanks,
Kuai

> -	default:;
>   	}
>   
>   	/*
>