Received-SPF: pass (google.com: domain of linux-kernel+bounces-49083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <CAK7LNASGqfMkTuzP28qydpYCC0ct3cAgMpbPpmgHuQHZbtLhbA@mail.gmail.com>
 <CAHk-=whJKZNZWsa-VNDKafS_VfY4a5dAjG-r8BZgWk_a-xSepw@mail.gmail.com>
 <CAK7LNARzZ07TX2obHSpCgsC=FPTbLx5J+kPBFUECT+N7V42i5g@mail.gmail.com> <CAHk-=wg+3J8L4C7dcsZZNPEr3CJ49wKtJC0taVDBwGo9ZGot+Q@mail.gmail.com>
In-Reply-To: <CAHk-=wg+3J8L4C7dcsZZNPEr3CJ49wKtJC0taVDBwGo9ZGot+Q@mail.gmail.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Fri, 2 Feb 2024 11:15:09 +0900
Message-ID: <CAK7LNAQwcm9XfYAgcxOmGp9tvzj8kNbq8VUX09ZKscG1KEgE0g@mail.gmail.com>
Subject: Re: [GIT PULL] Kbuild fixes for v6.8-rc3
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Content-Type: multipart/mixed; boundary="00000000000093c98706105cb0d6"

--00000000000093c98706105cb0d6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Linus,


On Fri, Feb 2, 2024 at 9:43=E2=80=AFAM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, 1 Feb 2024 at 15:57, Masahiro Yamada <masahiroy@kernel.org> wrote=
:
> >
> > Is this your expectation?
>
> Commit 82175d1f9430 touched *only* the nested 'if' indentations.
>
> Your attached changed other indentations too, which I am not sure
> makes any sense.
>
> But honestly, that whole make rule wrt whitespace makes no sense to
> begin with, and I don't know why the conditional statement is so
> special to begin with, and why GNU make would then suddenly start
> messing with an insane rule with bad historical reasons.


In my understanding, the GNU Make parser is confused with
shell's 'else' keyword.

So, GNU Make determined that 'else' indented with a tab
is not the Make's conditional directive.


>
> End result: all of this just reinforces how bad the Make rules for
> whitespace is, but I would suggest doing the *minimal* changes to make
> it work.
>
> Which commit 82175d1f9430 did, but your attached patch then does not.
>
> IOW, if the whole crazy makefile whitespace change was only about
> conditionals, let's keep all the stupid whitespace fixups as purely
> about conditionals too.
>
>              Linus
>


I attached a new patch.
I only changed the lines touch by 82175d1f9430


--=20
Best Regards
Masahiro Yamada

--00000000000093c98706105cb0d6
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-kbuild-use-4-space-indentation-when-followed-by-cond.patch"
Content-Disposition: attachment; 
	filename="0001-kbuild-use-4-space-indentation-when-followed-by-cond.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_ls40fvcd0>
X-Attachment-Id: f_ls40fvcd0

RnJvbSA0ZGU5NDkwNDcyYjNjZDZmYjVjNzgzZWE1ZmQxMzBlMzI2OTVkYTJlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBZYW1hZGEgPG1hc2FoaXJveUBrZXJuZWwub3Jn
PgpEYXRlOiBGcmksIDIgRmViIDIwMjQgMTA6MzE6NDIgKzA5MDAKU3ViamVjdDogW1BBVENIXSBr
YnVpbGQ6IHVzZSA0LXNwYWNlIGluZGVudGF0aW9uIHdoZW4gZm9sbG93ZWQgYnkgY29uZGl0aW9u
YWxzCgpHTlUgTWFrZSBtYW51YWwgWzFdIGNsZWFybHkgZm9yYmlkcyBhIHRhYiBhdCB0aGUgYmVn
aW5uaW5nIG9mIHRoZQpjb25kaXRpb25hbCBkaXJlY3RpdmUgbGluZToKICJFeHRyYSBzcGFjZXMg
YXJlIGFsbG93ZWQgYW5kIGlnbm9yZWQgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUKICBjb25kaXRp
b25hbCBkaXJlY3RpdmUgbGluZSwgYnV0IGEgdGFiIGlzIG5vdCBhbGxvd2VkLiIKClRoaXMgd2ls
bCBub3Qgd29yayBmb3IgdGhlIG5leHQgcmVsZWFzZSBvZiBHTlUgTWFrZSwgaGVuY2UgY29tbWl0
CjgyMTc1ZDFmOTQzMCAoImtidWlsZDogUmVwbGFjZSB0YWJzIHdpdGggc3BhY2VzIHdoZW4gZm9s
bG93ZWQgYnkKY29uZGl0aW9uYWxzIikgcmVwbGFjZWQgdGhlIGluYXBwcm9wcmlhdGUgdGFicyB3
aXRoIDggc3BhY2VzLgoKSG93ZXZlciwgdGhlIDgtc3BhY2UgaW5kZW50YXRpb24gY2Fubm90IGJl
IHZpc3VhbGx5IGRpc3Rpbmd1aXNoZWQuCkxpbnVzIHN1Z2dlc3RlZCAyLTQgc3BhY2VzIGZvciB0
aG9zZSBuZXN0ZWQgaWYtc3RhdGVtZW50cy4gWzJdCgpUaGlzIGNvbW1pdCByZWRvZXMgdGhlIHJl
cGxhY2VtZW50IHdpdGggNCBzcGFjZXMuCgpbMV06IGh0dHBzOi8vd3d3LmdudS5vcmcvc29mdHdh
cmUvbWFrZS9tYW51YWwvbWFrZS5odG1sI0NvbmRpdGlvbmFsLVN5bnRheApbMl06IGh0dHBzOi8v
bG9yZS5rZXJuZWwub3JnL2FsbC9DQUhrLT13aEpLWk5aV3NhLVZOREthZlNfVmZZNGE1ZEFqRy1y
OEJaZ1drX2EteFNlcHdAbWFpbC5nbWFpbC5jb20vCgpTdWdnZXN0ZWQtYnk6IExpbnVzIFRvcnZh
bGRzIDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4KU2lnbmVkLW9mZi1ieTogTWFzYWhp
cm8gWWFtYWRhIDxtYXNhaGlyb3lAa2VybmVsLm9yZz4KLS0tCiBNYWtlZmlsZSAgICAgICAgICAg
ICB8IDEyICsrKysrKy0tLS0tLQogYXJjaC9tNjhrL01ha2VmaWxlICAgfCAgNCArKy0tCiBhcmNo
L3BhcmlzYy9NYWtlZmlsZSB8ICA0ICsrLS0KIGFyY2gveDg2L01ha2VmaWxlICAgIHwgIDggKysr
Ky0tLS0KIDQgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUgYi9NYWtlZmlsZQppbmRleCAxMTNmN2M3NjJmMGEuLjE3
YzJmMDJhYWFlOSAxMDA2NDQKLS0tIGEvTWFrZWZpbGUKKysrIGIvTWFrZWZpbGUKQEAgLTI5NCwx
NSArMjk0LDE1IEBAIG1heS1zeW5jLWNvbmZpZwk6PSAxCiBzaW5nbGUtYnVpbGQJOj0KIAogaWZu
ZXEgKCQoZmlsdGVyICQobm8tZG90LWNvbmZpZy10YXJnZXRzKSwgJChNQUtFQ01ER09BTFMpKSwp
Ci0gICAgICAgIGlmZXEgKCQoZmlsdGVyLW91dCAkKG5vLWRvdC1jb25maWctdGFyZ2V0cyksICQo
TUFLRUNNREdPQUxTKSksKQorICAgIGlmZXEgKCQoZmlsdGVyLW91dCAkKG5vLWRvdC1jb25maWct
dGFyZ2V0cyksICQoTUFLRUNNREdPQUxTKSksKQogCQluZWVkLWNvbmZpZyA6PQotICAgICAgICBl
bmRpZgorICAgIGVuZGlmCiBlbmRpZgogCiBpZm5lcSAoJChmaWx0ZXIgJChuby1zeW5jLWNvbmZp
Zy10YXJnZXRzKSwgJChNQUtFQ01ER09BTFMpKSwpCi0gICAgICAgIGlmZXEgKCQoZmlsdGVyLW91
dCAkKG5vLXN5bmMtY29uZmlnLXRhcmdldHMpLCAkKE1BS0VDTURHT0FMUykpLCkKKyAgICBpZmVx
ICgkKGZpbHRlci1vdXQgJChuby1zeW5jLWNvbmZpZy10YXJnZXRzKSwgJChNQUtFQ01ER09BTFMp
KSwpCiAJCW1heS1zeW5jLWNvbmZpZyA6PQotICAgICAgICBlbmRpZgorICAgIGVuZGlmCiBlbmRp
ZgogCiBuZWVkLWNvbXBpbGVyIDo9ICQobWF5LXN5bmMtY29uZmlnKQpAQCAtMzIzLDkgKzMyMyw5
IEBAIGVuZGlmCiAjIFdlIGNhbm5vdCBidWlsZCBzaW5nbGUgdGFyZ2V0cyBhbmQgdGhlIG90aGVy
cyBhdCB0aGUgc2FtZSB0aW1lCiBpZm5lcSAoJChmaWx0ZXIgJChzaW5nbGUtdGFyZ2V0cyksICQo
TUFLRUNNREdPQUxTKSksKQogCXNpbmdsZS1idWlsZCA6PSAxCi0gICAgICAgIGlmbmVxICgkKGZp
bHRlci1vdXQgJChzaW5nbGUtdGFyZ2V0cyksICQoTUFLRUNNREdPQUxTKSksKQorICAgIGlmbmVx
ICgkKGZpbHRlci1vdXQgJChzaW5nbGUtdGFyZ2V0cyksICQoTUFLRUNNREdPQUxTKSksKQogCQlt
aXhlZC1idWlsZCA6PSAxCi0gICAgICAgIGVuZGlmCisgICAgZW5kaWYKIGVuZGlmCiAKICMgRm9y
ICJtYWtlIC1qIGNsZWFuIGFsbCIsICJtYWtlIC1qIG1ycHJvcGVyIGRlZmNvbmZpZyBhbGwiLCBl
dGMuCmRpZmYgLS1naXQgYS9hcmNoL202OGsvTWFrZWZpbGUgYi9hcmNoL202OGsvTWFrZWZpbGUK
aW5kZXggNzZlZjFhNjdjMzYxLi4wYWJjZjk5NGNlNTUgMTAwNjQ0Ci0tLSBhL2FyY2gvbTY4ay9N
YWtlZmlsZQorKysgYi9hcmNoL202OGsvTWFrZWZpbGUKQEAgLTE1LDEwICsxNSwxMCBAQAogS0JV
SUxEX0RFRkNPTkZJRyA6PSBtdWx0aV9kZWZjb25maWcKIAogaWZkZWYgY3Jvc3NfY29tcGlsaW5n
Ci0gICAgICAgIGlmZXEgKCQoQ1JPU1NfQ09NUElMRSksKQorICAgIGlmZXEgKCQoQ1JPU1NfQ09N
UElMRSksKQogCQlDUk9TU19DT01QSUxFIDo9ICQoY2FsbCBjYy1jcm9zcy1wcmVmaXgsIFwKIAkJ
CW02OGstbGludXgtZ251LSBtNjhrLWxpbnV4LSBtNjhrLXVua25vd24tbGludXgtZ251LSkKLSAg
ICAgICAgZW5kaWYKKyAgICBlbmRpZgogZW5kaWYKIAogIwpkaWZmIC0tZ2l0IGEvYXJjaC9wYXJp
c2MvTWFrZWZpbGUgYi9hcmNoL3BhcmlzYy9NYWtlZmlsZQppbmRleCA3NDg2YjNiMzA1OTQuLjMx
NmY4NGYxZDE1YyAxMDA2NDQKLS0tIGEvYXJjaC9wYXJpc2MvTWFrZWZpbGUKKysrIGIvYXJjaC9w
YXJpc2MvTWFrZWZpbGUKQEAgLTUwLDEyICs1MCwxMiBAQCBleHBvcnQgQ1JPU1MzMkNDCiAKICMg
U2V0IGRlZmF1bHQgY3Jvc3MgY29tcGlsZXIgZm9yIGtlcm5lbCBidWlsZAogaWZkZWYgY3Jvc3Nf
Y29tcGlsaW5nCi0gICAgICAgIGlmZXEgKCQoQ1JPU1NfQ09NUElMRSksKQorICAgIGlmZXEgKCQo
Q1JPU1NfQ09NUElMRSksKQogCQlDQ19TVUZGSVhFUyA9IGxpbnV4IGxpbnV4LWdudSB1bmtub3du
LWxpbnV4LWdudSBzdXNlLWxpbnV4CiAJCUNST1NTX0NPTVBJTEUgOj0gJChjYWxsIGNjLWNyb3Nz
LXByZWZpeCwgXAogCQkJJChmb3JlYWNoIGEsJChDQ19BUkNIRVMpLCBcCiAJCQkkKGZvcmVhY2gg
cywkKENDX1NVRkZJWEVTKSwkKGEpLSQocyktKSkpCi0gICAgICAgIGVuZGlmCisgICAgZW5kaWYK
IGVuZGlmCiAKIGlmZGVmIENPTkZJR19EWU5BTUlDX0ZUUkFDRQpkaWZmIC0tZ2l0IGEvYXJjaC94
ODYvTWFrZWZpbGUgYi9hcmNoL3g4Ni9NYWtlZmlsZQppbmRleCAyMjY0ZGIxNGEyNWQuLmRhOGYz
Y2FmMjc4MSAxMDA2NDQKLS0tIGEvYXJjaC94ODYvTWFrZWZpbGUKKysrIGIvYXJjaC94ODYvTWFr
ZWZpbGUKQEAgLTExMiwxMyArMTEyLDEzIEBAIGlmZXEgKCQoQ09ORklHX1g4Nl8zMikseSkKICAg
ICAgICAgIyB0ZW1wb3JhcnkgdW50aWwgc3RyaW5nLmggaXMgZml4ZWQKICAgICAgICAgS0JVSUxE
X0NGTEFHUyArPSAtZmZyZWVzdGFuZGluZwogCi0gICAgICAgIGlmZXEgKCQoQ09ORklHX1NUQUNL
UFJPVEVDVE9SKSx5KQotICAgICAgICAgICAgICAgIGlmZXEgKCQoQ09ORklHX1NNUCkseSkKKyAg
ICBpZmVxICgkKENPTkZJR19TVEFDS1BST1RFQ1RPUikseSkKKyAgICAgICAgaWZlcSAoJChDT05G
SUdfU01QKSx5KQogCQkJS0JVSUxEX0NGTEFHUyArPSAtbXN0YWNrLXByb3RlY3Rvci1ndWFyZC1y
ZWc9ZnMgLW1zdGFjay1wcm90ZWN0b3ItZ3VhcmQtc3ltYm9sPV9fc3RhY2tfY2hrX2d1YXJkCi0g
ICAgICAgICAgICAgICAgZWxzZQorICAgICAgICBlbHNlCiAJCQlLQlVJTERfQ0ZMQUdTICs9IC1t
c3RhY2stcHJvdGVjdG9yLWd1YXJkPWdsb2JhbAotICAgICAgICAgICAgICAgIGVuZGlmCiAgICAg
ICAgIGVuZGlmCisgICAgZW5kaWYKIGVsc2UKICAgICAgICAgQklUUyA6PSA2NAogICAgICAgICBV
VFNfTUFDSElORSA6PSB4ODZfNjQKLS0gCjIuNDAuMQoK
--00000000000093c98706105cb0d6--