Received-SPF: pass (google.com: domain of linux-kernel+bounces-49111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 1 Feb 2024 18:42:21 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: "Hegde, Suma" <Suma.Hegde@amd.com>, naveenkrishna.chatradhi@amd.com,
	LKML <linux-kernel@vger.kernel.org>,
	Carlos Bilbao <carlos.bilbao@amd.com>,
	Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86/amd/hsmp: switch to use device_add_groups()
Message-ID: <2024020112-shrouded-ferry-7617@gregkh>
References: <2024012822-exalted-fidgeting-f180@gregkh>
 <0d110d2a-da0c-017a-0e5a-fc6bef7b066a@linux.intel.com>
 <e73426f6-6d50-4ed7-8613-1ec42fa3f991@amd.com>
 <2024020144-duplicity-nuptials-1cd7@gregkh>
 <f48ebcb1-8f87-efee-08ed-844775c995aa@linux.intel.com>
 <2024020138-monologue-claim-41d4@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2024020138-monologue-claim-41d4@gregkh>

On Thu, Feb 01, 2024 at 06:40:30PM -0800, Greg Kroah-Hartman wrote:
> On Thu, Feb 01, 2024 at 04:34:30PM +0200, Ilpo J?rvinen wrote:
> > On Thu, 1 Feb 2024, Greg Kroah-Hartman wrote:
> > 
> > > On Thu, Feb 01, 2024 at 06:50:33PM +0530, Hegde, Suma wrote:
> > > > On 1/29/2024 6:16 PM, Ilpo J?rvinen wrote:
> > > > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > > > > 
> > > > > 
> > > > > + Cc Suma Hegde.
> > > > > 
> > > > > On Sun, 28 Jan 2024, Greg Kroah-Hartman wrote:
> > > > > 
> > > > > > The use of devm_*() functions works properly for when the device
> > > > > > structure itself is dynamic, but the hsmp driver is attempting to have a
> > > > > > local, static, struct device and then calls devm_() functions attaching
> > > > > > memory to the device that will never be freed.
> > > > > > 
> > > > > > The logic of having a static struct device is almost never a wise
> > > > > > choice, but for now, just remove the use of devm_device_add_groups() in
> > > > > > this driver as it obviously is not needed.
> > > > 
> > > > Hi Greg,
> > > > 
> > > > Could you please hold on merging this patch for a week? I will push a patch
> > > > for converting platform specific structure's memory allocation from static
> > > > to a dynamic
> > > > 
> > > > allocation.
> > > 
> > > Push it where?  Ususally we do "first patch wins" type stuff, why not
> > > just do your work on top of mine?
> > > 
> > > Also, when you do make the needed changes, please remove the explicit
> > > call to create sysfs groups and use the default groups pointer instead,
> > > that will make things much simpler and avoid races in the code.
> > 
> > Hi Greg,
> > 
> > Well, if you really want to "win" :-), please provide an updated version 
> > which considers the changes already made in the for-next branch (the 
> > current one won't apply).
> 
> It applies just fine to the latest linux-next tree, version
> -next-20240201, what tree/branch are you referring to here?

Ah platform driver tree, got it, will rebase...