Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp599619rdb; Thu, 1 Feb 2024 19:46:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9t6zqCnb8fAFxFxEFHIT9GLP/O5sru67qkWAWH4nX+JZEGeKrMLiiEswKiOtLpLvUbsMB X-Received: by 2002:a05:6a20:6d19:b0:19c:8447:3994 with SMTP id fv25-20020a056a206d1900b0019c84473994mr6455644pzb.30.1706845615538; Thu, 01 Feb 2024 19:46:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706845615; cv=pass; d=google.com; s=arc-20160816; b=z+HF/lfQkDRD9vHGP1LSAMibEikxC5As3DMo7IuM1gASQt4vT8gFffEvBIHyiSU3ds u3vhIdr9xxcWN0CsCSnBkkntW/DFJ87RrgSgfSlXG48o80hXLRXLi3fV1RT+yXGG/ldJ 2mr6wHJt5yGL6FJk1hSvyXwNc5vvddZf1I+Nt+x0MPrt6unbkzDof9XIRDFb2o94qofm g5p5Z8nFWJt9K7Ty+cL+cm1JEmWWN4pW2BKdbLhwNfk2v8tclEYZ6ZPZq+6Loq42u9+F l+0T/W3al4AMwnPR7MX6AyISI1amRBgO/t5sld3Ooc5FQGqEE4UCV/E4vGPvts4wQZzo kQvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=CHvpMXUMGdEK8NZSD4CDZcVeSXClJT86ZXmiaqeEskk=; fh=pX6ylD+mEGxixfzXJNO7S1oP0TfRaLsGcVJ6ed/d9jQ=; b=Uodrx41tWGYLweDLPjCLCyK9t7xYUt7CTKoEPp3CrJM8s4nOmoDH3YI76GCzWOb2WP BGe5ZzWmhJ6IyOB/57zcna4P85meKLcPHPYbvVz2a/LNYucBSR6xI6iweHIu6Hnu/+Eb xLgvwDo57jzygUQFulLjwDxmIYZAuNbzyeOU2wWezG9U6aZDVBvAbCanGnUvC7xbUoWV Gk1hE7vEy5l2F2Kn+36sy5rLAEJHcehO6IYnK1aRTroGV60C+8IwjZ38INamxJwNn1ga 9TKfQAVNh8biLJZvUQgSKIdG/TtGkV1k3n9ziRniUMYn42bsqqqTp6cmAd6/N5y3KFdz TaDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AL5KciDQ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-49155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49155-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=1; AJvYcCWuUd7CmTRdOrxvOLwQs+fSyOlemY7C1R1Y4lugSy6x+OqIur2wU8n1j+xxXZX5n7XYwMs8EacgkOk6uiAxnE6GMYXkzK4hWiAd5Dqhbg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u14-20020a17090341ce00b001d8f07fa3desi1001086ple.376.2024.02.01.19.46.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 19:46:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AL5KciDQ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-49155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49155-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 36C4728D542 for ; Fri, 2 Feb 2024 03:46:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 27C08DDCE; Fri, 2 Feb 2024 03:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AL5KciDQ" Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D126EDF5E for ; Fri, 2 Feb 2024 03:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706845607; cv=none; b=pB8KfC2aCyDgrjElqrUV0bO8tf4ReyyzbnqoeuOaY8KMmCh/EcPdhAprYY6UnFaDJM/NVRGH5pzVsoJYVZ1wozSGE21O2X5MTl6UhjYvW/xDI36xpU26Gu6/PCr6m7Irq5D6Nge0cFyLrRbVX6HmMILyPvcMcev/xZv05DGpSig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706845607; c=relaxed/simple; bh=CHvpMXUMGdEK8NZSD4CDZcVeSXClJT86ZXmiaqeEskk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uclzHvLNGwEzgYXZK2xr1yyPoKnLu1vX9XFoGBX7uzKi5GPZ0HZLAZHmctMbR9oLfRcZ5nThZX5lm4+cA0WG7ugXwZzh1Cyq3fCcC42v/chjqmPbI24Y2y/YUXnxTNAEHtC+LR/8t2Jss0Q6I5tn+A0KstBBkzqpANTeuwh+iNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=AL5KciDQ; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-2191dc7079aso71861fac.0 for ; Thu, 01 Feb 2024 19:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706845605; x=1707450405; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CHvpMXUMGdEK8NZSD4CDZcVeSXClJT86ZXmiaqeEskk=; b=AL5KciDQ1Enc8Ph0lGvkcaTFXSsas6BtTihsGEB72WpVXHwmva56xO2UJmuooUG5p4 fJHcgvFgEg9ik9TA+AtEuwQ/hczcyakIoZG0NKvhDPgMQIMCsenU24ERHtzX7TmkId7E gtAmL6vVe0sjk/q06XnYH14LVnE7mBILZGQpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706845605; x=1707450405; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CHvpMXUMGdEK8NZSD4CDZcVeSXClJT86ZXmiaqeEskk=; b=n8uASd6PDcpZkhdx/YOFc13vGHAOzBcU1rfA0pUaCk8oDY5fgT3RC+g3FOxeHIbXBC HzIBCjWtjJHah1J/mpRdkfp++o4d2tz+l9hbkn4OWCj+LBEJ13gqxsNVehzAK9bJXeAO U879mxMnA9YIr8UT8VM4wgfi2LvY+rJ7ihBp5MnLV96tkyEVIOwI6Pfrd4pvATfyvu84 Y15vbtSDVWVk3/1qtYZKGrqYXDcMdPTmZ5dW0gndb4Ht+ja8zDYsknDS1H9RrQaLdKTB j4q8qe7Ly6X0diTTP1oHjp0e8Xcs80zawHFj7PJZMPfVQE+mhyVrTAlwfhzHaeiJLz9a 5TbQ== X-Gm-Message-State: AOJu0YyKgees/HUmyjTF/ErWh/ior2Lz1Id7JWtueKBrCGVHi3Ebrhi4 kto0eDgBm2BA6OwIRYQ80/jZ+Cva9UAnRBHmIGpD7Lht0BYdEmFVy8gtPKchZBO+eZ/ZSrU1Cq9 sk+ivz6HlsK7PZ+4p0Yz6warea+hKs217HtbW X-Received: by 2002:a05:6870:6c0a:b0:214:f222:5c67 with SMTP id na10-20020a0568706c0a00b00214f2225c67mr7988236oab.34.1706845604980; Thu, 01 Feb 2024 19:46:44 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240131175027.3287009-1-jeffxu@chromium.org> <20240131193411.opisg5yoyxkwoyil@revolver> <20240201204512.ht3e33yj77kkxi4q@revolver> <60731.1706826280@cvs.openbsd.org> <2024020137-hacking-tightwad-a485@gregkh> In-Reply-To: From: Jeff Xu Date: Thu, 1 Feb 2024 19:46:32 -0800 Message-ID: Subject: Re: [PATCH v8 0/4] Introduce mseal To: Linus Torvalds Cc: Greg KH , "Liam R. Howlett" , Jonathan Corbet , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, usama.anjum@collabora.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 1, 2024 at 7:29=E2=80=AFPM Linus Torvalds wrote: > > On Thu, 1 Feb 2024 at 19:24, Jeff Xu wrote: > > > > The patch Stephan developed was based on V1 of the patch, IIRC, which > > is really ancient, and it is not based on MAP_SEALABLE, which is a > > more recent development entirely from me. > > So the problem with this whole patch series from the very beginning > was that it was very specialized, and COMPLETELY OVER-ENGINEERED. > > It got simpler at one point. And then you started adding these > features that have absolutely no reason for them. Again. > > It's frustrating. And it's not making it more likely to be ever merged. > I'm sorry for over-thinking. Remove the MAP_SEALABLE it is then. Keep with mseal(addr,len,0) only ? -Jeff >