Received-SPF: pass (google.com: domain of linux-kernel+bounces-49185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 1 Feb 2024 22:19:15 -0600
From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, Zhang Rui <rui.zhang@intel.com>, 
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, linux-pm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal/of: Assume polling-delay(-passive) 0 when
 absent
Message-ID: <abgxh5s6e4w65iir2d3oncbwtmhufhg5xtyyukhsrrhe755gam@nhxeqsz35rxb>
References: <20240125-topic-thermal-v1-0-3c9d4dced138@linaro.org>
 <20240125-topic-thermal-v1-2-3c9d4dced138@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240125-topic-thermal-v1-2-3c9d4dced138@linaro.org>

On Thu, Jan 25, 2024 at 01:11:16PM +0100, Konrad Dybcio wrote:
> Currently, thermal zones associated with providers that have interrupts
> for signaling hot/critical trips are required to set a polling-delay
> of 0 to indicate no polling. This feels a bit backwards.
> 
> Change the code such that "no polling delay" also means "no polling".
> 
> Suggested-by: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  drivers/thermal/thermal_of.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 4d6c22e0ed85..61bbd42aa2cb 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -225,14 +225,18 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
>  	int ret;
>  
>  	ret = of_property_read_u32(np, "polling-delay-passive", pdelay);
> -	if (ret < 0) {
> -		pr_err("%pOFn: missing polling-delay-passive property\n", np);
> +	if (ret == -EINVAL) {
> +		*pdelay = 0;
> +	} else if (ret < 0) {
> +		pr_err("%pOFn: Couldn't get polling-delay-passive: %d\n", np, ret);
>  		return ret;
>  	}
>  
>  	ret = of_property_read_u32(np, "polling-delay", delay);
> -	if (ret < 0) {
> -		pr_err("%pOFn: missing polling-delay property\n", np);
> +	if (ret == -EINVAL) {
> +		*delay = 0;
> +	} else if (ret < 0) {
> +		pr_err("%pOFn: Couldn't get polling-delay: %d\n", np, ret);
>  		return ret;
>  	}
>  
> 
> -- 
> 2.40.1
>