Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp656144rdb; Thu, 1 Feb 2024 22:50:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVABwOW75Q/k/X+q2CsikGBOynJsh/BDyxN9MHZzPrYf2worlDsdv4M39ywLL7/C3lGxyl X-Received: by 2002:a17:902:e84d:b0:1d9:592:c301 with SMTP id t13-20020a170902e84d00b001d90592c301mr8345113plg.3.1706856626018; Thu, 01 Feb 2024 22:50:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706856626; cv=pass; d=google.com; s=arc-20160816; b=dcVzUFke0X9r6rtljihR3NlNQwlqiK3t+PrBqX5voK4JIbGhyak5hUXvM7OM5oLxlI yvCJwvbFJvyZY46LwtMiyly0YFvs147VEDCBM2pFTSquVzQUqAMvcL49jhcXgWWjB+LV fHaETykPBLlMsQ5WXcTyQXaKvF5/GuBBVXaYg+67O+bp0+qnLaZyXq2CQU776tQ0/+rn yJ7A5UqsMwX9m7vjpIL7iEsNNh8BlUoXmGALEmi4I2u61DOh+bAhF48SfIbHaLWmow9b +BxMnOcnH/J08a1FZXyYJn8Nm0Nku+Sfn2eU1F1NglNK4Pqe0EIWlVxb/ZxxDaZJsuvt /30w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to :content-language:references:cc:to:from:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=psDefbg/kF79ASsUkMz1eS3sAKLVErIE1EEhmYhufuA=; fh=aDubJb55LvADvp34rjpFzdS5YMPxI5umdxTHjwWrQNM=; b=d9YSqxn5/xuogdcPaA9yDq4CZZThfQTLP4sVors4Foy9WwYioXRaDykNIE5XeHiwRy mG7OKpzEwMyLSG629yYIZLSPN+PMeWNnFU0IQ5SLP9K++GKBBPNRcTG09J1Muz+eBMCw KU6MYwIw2brXldiIO07OfqgN1wKIxyBSO/cG4bd1mt1u5fd6r6AVttHcZlyjBAtgjaa0 90wQxPdkGgtzVU4FwM2CJZ+Pldc9fHjAHLMFOrBc98OpJJsZTyEJRWhyGGVxWsnOrlRO Gc6nXB+Tc6UcJKjA03s6b0F+FU2CQL6fOgDxeV+sJALfE69t6LNZ8te3h3P/2odgRwaw JHPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=t9BJDGgW; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-49309-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49309-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de X-Forwarded-Encrypted: i=1; AJvYcCW4KcqB7VHpx/lM+B27jq0ucqTmfsfxbSwOBF9CC0zL1aoE+pqKMSm7BGQfmoc2vx66Fazro6nrJM5GXYXUM+6Ezh5iRbDObO/2WCeonQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v7-20020a170902b7c700b001d8fb259198si1166302plz.492.2024.02.01.22.50.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 22:50:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49309-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=t9BJDGgW; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-49309-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49309-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5D0B928391B for ; Fri, 2 Feb 2024 06:50:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E96D417C6F; Fri, 2 Feb 2024 06:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="t9BJDGgW" Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB81F4EA; Fri, 2 Feb 2024 06:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706856569; cv=none; b=tIrQG2U7xAZg0OqfFXBz/O3/xVWZ+Hv/b4snhuoUys64tG4ca79BJoTeTJWXpCxAZ8B82lNCDYZA49z841LJRRmlkiBmg8O8oxW1W2IEY1qXQlcyNu0HchrWs8ZfET/KL1wYNomRrzYv3wGFNoAPwxyk9A7RdmDXlQNHuHoi39c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706856569; c=relaxed/simple; bh=psDefbg/kF79ASsUkMz1eS3sAKLVErIE1EEhmYhufuA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=ZYdWNvzqdL6za9U7CpSqhBrRw+famd8de4iPEyu0MUjVaPRRdx2s39eTwaTs1vt7M69vwbAIkrwTRCOyCAyqvvL+7PchYMy8G9h+7MnfI1wSN/lQmLPAVMhIXQRf2MmXlehbzoeZc31wqrjtnB/CKnK5ecKBmlRzw+2tG8yAoFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=t9BJDGgW; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1706856523; x=1707461323; i=markus.elfring@web.de; bh=psDefbg/kF79ASsUkMz1eS3sAKLVErIE1EEhmYhufuA=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=t9BJDGgWqQZpeFoMDHQfgB/19gTb7Ka7GBGci1F4B4+NY0oCAUhbFu02S9quGB5N VU56dTABaPIQQfnCpIPZ2xsAkuqmbvmbHSTnLTpTNXWSgVpHmhp/QnnS0BlfchARv UEmsAwZy8R4tZV4nx9y2NcVxPou+Idt+UdDQx9I/6VnXFYpr+5Mxacst8hQjNZlhC xOYkBeOHfPkCKtBELx5vHDtPz0dZBS4sgoLMT6l340L/rT4xByQwgRhUb8f1ytgoS LB/q9otFpW/Y5UeYEjtg23XWUnMuzlsJKseh7QNZ2Rq/FGhdDKb1Azk2VgRAogEiC 3bmO5CqVGOqpNgkldg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.81.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MhFhe-1qsazJ31Zi-00ea4g; Fri, 02 Feb 2024 07:48:43 +0100 Message-ID: Date: Fri, 2 Feb 2024 07:48:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] perf: Reconsider an error code selection in bpf_map__fprintf() From: Markus Elfring To: linux-perf-users@vger.kernel.org, kernel-janitors@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Alexei Starovoitov , Andrii Nakryiko , Arnaldo Carvalho de Melo , Christy Lee , Daniel Borkmann , Ian Rogers , Ingo Molnar , Jiri Olsa , John Fastabend , KP Singh , Mark Rutland , Martin KaFai Lau , Namhyung Kim , Peter Zijlstra , Song Liu , Yonghong Song , YueHaibing , bpf@vger.kernel.org, netdev@vger.kernel.org Cc: LKML References: Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:guMMD0U0owRRTK/o4x0F68hE8U9JJPElbEE4i3GuJqzHWW1R2HT sH0Z4EGWRndq02j10zfeOmlFsuMWcTocY01WQzj55IfTx2GEaofd0UiNkmU5Hp8wE3DRUxA 66EGuYd+WeO0W1n9MgablveKN3xDoAC58LZZzpDfV0+2DysblxvSm6H00vhzfZDimtVJV/z CwSuyAopcmm7tc3oD4wnQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tyHFUlgJYw0=;dgrK/DspkpssIY/mInw6RaOj8L8 zzTf2dKbygFIyNv1oeJDdblOrP8EvVmHFVb/iQ+pEefr1xabU/7uEb27OtwF4VSNs0vLi2jk8 obLgtu7m3UCnrc9+Pluirh/Qin4j2TrTt/FlgXhWLcI0M2dmQaryGHZDcJJ59zolxXk3XTQuc bo1oBNAXbwcsXCjQ/RUburT/XB972gvl5v/EnKYR/mNlRc9OrQibc3bMp/CgbHKTtCx23hrs0 E41dZKGXOjSL+RRFEVYGGe5HrWQzlzEtolFjP+aNR+1B/Zfi4kqdPENTbdJ3XHTqnSOvwpva3 vZGUOCLhRj5wE80z2Jxhhzf6LRzDB7apmxyv+D6NphmrNUYLjPGcivWh1IlVPH1dYMsBsoBQ2 SSO2KXlKVqKk1UEQP4wX6sU/cyKVHdapsY7Ljl71uyV4puxHx7l0nVSRJJilMkXs2iPvW89vX xg/r6zE2uX72n2+jmgHyrlaG2vgHfbwY8v5cytJQ2Df7TvHNgB94TRFDfp54mpkapKdEhg2ZA fhJ0JRzs4maXDk2sHPSNVx4by61OKVSGIRBPXA5aHTLxBCllAa2GGw5BQjEbYs6tmb4xVkGJK ISu3URZrlraZX+kFLKoSiovCKbEeYsSXkJNbLMkYrrFr+srhnT3IvD5ZW06zzXNQjmwctMc0t LoZdb9BY6Kw0C3nygGghSdp56duAB/QATwqfnxIVW9Nx7eYebs2h8pKTJnTMT+uMH8h7k11Eh a6Xx2JU42qVyh8Ornsp2Q13xHM0+huJJE98UY0cruVDOT/VG6RBjXVm0+IsMRSRorXAK7Wci7 lQ7yquTHQffUVxsPE8zuRXAwbLnwE8zF0Xd44K6SiYsYg= > A null pointer check is performed for the input parameter =E2=80=9Cmap= =E2=80=9D. > It looks suspicious that the function =E2=80=9CPTR_ERR=E2=80=9D is appli= ed then for > a corresponding return statement. Are contributions also by YueHaibing still waiting on further development = considerations? [PATCH -next] perf: Fix pass 0 to PTR_ERR https://lore.kernel.org/lkml/20220611040719.8160-1-yuehaibing@huawei.com/ https://lkml.org/lkml/2022/6/11/3 Regards, Markus