Received-SPF: pass (google.com: domain of linux-kernel+bounces-49310-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 2 Feb 2024 06:49:38 +0000
From: Sakari Ailus <sakari.ailus@iki.fi>
To: yuji2.ishikawa@toshiba.co.jp
Cc: hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
	mchehab@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	nobuhiro1.iwamatsu@toshiba.co.jp, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 4/5] documentation: media: add documentation for
 Toshiba Visconti Video Input Interface driver
Message-ID: <ZbyQgkGicrnP-XZL@valkosipuli.retiisi.eu>
References: <20231012071329.2542003-1-yuji2.ishikawa@toshiba.co.jp>
 <20231012071329.2542003-5-yuji2.ishikawa@toshiba.co.jp>
 <ZV3oq0szH8JjSNsc@valkosipuli.retiisi.eu>
 <TYAPR01MB620180FF82B8993B45FF6E0A9286A@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYAPR01MB620180FF82B8993B45FF6E0A9286A@TYAPR01MB6201.jpnprd01.prod.outlook.com>

Hi Yuji,

On Mon, Dec 04, 2023 at 04:32:40AM +0000, yuji2.ishikawa@toshiba.co.jp wrote:
> > > +Vendor specific v4l2 controls
> > > +=============================
> > > +
> > > +.. _V4L2_CID_VISCONTI_VIIF_MAIN_SET_RAWPACK_MODE:
> > > +
> > > +V4L2_CID_VISCONTI_VIIF_MAIN_SET_RAWPACK_MODE
> > > +--------------------------------------------
> > > +
> > > +This control sets the format to pack multiple RAW pixel values into a word.
> > > +
> > > +This control accepts a __u32 value defined as `enum viif_rawpack_mode`.
> > > +
> > > +This control should be set before ioctl(S_FMT) and should not be changed
> > after that.
> > 
> > Why do you need this? Doesn't the V4L2 pixelformat already explicitly define
> > the format, including packing?
> > 
> 
> This control value affects the unpacker between CSI2 receiver and ISP.
> The rawpack mode is an option to receive from Wide-Dynamic-Range image
> sensors, whose output bit width is larger than standard format (RAW20,
> RAW24). For example, some WDR image sensors split 20 bit value into
> upper/lower 10bit values, then put them into consective pixels to make a
> double-width RAW10 format image.

Do you have a sensor that really does this? Which one is it?

> 
> This option is only related to the interpretation of CSI2 input data.
> Therefore, I think V4L2 pixel format (for resulting image) is not related
> to it. The media bus format seems more relevant, but there is no
> corresponding definition to this case.

-- 
Regards,

Sakari Ailus