Received-SPF: pass (google.com: domain of linux-kernel+bounces-49323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <4fae04008c6d4abadd89463d376cfd7c4d98675e.camel@gmail.com>
Subject: Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
 "a.zummo@towertech.it" <a.zummo@towertech.it>,
 "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
 "jdelvare@suse.com" <jdelvare@suse.com>,  "linux@roeck-us.net"
 <linux@roeck-us.net>, "robh+dt@kernel.org" <robh+dt@kernel.org>, 
 "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
 "antoniu.miclaus@analog.com" <antoniu.miclaus@analog.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org"
	 <linux-kernel@vger.kernel.org>, "linux-hwmon@vger.kernel.org"
	 <linux-hwmon@vger.kernel.org>, "devicetree@vger.kernel.org"
	 <devicetree@vger.kernel.org>
Date: Fri, 02 Feb 2024 07:56:18 +0100
In-Reply-To: <c69ab341-468a-4bca-96b7-793342c421a7@alliedtelesis.co.nz>
References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com>
	 <147c92f9-b42b-4a51-a6f9-2d90bfe63aa0@alliedtelesis.co.nz>
	 <1b42866bb6f05b7d68e9b8304e42359fccdf2bad.camel@gmail.com>
	 <170c8d6b-3246-493f-8cd9-6ac580cabc28@alliedtelesis.co.nz>
	 <84827fd6461c9650443608e33afe9eb011793656.camel@gmail.com>
	 <c69ab341-468a-4bca-96b7-793342c421a7@alliedtelesis.co.nz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-02 at 00:28 +0000, Chris Packham wrote:
>=20
> On 29/01/24 20:55, Nuno S=C3=A1 wrote:
> > On Mon, 2024-01-29 at 03:28 +0000, Chris Packham wrote:
> > > On 26/01/24 20:51, Nuno S=C3=A1 wrote:
> > > > On Fri, 2024-01-26 at 02:22 +0000, Chris Packham wrote:
> > > > > Hi All,
> > > > >=20
> > > > > On 4/04/23 03:43, Ibrahim Tilki wrote:
> > > > > > changelog:
> > > > > > since v5:
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: add enum value "2" to au=
x-voltage-chargable
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: remove adi,trickle-diode=
-enable
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: change description of tr=
ickle-resistor-ohms
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: reorder as in example sc=
hema
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - parse "wakeup-source" when irq not r=
equested
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - remove limitation on max31328 irq an=
d clokout
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - remove error and warning messages du=
ring trickle charger setup
> > > > > >=20
> > > > > > since v4:
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: remove interrupt names.
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: add description for "int=
errupts" property
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: replace deprecated prope=
rty "trickle-diode-disable"
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 by "aux-voltag=
e-chargeable"
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: add new property "adi,tr=
ickle-diode-enable"
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: remove "wakeup-source"
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - use clear_bit instead of __clear_bit
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - use devm_of_clk_add_hw_provider inst=
ead of of_clk_add_provider
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - use chip_desc pointer as driver data=
 instead of enum.
> > > > > >=20
> > > > > > since v3:
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - add "break" to fix warning: unannota=
ted fall-through
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Reported-by: kernel test r=
obot <lkp@intel.com>
> > > > > >=20
> > > > > > since v2:
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: update title and descrip=
tion
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - dt-binding: remove last example
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - drop watchdog support
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - support reading 12Hr format instead =
of forcing 24hr at probe time
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - use "tm_year % 100" instead of range=
 check
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 - refactor max313xx_init for readabili=
ty
> > > > > >=20
> > > > > > Ibrahim Tilki (2):
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 drivers: rtc: add max313xx series rtc =
driver
> > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 dt-bindings: rtc: add max313xx RTCs
> > > > > >=20
> > > > > > =C2=A0=C2=A0=C2=A0 .../devicetree/bindings/rtc/adi,max313xx.yam=
l |=C2=A0 144 +++
> > > > > > =C2=A0=C2=A0=C2=A0 drivers/rtc/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 11 =
+
> > > > > > =C2=A0=C2=A0=C2=A0 drivers/rtc/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 1 +
> > > > > > =C2=A0=C2=A0=C2=A0 drivers/rtc/rtc-max313xx.c=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 | 1053
> > > > > > +++++++++++++++++
> > > > > > =C2=A0=C2=A0=C2=A0 4 files changed, 1209 insertions(+)
> > > > > > =C2=A0=C2=A0=C2=A0 create mode 100644
> > > > > > Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > > > > =C2=A0=C2=A0=C2=A0 create mode 100644 drivers/rtc/rtc-max313xx.=
c
> > > > > What happened to this series in the end? It kind of went off my r=
adar
> > > > > and I forgot about it.
> > > > >=20
> > > > > We've been carrying a version of these changes in our local tree =
for a
> > > > > while (and using it quite happily I should add).
> > > > >=20
> > > > Hi Chris,
> > > >=20
> > > > Also not sure.... In the meantime Ibrahim left ADI so if this is no=
t in
> > > > shape to
> > > > be merged he won't be able to re-spin. If there's a need for a re-s=
pin,
> > > > please
> > > > let me know so I can see internally if there's someone who can cont=
inue this
> > > > work. I would do it myself if I had the HW.
> > > I've got a board with a max31331 so I can test that. I don't have any=
 of
> > > the interrupts hooked up so I won't be able to test that. Looks like
> > > there was some outstanding discussion around the trickle-charge
> > > devicetree properties so I'd need to figure out what was wanted there=
.
> > > I'll try to pick up the last series from the mailing list and go from=
 there.
>=20
> I see that in the meantime Antoniu has landed a max31335 driver. Does=20
> anyone know off-hand how close the max31335 is to the other max313xx=20
> variants? Should I leave them separate or attempt to integrate the two.
>=20

Hi Chris,

I did not looked into the devices datasheets but typically, if the register=
 map is
close enough we should try to integrate them in the same driver.

Thanks for continuing this work btw!
- Nuno Sa