Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp667845rdb; Thu, 1 Feb 2024 23:21:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/CNpOH13a/iFpfOWgy8eYJ57oA6jP4QYNHnRApeRdKkz/s5D1oXR1Y8F/FxZ28H+RYv/4 X-Received: by 2002:aa7:c690:0:b0:55f:b09a:7211 with SMTP id n16-20020aa7c690000000b0055fb09a7211mr706171edq.7.1706858503319; Thu, 01 Feb 2024 23:21:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706858503; cv=pass; d=google.com; s=arc-20160816; b=k1joELZL3Surdyh3zlqPjIpJkpoQBqMJ6TIwcThtIzbIssQcAMRVDfWLlrNDlObXaE H2OP8y2+b4kGq3QIu+z2/kteg4mPpokKusx/jj02osMa/yEtEvatyFA60SutyImtPbsY bSoqeBox2CvUy8XcCNSjZsTSgT46FfEMzzIeWplkmyUOcenKIXUwfebNUUdqKBjKUuBC txq1o6NdqL9Vul/Ms6xutEaZddZ3Vh4edZHTPjSog8Icg8LKUoxe221GDe2k6yXurbmR r1SBtktkPqbyONmpxDPZ5F5nxeetWvbAVJP/Xyb0RRuT0+IGaSPEGYr4HrjKDnzsylIj 1TKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rynCR7DUuWYPX0uSmJQ3t5lmPk1yuAmXaxIJOHoQI7E=; fh=dglUiRSCORxQj89OdG8IB+4GTzzfwCNzkkHuKpnqJ7k=; b=mQZwLt11qlIj+jwLhKtYXz5Ymzx1h7i67CfqCbORA1ittdXLnVNAcSPq6oxX4hSH9d ZTkpbtpL9lkH/d387O9FGKXs9pWa4wfRQpcr01zTWdNRzJbYOIrt/VMefTPVErQc6hmS CwvYNfhuk4vRazjIq7V7U+Mwl3fltr8I0NOUeZUGZKRbKdKtbrUYJBMF1mHZqpx0JIaB Nrv7a9ix2C9lvTTS09iLA9GVfcjrk5oHWR7Moqc8TGUFtdVE8X7V31UfLmwA8DECBeFO D0P5z9xcaSEuPL2cSBPtJUVqnUrxJ5RFpsNbahUHmsSteYExIH5bJPPlsqCqgloYs80F eJZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rYDSX1x4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-49362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49362-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCXO3H0pRRnkMKzCAelhdNBgNNbgKZfJa6pdgKU9ertdf7zvYd/4HBU2N6lOKxzQhI60zccyD5lIhlQ8OZbs2RguVzvT8XZVA2ynHrV6RA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id c17-20020aa7c991000000b0055f5cda6059si540049edt.536.2024.02.01.23.21.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 23:21:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rYDSX1x4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-49362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49362-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 067BE1F27529 for ; Fri, 2 Feb 2024 07:21:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E1F517BD8; Fri, 2 Feb 2024 07:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rYDSX1x4" Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF8317BBA for ; Fri, 2 Feb 2024 07:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706858479; cv=none; b=JEKWAzj5EKbD5EMB8K9vNPrqupqA1SYCalObOXbXMsm5lI0xjWlv0kxwiJ9kuCQ1+DHaAl0d85rlvrcHHwP8pUKtI+bQS2iPeps01KKnuaXWtt7HuYo2odq4WrrpXZYNxcTMXcS7M6uvfwPIF9IJUTKKn5J1JaktfnU76mYLwsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706858479; c=relaxed/simple; bh=lpTM8i3qAGSiY4E67knpu4ci12EK/1WfR/fXKv773eM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MyyePNnFp8j1xvG3PyYp5kgueIjU8lGiSlew8XRL9HRtL5cmEg+FJDz1xaJJ7BJA/NlFl3wJMJ8BzO8dFI6HwLvA6Z6FDcjVGuLUJKN/9QU75TFtktxCjlovyLcR2pjDB76fVTw4sDuc4LeE4gS9aRSOg3oXF1lE7SDzNzCSfMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rYDSX1x4; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a35b32bd055so228138966b.2 for ; Thu, 01 Feb 2024 23:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706858476; x=1707463276; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rynCR7DUuWYPX0uSmJQ3t5lmPk1yuAmXaxIJOHoQI7E=; b=rYDSX1x46/VjrLR9A2yUp8d5IV8+fIL+MJrJiCRcdUsBvIBX+LJG+uG71pSe5Pntl/ Eg9IhAstzam6OJOtY4DzgIUDPB5oof6flPpwhw7bStvQYYhGfXK3QB/6Xs7DvbuLLyn/ ubdFTaJiAFkEszCAFol8NzNczjhg6suAmVIKwF046SqgwTWQpZT++84ROVVNVgiIoozh fppK+JzPLKajXmgkmkPWtsi2WjwQd3krpU+1vvEZCRsbxrKP6+dfcnpF3+iMrZ899bfv jEuI3eiYKsEhK7hrcRmdKgGm48jfcH7tPB+7EvBMU9GPrFIkfJec07Hp81U3Ltd26RsL hoJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706858476; x=1707463276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rynCR7DUuWYPX0uSmJQ3t5lmPk1yuAmXaxIJOHoQI7E=; b=GVmvoFuDaDholD3MqPjd8KxsvEpAe+EzhATM1SeDIVeaQGNawKg9XSOn8WBmc20l0s rfuP7XipmbKDLIDp2j4FfbuBbqjb/n8EwrzMGkdZfE5oVAHV8EYeZd7wUxefonLz/SY6 Xlpc8sJ5qbmo1i4va/p6TD7cEpWZuZfXDqclh7onmgi8a58EiT2Kh6HRCaEQ3Gmnm4iW VXhNn6wx4EyaHIvT2EPSFYDH9pUcNENr53RE8cAcXKpCef73vaVYzU1umsWrn8QNjsrE fQzAFr5Zsu3ymHzYxXp4O+wIGCOa89W6Hovr77bPLzg8AIRJJ9zzU0yruei/9zRR+rHj TEvw== X-Gm-Message-State: AOJu0Yy5Dv2y0v/9lKhymYudPp/5CIljKwQ63utAPNlGfdR6prz5wgkE 9bFNttcHXz5TXZkHhGYwAe/UCFYyii2rQw21IxxZ/ep1hzJjOHdbx+Fua9PGVCA= X-Received: by 2002:a17:906:304e:b0:a30:4189:4e10 with SMTP id d14-20020a170906304e00b00a3041894e10mr786033ejd.53.1706858475842; Thu, 01 Feb 2024 23:21:15 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCV7YI6mqnDVH0uFCEJYm+8NVVZE/Nt68934vPNYx8qXgR5csU5taYye9/7ohZBqK8bkwv/fwawi/urQuvGLGFSrs3JWDyUDCxAoK41JGw3j6qmFCPnzSVaINsHsGoGIjpX+VuSDMI2sFJRhrD5fo5FQLA66O6PdL5XQllsK6gPC86qxRc1zzTxuOXfM6J70RPVOmHPEEmDmVg8bPVQkowIZ5C54FYPsrQmCjrCoihKezjIXQwh1thzPtcOyGWMf6uopIEd0eEba+UTpBw== Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id un1-20020a170907cb8100b00a35de0619dbsm567619ejc.200.2024.02.01.23.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 23:21:15 -0800 (PST) Date: Fri, 2 Feb 2024 10:21:08 +0300 From: Dan Carpenter To: Meir Elisha Cc: Greg Kroah-Hartman , Hans de Goede , Ruan Jinjie , Yang Yingliang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] Staging: rtl8723bs: Remove extra spaces Message-ID: <78dc8263-b866-4d44-9f02-194c8a79fccb@moroto.mountain> References: <20240201140459.438479-1-meir6264@Gmail.com> <20240201140459.438479-3-meir6264@Gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201140459.438479-3-meir6264@Gmail.com> On Thu, Feb 01, 2024 at 04:04:57PM +0200, Meir Elisha wrote: > Fix checkpatch warning: please, no space before tabs > > Signed-off-by: Meir Elisha > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 63 ++++++++++------------- > 1 file changed, 26 insertions(+), 37 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 5568215b35bd..44b77c1ba992 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -169,7 +169,6 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwor > { > unsigned int delta_time; > u32 lifetime = SCANQUEUE_LIFETIME; > -/* _irqL irqL; */ > struct __queue *free_queue = &(pmlmepriv->free_bss_pool); > > if (!pnetwork) Please the "delete dead code" stuff into a separate patch. It's a little bit easier to review when patches are split up like that. regards, dan carpenter