Received-SPF: pass (google.com: domain of linux-kernel+bounces-49373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: Simon Horman <horms@kernel.org>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "bcreeley@amd.com" <bcreeley@amd.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad
 Kelam <hkelam@marvell.com>,
        Suman Ghosh <sumang@marvell.com>
Subject: RE: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Thread-Topic: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Thread-Index: AQHaU+79TbtFO2tBSUm3sTNVRXPo/7D1OvSAgAAAf0CAAHO5gIAA+xdA
Date: Fri, 2 Feb 2024 07:32:40 +0000
Message-ID: 
 <CY4PR1801MB191155E0D21759A56CA0B8B6D3422@CY4PR1801MB1911.namprd18.prod.outlook.com>
References: <20240131024118.254758-1-rkannoth@marvell.com>
	<20240201093119.GB514352@kernel.org>
	<MWHPR1801MB1918CFDBEC70A298A3781945D3432@MWHPR1801MB1918.namprd18.prod.outlook.com>
 <20240201082717.7b946987@kernel.org>
In-Reply-To: <20240201082717.7b946987@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Vr0Xql8JBqCoaR6BDIblQ++mB2CnGPC48AK3+pBwt6wakGRmxxWgzeBc4USk?=
 =?us-ascii?Q?7n6ZusElmQnRyE20UVURSMWCeOMYcMaxl/O9x8EcL+lZU0xRet8MrhOkXMOS?=
 =?us-ascii?Q?8J8F5H+QupHSVjn5gMRxuURvR1km2hp3HONWf9cTexSkLL+sRHwunm2awOub?=
 =?us-ascii?Q?fpgJPIcSu0vur3Lq90XF/ZgmTwSkWYkn9IaOmXsfVLjFGaru19CrVjdL1ddb?=
 =?us-ascii?Q?fP18RYmn1IgQbSccrcL6eir6hM+9HIt7BK42xFAW/BB3ZF6f4lGEtH3NFgLq?=
 =?us-ascii?Q?NaeVcUg2oSi1ugtTUbK/PJsc96PhnVMmOd/UjTGZjOG3Ub5M6jS3eWTawZhK?=
 =?us-ascii?Q?RhqKwh5EEz7JCNbV8fW8sG5i1a2qE2L86MRG3xwYA16N5K3n6nenlWfq7m2r?=
 =?us-ascii?Q?fvZ3VGuWJarxFN9jfDOWb4Gd8i5FWmjtkvFaRahBjkPmscuncElYgFOn1hZb?=
 =?us-ascii?Q?9GNn5fkAunfffwpEjJSUcpoLsFwfJDF8ibOKFMVBZBgEo3pkC1cPiXg4grNT?=
 =?us-ascii?Q?ePMP2GvkfXRJ+Sobn6B+/6GiUVOQUPQjDW20Ot0UUo3L9XQ7ZGMMsSug5bzP?=
 =?us-ascii?Q?CbyhweBlfY6/G6dzcImjyOo1xCSunKVuYpgqsBX/F6vFATat9BU1pJPPRpHu?=
 =?us-ascii?Q?Qf2ABnnQM8kzuJUaBPIGqTcEWpobYybTvVMxtXDpgyuT+RpK/K+Dm0PRqJwG?=
 =?us-ascii?Q?p6XkL3IxtqA3OHEHUyVyBTyGjWh1S3QujPmJ1ET+Jd2yE2MeK5/Pw5/fGrX0?=
 =?us-ascii?Q?XHn+nol3yqWBfFiJrLs9fie8Dn+NOdXiNaUBf88moPER+PaP9enMUXT3PmRW?=
 =?us-ascii?Q?4AfPP2gIJ8MTSuM3nfm/lEsU/G7Jg42EJyOGaWSGCS1AueZXPxMQi3kbhjI4?=
 =?us-ascii?Q?CS4dYdRnYYZhYN3EUnM28YLuga56bLi7JJyvTbCcB/p8MVavlDfQE9djOGZZ?=
 =?us-ascii?Q?BeqV0whjPPRWQrp3kIjdFvh0yVDHdLAx5Q8kdKH7Ilo5xlnQDMSBaukYNHG+?=
 =?us-ascii?Q?ixFLfKDtgdqMNHi+UbYMZRjVxCQsrCmtZ297go79hylC+KiKzJxz2WfeU4vL?=
 =?us-ascii?Q?vRAk5OuRt9Dw1v47EatalMSXSaZKLXqYtnh708z+G8Ly+wLn7yHbRXZmHMJh?=
 =?us-ascii?Q?5U7Ho9ERNEVdJzpFN5wfVkHR5W3DCO+6NgdBdlO3DiaLRMFcbqV/qJysTM2J?=
 =?us-ascii?Q?zEBFe554ij499J5YEyI6jdiPjbIho1IxvbiGjobyzUAJHmoWDIUBL4OObWEy?=
 =?us-ascii?Q?IqI+rVWTgyL3YNsuLts0J1CRofXDir7MZ1xRxRMpXxT6tEUFC72O2cVPA8Pr?=
 =?us-ascii?Q?hkkVNoJh7jE5FErfdSfRmNc1TKpuDauF9pmnZIlzbf1aAy/ilPG+7Ond5GUG?=
 =?us-ascii?Q?eDRK4uGdTQI5hQUZb6+zg8ul6qNUTZUE2p7pj3NXIth48W9A/cpqhAVvX5mR?=
 =?us-ascii?Q?ljH4zL4sLZS6YESNLW7IwUF1x7SsNuqDC5RPmZpe6B0jpV3M75rcSLh22LwP?=
 =?us-ascii?Q?Dy0/lx1Msryr2JNaifbN6PSHDcO9iz+IKXhry2zB9DnofKrMzX6bXkQd87nH?=
 =?us-ascii?Q?50DozL7wRWxaFSubBt7W0HZwaolyPwAJzbmm9wWA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1911.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b41de74b-c9bf-438d-3f96-08dc23c12306
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2024 07:32:40.2581
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HcAx7SMvOlTVcG6iNEcdiwT+hImwDUr/xDB1l55XszWEwOXd3CBLGN2L+hyj70n1/Y6ryq5x9GRW/aHi6K5gEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5624
X-Proofpoint-ORIG-GUID: zH40aup5BXY6aEtjalBzIa11dGw3eDeV
X-Proofpoint-GUID: zH40aup5BXY6aEtjalBzIa11dGw3eDeV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-02_02,2024-01-31_01,2023-05-22_02

>From: Jakub Kicinski <kuba@kernel.org>
> Subject: Re: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
>=20
> On Thu, 1 Feb 2024 09:35:15 +0000 Ratheesh Kannoth wrote:
> > > The use of bitmap_zalloc()/bitmap_free() looks good to me.
> > > But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I
> > > think
> > > kcalloc() is the way to go.
> > Kcalloc() is a wrapper around kmalloc_array().  Why do you think
> > kcalloc() Is better ?
>=20
> Are you genuinely asking for an explanation why
> kcalloc() is better than kmalloc_array()?=20
Yes.

>It's an equivalent to the standard C
> function, calloc().
Thanks.=20
>=20
> The reviewers are the most valuable part of this community, we will not t=
ake
> frustrating them lightly :|
I learn a lot from review comments provided by this community and do value=
=20
them. I am sorry if my "English" sounded harsh.