Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756065AbXLTEM2 (ORCPT ); Wed, 19 Dec 2007 23:12:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754011AbXLTEMT (ORCPT ); Wed, 19 Dec 2007 23:12:19 -0500 Received: from namei.org ([69.55.235.186]:49299 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754034AbXLTEMS (ORCPT ); Wed, 19 Dec 2007 23:12:18 -0500 Date: Thu, 20 Dec 2007 15:11:40 +1100 (EST) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: David Chinner cc: lkml , linux-security-module@vger.kernel.org, Eric Paris , dhowells@redhat.com Subject: Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning In-Reply-To: <20071220014413.GK4612@sgi.com> Message-ID: References: <20071219093834.GW4396912@sgi.com> <20071220014413.GK4612@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 38 On Thu, 20 Dec 2007, David Chinner wrote: > > I'm not sure I understand your namespace pollution issue, either. > > doing this globally: > > #ifdef CONFIG_SOMETHING > extern int some_common_name(int a, int b, int c); > #else > #define some_common_name(a,b,c) 0 > #endif I suspect it may be useful ensure all global identifiers for the key subsystem are prefixed with key_, as 'copy_keys' does seem a little generic. > > +#ifdef CONFIG_SECURITY > > +extern unsigned long mmap_min_addr; > > +#endif > > + > > #include > > #include > > #include > > Fine by me. I'll queue it for -mm & 2.6.25. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/