Received-SPF: pass (google.com: domain of linux-kernel+bounces-49763-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <694382da-8d3e-4092-8a52-1982f655aca1@intel.com>
Date: Fri, 2 Feb 2024 12:37:54 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 11/21] tools: move alignment-related macros to
 new <linux/align.h>
Content-Language: en-US
To: Alexander Lobakin <aleksander.lobakin@intel.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
CC: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>, Marcin Szycik
	<marcin.szycik@linux.intel.com>, Wojciech Drewek <wojciech.drewek@intel.com>,
	Yury Norov <yury.norov@gmail.com>, Andy Shevchenko <andy@kernel.org>, "Rasmus
 Villemoes" <linux@rasmusvillemoes.dk>, Alexander Potapenko
	<glider@google.com>, Jiri Pirko <jiri@resnulli.us>, Ido Schimmel
	<idosch@nvidia.com>, Simon Horman <horms@kernel.org>,
	<linux-btrfs@vger.kernel.org>, <dm-devel@redhat.com>,
	<ntfs3@lists.linux.dev>, <linux-s390@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240201122216.2634007-1-aleksander.lobakin@intel.com>
 <20240201122216.2634007-12-aleksander.lobakin@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240201122216.2634007-12-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3hrTW04YmJYNElOY1Ixc052dW9MQkFNelhjVHUrZjJWSisxZk9PU3ljRDRl?=
 =?utf-8?B?S3AyUk5KTHQ0dEpKbDhlWEJjTFhEZU9mMitMYmdoZFpGNmtCRDlXMEdkMEhV?=
 =?utf-8?B?K0ZoZEs3dE81QSs3WGJtdE9qK083dWhtelk3WnFsTWM5bFg5TlRYYkthNzUw?=
 =?utf-8?B?UjJrcTBlRTJnQ2RrL3NkNFhZV0N0cHl0c3I0djZLdndKWkduaG5oZk5kbkRP?=
 =?utf-8?B?ZW5UQkxWTm5waExjVnpaNDBZbkRKclFJaUFNUVJRdkdGSURmV21ya29ZRFQx?=
 =?utf-8?B?SXFKZy82MTdyMDE0ZUpad3lUVG5VVndNc1BJc1htaGJCK0NMM3YwRXN2djVq?=
 =?utf-8?B?b3F2TEliWUdXSCtWdnZuOVZRZkloK2ZYVkljdGYyOUl0VUwwOHg1ZmRmcEE2?=
 =?utf-8?B?eXRLUVRmNXFETmtFMTZxb0xWNUhYLy9BdU5OUVRTeXg4SjQ3OWViWmxORkl3?=
 =?utf-8?B?aC81MVZRODRDMTZBWExNaVA1NGs3K2I0dGkxRWlzOTIzbWZMY1hrRW9Dd1hz?=
 =?utf-8?B?SGl3Zk1Gb1g5aVhOR3RNVUVIVzF0Vi9sZHB0YlFKZEVzZHZ1eGRyQkxOK205?=
 =?utf-8?B?TFh4SExJUnN2M05QcU0xbVZpMTljcnhpTVBvTU51TjU1NkdhVlVqY0dpREkz?=
 =?utf-8?B?MjZxbUNKZU9RS0g3dkhaajdUaWk3d211MXl4dzUwdlc2NHFXMnRoTTd6SXRH?=
 =?utf-8?B?dzdldDNFMS9BOUhPR0JZblNCelBrMWgxUEJKMXFTRGR3eDZZakNtQUtSSXJo?=
 =?utf-8?B?RkZwSkZidkJ5MGMrbHRUeHNDeUU2V3d4aThtakI3YUdQM2gyVm9IQ2l0eS91?=
 =?utf-8?B?cDMvS0hselJyeGJKQkRNa2gwL3ovVzRsTVNZNlcwRGRnd21PRjRIQ29kT0Zu?=
 =?utf-8?B?QjlvbTVOalhzdTlzZExEV2drQU1tOEoyd0VxUWpSUGxTcTBwOG1XYktDZC9h?=
 =?utf-8?B?eHFxTEhpZWRQYnB0WnFEU0R5OU9ERGtwSS81Rm9PQ0tjRHBiNUgveUhCY1pw?=
 =?utf-8?B?YnlGT214bktJR0xyQkh4QjAzMDJuOE44ZFBpbHlsTGkwOW0yWU9OWUhGcDMz?=
 =?utf-8?B?Rm9EcytsUGJPOGVlRDJ1RVZUYm5rang5cDFiZVB1aWhjSGtwUlh6RG8waDl2?=
 =?utf-8?B?bjYycXZxVldsWUg4cGtNMUYzSVY3R2hTYml1Vzd6T2dLUzU5a3ZwdSs5NEYr?=
 =?utf-8?B?c0hjcU1zZDRET1RNZEpWYy96Nys1aEFnZ0NYRGl1aEp0ZmcxdGNHTHZYb1k5?=
 =?utf-8?B?QmRIb1J6TTFBRkdEejNSMytZcHhzOC9aNTI4R2JEbTRkSEFnZjZuOGIvcGh2?=
 =?utf-8?B?M0dGRGpUM1AyWlVqOTkwWE05enVYaVRvSC9QQnRaQURuN2k0aEhGQjBRR2dT?=
 =?utf-8?B?K1l2NTJkRDRzMEU1VFkyTDZaV3h1NTRKOGxqMkZwSnU5UG5BZDNSQVVsNVEw?=
 =?utf-8?B?Q09nLzdKbm5NQko5NkF5UkNmOVFycTBDZ3gyYzR3eUpYVVBiSEprTWN4Y2Vm?=
 =?utf-8?B?WDAzelhoamJoMzVJTXZtOUkzN0lrRHBPZTBMQWljVGRMOTU1MEk2bCszMzY4?=
 =?utf-8?B?cExmNzdsdFVpOHlsU2NNSVpTSTV5dkhDQlM3S2JURThUSXVHRitKMm01aHFJ?=
 =?utf-8?B?cGtxRmRKUWNEYmNGdlhnMU4xVGJPTTMyeWZZWERxMEE3WjhDSW9RM1IrVmV6?=
 =?utf-8?B?UnhNME9mZmdBZU13TlhBZFBudXlOQkszbHQraUZvT0FwMFRLS0JmNU5tZG1L?=
 =?utf-8?B?cmViOC8wRUZpS3VwRS9hQ29BbGJ6WmNxVW9ZQThuZ3NGVlBZYkV2OFlLbjN5?=
 =?utf-8?B?cGQ5cVVKL0FlWHdSZVcvRzFuc0lpYXBGTjV1TlQ5eWc5RG50YmxMQVlDSUNm?=
 =?utf-8?B?ZkRmdzB1blc5VXZsUUJWU2FPZEVCc0xDYTlXd3k4SDBTZXZ3UWJJK2xSNnhE?=
 =?utf-8?B?K1g5NHpaWE1KOEM0b25WdXBhREF3TTd4YS9zZnZqdGVTakIya2drTnpFQmph?=
 =?utf-8?B?MVpzWnBZOXFidWQ0cFZ0c2JhVVZvN2VIN2NVRmJtZ09wN1JjR3Z5L0x4ekhq?=
 =?utf-8?B?R2hZSDBGOVkwa0luTHlqcTdQNUlTUnJXTS9MV250aDhmKzUvNjBsYjJlWitv?=
 =?utf-8?B?TWxtc2dibGE0ZndWbC94bGxvTVo5Tkxpb280SG9yMCtSc292SE9SYUMrNVFI?=
 =?utf-8?B?MlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09fa2ed5-fe72-4ad0-885a-08dc23e36b2b
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:38:04.3982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VWa99jho0GVibwLN2kSkXbVoe0JbG4QizQGg2o9zixWert2WkY1RhFpFvsExM0Q1fB13XVrR9MwvvAduzVBj5i3ouJ4YGblQWor7PY273c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4541
X-OriginatorOrg: intel.com

On 2/1/24 13:22, Alexander Lobakin wrote:
> Currently, tools have *ALIGN*() macros scattered across the unrelated
> headers, as there are only 3 of them and they were added separately
> each time on an as-needed basis.
> Anyway, let's make it more consistent with the kernel headers and allow
> using those macros outside of the mentioned headers. Create
> <linux/align.h> inside the tools/ folder and include it where needed.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
>   tools/include/linux/align.h  | 12 ++++++++++++
>   tools/include/linux/bitmap.h |  2 +-
>   tools/include/linux/mm.h     |  5 +----
>   3 files changed, 14 insertions(+), 5 deletions(-)
>   create mode 100644 tools/include/linux/align.h
> 

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>