Received-SPF: pass (google.com: domain of linux-kernel+bounces-49803-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 2 Feb 2024 12:54:50 +0100
From: Simon Horman <horms@kernel.org>
To: Matthew Wood <thepacketgeek@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	leitao@debian.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/8] net: netconsole: move netconsole_target
 config_item to config_group
Message-ID: <20240202115450.GN530335@kernel.org>
References: <20240126231348.281600-1-thepacketgeek@gmail.com>
 <20240126231348.281600-3-thepacketgeek@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240126231348.281600-3-thepacketgeek@gmail.com>

On Fri, Jan 26, 2024 at 03:13:37PM -0800, Matthew Wood wrote:
> In order to support a nested userdata config_group in later patches,
> use a config_group for netconsole_target instead of a
> config_item. It's a no-op functionality-wise, since
> config_group maintains all features of a config_item via the cg_item
> member.
> 
> Signed-off-by: Matthew Wood <thepacketgeek@gmail.com>
> ---
>  drivers/net/netconsole.c | 61 ++++++++++++++++++++++------------------
>  1 file changed, 33 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c

..

> @@ -665,8 +669,9 @@ static struct config_item *make_netconsole_target(struct config_group *group,
>  	if (!strncmp(name, NETCONSOLE_PARAM_TARGET_PREFIX,
>  		     strlen(NETCONSOLE_PARAM_TARGET_PREFIX))) {
>  		nt = find_cmdline_target(name);
> -		if (nt)
> -			return &nt->item;
> +		if (nt) {
> +			return &nt->group;
> +		}

nit: no need for {} here.

>  	}
>  
>  	nt = alloc_and_init();

..