Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp805865rdb; Fri, 2 Feb 2024 04:50:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX5VA5UaJTQMby/WLhaLl05Qu6y0fTpV7+35XkIdbxYm/pQ6JggUY2V6jd/LNsWf1HxdU1 X-Received: by 2002:aa7:83c3:0:b0:6dd:c7ea:29e with SMTP id j3-20020aa783c3000000b006ddc7ea029emr1949381pfn.12.1706878239355; Fri, 02 Feb 2024 04:50:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706878239; cv=pass; d=google.com; s=arc-20160816; b=CANuSTHE8i814cYZan26YD9HUFyV4Dc+Z8em1pinOcUoqeD/7luIWOB8yPdaaKtS2h 1v9Wnv7VxHWyiz7PLP7+ZEr3iHZrsJQkVU06eSNYQMKMdb6yz2+MejPNz/x0jrNuZIHf f72zwDtLdirjDz502T9fOK8Cs8KqY/qEzBZc1dvBr9CkYwA5RG6+nqH7Qx/RZBTSTovS ADihZAfAti/rI+KaHDR7gSiVschBUK1Njg9BPGYB/ibxTogP7GdV7aI7P6PTkLs0f6I6 dNlHNmtMF3DD4BFT7QVo+k/esGlVNo2qpHH1vesGmLmyklpcL6DbIU8j8knlTIHKDAwG zMhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xtiEZaIHtHECQGfxUsUlycP+++1X7usYGuZC9A91IFM=; fh=6fgtOASf3vuw7Bn7sGK3WR3+y6OhoCu1KdNVIDPh9mI=; b=jlwb5AgaY0NcSjuOKZS3xhFHvYZL8Hc4AR/mw2cMjkexz1BFqzmWRPVTC2Z5n46w/S kL0grL4rX3XkmPPiiDagew+6iRAmasvBSiSzcden84r6zmT9F7hKM/SQ+aNApw5Gxfbz AwdeQ6UQUbR/WyfECdh9+3R1uurvdMQxeMgnW2G49rduqyM7GxM+9611aQEWFCIMOqff mI+1d7KfiObliBOQdoFpy/uZ+ToNHMgG4JrJr6lHkNNYoifMnA/GYRPC5AwIzm4o+/ba /uXQeqai+EbAW/3ynDp0SKBFj71ycXYCZYsNVfMHS7RTJwzF/TspiKKf+CmBST+1r4rT Jjhw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6YrLgtZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-49863-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVMXXoP+RDnFb7n0pI9Zrv6+WvC0QCMmaEZ24yjqTbZqYT/bIZkno6aWFW/ATQqoOY7w8R4KQp3Zm534kcRXS7n8VS4Zo6NRhdvcCvfHQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b22-20020a6567d6000000b005cd8dc9694dsi1593813pgs.178.2024.02.02.04.50.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 04:50:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49863-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6YrLgtZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-49863-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D28C228544C for ; Fri, 2 Feb 2024 12:50:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25893440D; Fri, 2 Feb 2024 12:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p6YrLgtZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B4820F4 for ; Fri, 2 Feb 2024 12:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706878230; cv=none; b=irYlrnefIOT+/anRr6sKEwttTU07EgyA+dbzZTKRReA+ifQmXaUaYORpdpdjyYfqoX3/f9YNqsQk2l/+67+/pHgyXh2+HNzbdMH3dfc0TdK+wsmEcMTOwvECHc/nW9cuoPemoYTmkdS0AfH8YNCupIdMmh8zy1GTVswTL+YbNEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706878230; c=relaxed/simple; bh=yRAUEQ2OEGC0kPXDh7EskUX+yLmin6erghB34U7SLtw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mdljZgCGH0bLKEwlowGivdfuy6RIoZEdYv2sUWPXGGOLz81C8rcm90dB+0LxLyljk/pVf3htdgw3XuASnQKAwL+4T3us0HDTLp8zzXq6o87a+x0oUPXXJH1LXCf4stabnnL7VxigdK9wOpahEdFy39i/AA+fCd8BWzXnIq3Ic3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p6YrLgtZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAB65C43394; Fri, 2 Feb 2024 12:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706878229; bh=yRAUEQ2OEGC0kPXDh7EskUX+yLmin6erghB34U7SLtw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p6YrLgtZ2nEoN8GmGauznZJtU48bqI8OG8j3u/nkMArMjHjvX/cXr9P4gUOos2yWQ xXOIl2Nf48tE8mKSbolZtKMEUtbx0RRCGWICEycYR7k2YdmpNuVG3SrMDtRzy25WWa X+jd224A9FRtV8f8gwcd+kjGZbhgWoqzuYnQgUTaaTsyO7am6B52zhoKaVA5gt/X2C PspXI9JNNiR2lvN9ORQrYINWL/Ldmh3WZM5QSSzakNQ3IKmXbwMUoWNyDTm/tYfAaV +gQAE20OxpJFbfdtvSkS2zpgeUZBuYv5rvGWhhXjSqOYWZNIH9njI8Z6UemKiaDty6 RVew9JLvhiv7w== Date: Fri, 2 Feb 2024 13:50:25 +0100 From: Christian Brauner To: Oleg Nesterov Cc: "Eric W. Biederman" , Tycho Andersen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open() Message-ID: <20240202-helium-eurem-f63c0f9328c0@brauner> References: <20240131132541.GA23632@redhat.com> <20240131132602.GA23641@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240131132602.GA23641@redhat.com> > @@ -2050,6 +2051,8 @@ static void pidfd_show_fdinfo(struct seq_file *m, struct file *f) > > seq_put_decimal_ll(m, "Pid:\t", nr); > > + /* TODO: report PIDFD_THREAD */ So I think we don't need to do anything here. Since PIDFD_THREAD sets O_EXCL in file->f_flags and in contrast to do_dentry_open() it isn't dropped. So userspace can already detect PIDFD_NONBLOCK as O_NONBLOCK and PIDFD_THREAD as O_EXCL.