Received-SPF: pass (google.com: domain of linux-kernel+bounces-49959-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 2 Feb 2024 22:09:45 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Linus Walleij <linus.walleij@linaro.org>, guoren <guoren@kernel.org>,
	Brian Cain <bcain@quicinc.com>, Jonas Bonn <jonas@southpole.se>, "Stefan
 Kristiansson" <stefan.kristiansson@saunalahti.fi>, Stafford Horne
	<shorne@gmail.com>, Linux-Arch <linux-arch@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, "linux-csky@vger.kernel.org"
	<linux-csky@vger.kernel.org>, <linux-hexagon@vger.kernel.org>,
	"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt
Message-ID: <Zbz3qVq+8le1xuKr@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20240131055159.2506-1-yan.y.zhao@intel.com>
 <5e55b5c0-6c8d-45b4-ac04-cf694bcb08d3@app.fastmail.com>
 <ZbrfcTaiuu2gaa2A@yzhao56-desk.sh.intel.com>
 <9f27c23b-ea8b-443c-b09c-03ecaa210cd5@app.fastmail.com>
 <Zbw/PpNkCQCbXPdP@yzhao56-desk.sh.intel.com>
 <33a5d3a9-3154-4dad-afae-18b16e6cf61e@app.fastmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <33a5d3a9-3154-4dad-afae-18b16e6cf61e@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f1RLqVPwIWnXKGSHCAWw+UD85Lj7J7bQH13oUGPsKEMu6nv1uplNt21YBdc+?=
 =?us-ascii?Q?tRv5wjfECIvB+Yt2DOGQWnXjeoTNs2zB0p08vAa2EYlGPja4Y/xNLZCErAjE?=
 =?us-ascii?Q?1kw//HR5K60sUiCapiDJ1G4ltS0797CD2xXFqjs3s3erbYpOZuS89XsNKo+5?=
 =?us-ascii?Q?+ZxdWjzUItrYuT48fL2A2HRwRt5sA32WfMDywR3xtVX8z08qWt7z6WxumTYt?=
 =?us-ascii?Q?1dtDZEaas0jbZLPI8FtiFnLSYokuXRvJpWNL9JHpahe0OdRyLbhDVCYB9jOY?=
 =?us-ascii?Q?BKQt/iYiTT5p3Sa5mNWMWiEJdcq7ON1Q+48t55pJF8jOLR0dcP7tagxw1FLO?=
 =?us-ascii?Q?6iz0HebsL4vj/yobxeBYvc7V1boQLOUIpygoaxocd/MIPqVvcGzWWEn8MCbO?=
 =?us-ascii?Q?3xVJfkV2LiHXE/dzpwwGgRhcr5iiCtqFy44KbmSw8FjwgaIT+d3hr5QwmOi2?=
 =?us-ascii?Q?mXR3efaCVyb+zlUmD5kELxq7qsFyhWqQb+HVns+F+SUh6xe1mS2J3PEfULAs?=
 =?us-ascii?Q?vMKomjn2S6Gr6gfvss4qNkVywSj8ok+TiCHb8Lmcv6Rhzs+/9DP11tLtyP+Y?=
 =?us-ascii?Q?VFy5aL4Hzlvb7OVXZAE27c7VmQFuQTo1ykgh8augBNJJfSz5og4rc6HXOcUZ?=
 =?us-ascii?Q?CqXAfMXgLoCgu7LVQ9rwFepZHBGPGXtdjodZ/7IRYO6GxwLKY66ZDTgRid2/?=
 =?us-ascii?Q?RPosQ35bzht9neEx0mHZ8CiQwceIDvRxau31sjEvnfWzvO3nlCf0Bi9A6Don?=
 =?us-ascii?Q?AyuwTNNd7AqpFxYMcZnw3SMp11EpIMTo8wXdTO4HgWZwDhKVIsMHQxHxAunM?=
 =?us-ascii?Q?kqguuP83xksmO/Oohriq23Dk4sAdUvm8W7aticTxuxhnF9208RjrBCUH/K7L?=
 =?us-ascii?Q?GtpsseGa0rLo2iUt25dSJ8d29Fe6YLpO8l7B/gzIY7JOI5OUATcmNyz65HQ1?=
 =?us-ascii?Q?QZEak1WV7pLbfBwwRktqli9EC0UBEPcRHnFFHTjj1lOuUdcCDkbqsAqvtFMz?=
 =?us-ascii?Q?hEODLfuZUSB8TeiSG6JK18H8UbI9W4VwilOgnT7FN+suI7Kr8Nl3mJGk0loB?=
 =?us-ascii?Q?O9ZvghlyyP1ZO/Zz3QYc7VhSysZJiIXQO1/JP8mLTLtzGAEGMFP/oHXe6nQ8?=
 =?us-ascii?Q?CkcdduYkurqIJa0BsNZEAuFHOL4KXytOfn25ZuXSgZh8TKBe3j0DIOT/GWZo?=
 =?us-ascii?Q?YYBpBOMVt2fg3+cMDLm1MtG3ow123wbofAow5RE6D+E9OyRKPBstKSpK92tj?=
 =?us-ascii?Q?P76TNySAgkaPac0d/4zlCvdK5bFJLLBAlKTLkSIJ9FMbRT2uJ5N1H7svzoHv?=
 =?us-ascii?Q?BtQf62QWT7DSGbKW6V7qBT2TaCwKu411aRQmYFUYFlFjl0IR9LpIm/YuzNeq?=
 =?us-ascii?Q?eC669Jx6MghY4DIKrynwc2RMzZDYXxP0wQLAeV5AxsYecuDNU34ivO8yIo0s?=
 =?us-ascii?Q?tSgoJpwSZpHExw0X0TqtvE0M8g0hwSuMI6omNzctAw2ZnIuVpKGsMdTrAoRe?=
 =?us-ascii?Q?AfUUV1zQlNRRt0ipxwaliZfKzCDESRU1ezBM+0oWa4YWpGugL+c/PKUcMvEr?=
 =?us-ascii?Q?kRyYGSGX3W9xS2qO7eigzoTxY9IHSvTlJxUfRB1w?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ed646ca-b1e2-4fa2-2eea-08dc23fcbd4b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 14:39:19.5621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9PLCsTVo+NLyxkEtylqxyhQ6SWAaxPKV7A7/WU+2j+JBsPCKCdO5UwMIAojHo2Xxo2djOsFaN8PpgMcZ5J2t2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7572
X-OriginatorOrg: intel.com

On Fri, Feb 02, 2024 at 08:04:34AM +0100, Arnd Bergmann wrote:
> On Fri, Feb 2, 2024, at 02:02, Yan Zhao wrote:
> > On Thu, Feb 01, 2024 at 06:46:46AM +0100, Arnd Bergmann wrote:
> >> 
> >> I think it's fair to assume we won't need asm-generic/page.h any
> >> more, as we likely won't be adding new NOMMU architectures.
> >> I can have a look myself at removing any such unused headers in
> >> include/asm-generic/, it's probably not the only one.
> >> 
> >> Can you just send a patch to remove the unused pfn_to_virt()
> >> functions?
> > Ok. I'll do it!
> > BTW: do you think it's also good to keep this fixing series though we'll
> > remove the unused function later?
> > So if people want to revert the removal some day, they can get right one.
> >
> > Or maybe I'm just paranoid, and explanation about the fix in the commit
> > message of patch for function removal is enough.
> >
> > What's your preference? :)
> 
> I would just remove it, there is no point in having both
> pfn_to_kaddr() and pfn_to_virt() when they do the exact
> same thing aside from this bug.
>
> Just do a single patch for all architectures, no need to
> have three or four identical ones when I'm going to merge
> them all through the same tree anyway.
> 
> Just make sure you explain in the changelog what the bug was
> and how you noticed it, in case anyone is ever tempted to
> bring the function back.
Done.
https://lore.kernel.org/all/20240202140550.9886-1-yan.y.zhao@intel.com
Thanks for you guidance :)