Received-SPF: pass (google.com: domain of linux-kernel+bounces-49967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240202133638.4720-1-quic_wasimn@quicinc.com> <20240202133638.4720-2-quic_wasimn@quicinc.com>
In-Reply-To: <20240202133638.4720-2-quic_wasimn@quicinc.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Fri, 2 Feb 2024 16:51:27 +0200
Message-ID: <CAA8EJpqARMwKhybgsFDKNZ=-uSAY=j4ocdZ=ax5U1KVPNXBTCg@mail.gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board
To: Wasim Nazir <quic_wasimn@quicinc.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel@quicinc.com
Content-Type: text/plain; charset="UTF-8"

On Fri, 2 Feb 2024 at 15:37, Wasim Nazir <quic_wasimn@quicinc.com> wrote:
>
> Document board bindings for Rb5 gen2 hardware development kit.
> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2-HDK is development kit used for IOT solutions.

What is the actual marketing name for the SoM and the carrier board?
The RB5gen2-HDK doesn't follow the previous example of the RB* boards
and doesn't sound in tune with the RB3gen2 submission.
Could you please sync up internally and come up with two similar names
for the platforms with similar purpose?

>
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 9cee874a8eae..ce5b5dfe0e46 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -104,6 +104,7 @@ description: |
>          qcp
>          qrd
>          rb2
> +        rb5gen2-hdk
>          ride
>          sbc
>          x100
> @@ -915,6 +916,14 @@ properties:
>            - const: qcom,qcm8550
>            - const: qcom,sm8550
>
> +      - items:
> +          - enum:
> +              - qcom,qcs8550-rb5gen2-hdk
> +          - const: qcom,qcs8550-rb5gen2
> +          - const: qcom,qcs8550
> +          - const: qcom,qcm8550
> +          - const: qcom,sm8550
> +
>        - items:
>            - enum:
>                - qcom,sa8155p-adp
> --
> 2.43.0
>
>


-- 
With best wishes
Dmitry