Received-SPF: pass (google.com: domain of linux-kernel+bounces-50125-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 2 Feb 2024 16:20:40 +0000
From: Al Viro <viro@zeniv.linux.org.uk>
To: JonasZhou-oc <JonasZhou-oc@zhaoxin.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, CobeChen@zhaoxin.com,
	LouisQi@zhaoxin.com, JonasZhou@zhaoxin.com
Subject: Re: [PATCH] fs/address_space: move i_mmap_rwsem to mitigate a false
 sharing with i_mmap.
Message-ID: <20240202162040.GA2087318@ZenIV>
References: <20240202083304.10995-1-JonasZhou-oc@zhaoxin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240202083304.10995-1-JonasZhou-oc@zhaoxin.com>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Fri, Feb 02, 2024 at 04:33:04PM +0800, JonasZhou-oc wrote:
> From: JonasZhou <JonasZhou@zhaoxin.com>
> 
> In the struct address_space, there is a 32-byte gap between i_mmap
> and i_mmap_rwsem. Due to the alignment of struct address_space
> variables to 8 bytes, in certain situations, i_mmap and i_mmap_rwsem
> may end up in the same CACHE line.
> 
> While running Unixbench/execl, we observe high false sharing issues
> when accessing i_mmap against i_mmap_rwsem. We move i_mmap_rwsem
> after i_private_list, ensuring a 64-byte gap between i_mmap and
> i_mmap_rwsem.
> 
> For Intel Silver machines (2 sockets) using kernel v6.8 rc-2, the score
> of Unixbench/execl improves by ~3.94%, and the score of Unixbench/shell
> improves by ~3.26%.

Looks sane.